Skip to content

Commit a6f6acf

Browse files
feat(update_expected)!: change default of --implementation-status to backlog
1 parent 565a986 commit a6f6acf

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

moz-webgpu-cts/src/main.rs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,8 @@ enum Subcommand {
115115
/// The heuristic for resolving differences between current metadata and processed reports.
116116
#[clap(value_enum, long, default_value_t = UpdateExpectedPreset::ResetContradictory)]
117117
preset: UpdateExpectedPreset,
118-
/// `implementation-status`es that changes should be applied to. If not specified, defaults
119-
/// to `implementing`.
120-
#[clap(value_enum, long)]
118+
/// `implementation-status`es that changes should be applied to.
119+
#[clap(value_enum, long, default_value = "backlog")]
121120
implementation_status: Vec<ImplementationStatus>,
122121
},
123122
/// Parse test metadata, apply automated fixups, and re-emit it in normalized form.
@@ -360,11 +359,14 @@ fn run(cli: Cli) -> ExitCode {
360359
preset,
361360
implementation_status,
362361
} => {
363-
let allowed_implementation_statuses = if implementation_status.is_empty() {
364-
ImplementationStatus::default().into()
365-
} else {
366-
EnumSet::from_iter(implementation_status)
367-
};
362+
assert!(
363+
!implementation_status.is_empty(),
364+
concat!(
365+
"internal error: should not be possible ",
366+
"to have an empty `--implementation-status` option from CLI"
367+
)
368+
);
369+
let allowed_implementation_statuses = EnumSet::from_iter(implementation_status);
368370
match process_reports(
369371
browser,
370372
&checkout,

0 commit comments

Comments
 (0)