Skip to content

Commit f72b48a

Browse files
committed
Revert "fix(ci): isolate gxt runtime from classic-mode bundle via alias stub"
This reverts commit 1002792.
1 parent 1002792 commit f72b48a

3 files changed

Lines changed: 2 additions & 212 deletions

File tree

packages/@ember/-internals/glimmer/lib/gxt-stub.ts

Lines changed: 0 additions & 185 deletions
This file was deleted.

packages/@ember/-internals/glimmer/lib/views/outlet.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ export default class OutletView {
7474
},
7575
};
7676

77-
if ((globalThis as any).__GXT_MODE__) {
78-
cellFor(outletState.outlets, 'main');
79-
}
77+
cellFor(outletState.outlets, 'main');
8078

8179
let ref = (this.ref = outletState);
8280

vite.config.mjs

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -265,30 +265,7 @@ export default defineConfig(({ mode }) => {
265265
},
266266
],
267267
}
268-
: {
269-
// Classic mode: redirect every `@lifeart/gxt` import to a no-op
270-
// shim. A handful of files in @ember/-internals/glimmer/lib/
271-
// statically import from `@lifeart/gxt` so they can hot-swap
272-
// between classic and gxt rendering at runtime via
273-
// `__GXT_MODE__`. Without this alias, classic-mode bundles pull
274-
// in ~35k LOC of glimmer-next runtime that classic mode never
275-
// executes — and worse, side-effecting init code from that
276-
// runtime breaks classic Glimmer-VM (e.g. cellFor turning
277-
// outlets.main into a cell-backed accessor). The alias keeps
278-
// the imports resolvable while shipping a tiny no-op shim.
279-
alias: [
280-
{
281-
// Anchor to exact match — without ^...$ Vite treats the find
282-
// as a prefix and rewrites `@lifeart/gxt/glimmer-compatibility`
283-
// and `@lifeart/gxt/runtime-compiler` too, which breaks
284-
// gxt-backend modules that classic-mode tests load directly.
285-
find: /^@lifeart\/gxt$/,
286-
replacement: fileURLToPath(
287-
new URL(`./packages/@ember/-internals/glimmer/lib/gxt-stub.ts`, owerrideRoot)
288-
),
289-
},
290-
],
291-
},
268+
: undefined,
292269
};
293270
});
294271

0 commit comments

Comments
 (0)