[bugfix release] Fix implicit-modules naming

The bug here is:
 - in a classic build
 - with use-ember-modules enabled
 - a v1 addon that does not have a dependency on ember-auto-import
 - tries to access a module from ember that nobody else was already importing via ember-auto-import

This case is supposed to work because of the implicit-modules list defined in lib/index.js. But that list had several mismatches between the actual files in `dist` and the way they're spelled in lib/index.js. ember-auto-import cares about the difference.

If we backport this (possibly as far as 6.10, since that's where use-ember-modules is introduced), we need to be aware of making this list match the actual `dist` produced on that ember version. These files changed at the point where the glimmer packages moved into the monorepo.

(cherry picked from commit cbb4e31)

Author: ef4

lib/index.js

@@ -175,31 +175,31 @@ const shim = addonV1Shim(path.join(__dirname, '..'), {
             './dist/packages/@ember/utils/lib/is_present.js',
             './dist/packages/@ember/utils/lib/type-of.js',
             './dist/packages/@ember/version/index.js',
-            './dist/packages/@glimmer/destroyable.js',
-            './dist/packages/@glimmer/encoder.js',
-            './dist/packages/@glimmer/env.js',
-            './dist/packages/@glimmer/global-context.js',
-            './dist/packages/@glimmer/manager.js',
-            './dist/packages/@glimmer/node.js',
-            './dist/packages/@glimmer/opcode-compiler.js',
-            './dist/packages/@glimmer/owner.js',
-            './dist/packages/@glimmer/program.js',
-            './dist/packages/@glimmer/reference.js',
-            './dist/packages/@glimmer/runtime.js',
+            './dist/packages/@glimmer/destroyable/index.js',
+            './dist/packages/@glimmer/encoder/index.js',
+            './dist/packages/@glimmer/env/index.js',
+            './dist/packages/@glimmer/global-context/index.js',
+            './dist/packages/@glimmer/manager/index.js',
+            './dist/packages/@glimmer/node/index.js',
+            './dist/packages/@glimmer/opcode-compiler/index.js',
+            './dist/packages/@glimmer/owner/index.js',
+            './dist/packages/@glimmer/program/index.js',
+            './dist/packages/@glimmer/reference/index.js',
+            './dist/packages/@glimmer/runtime/index.js',
             './dist/packages/@glimmer/tracking/index.js',
-            './dist/packages/@glimmer/tracking/primitives/cache.js',
-            './dist/packages/@glimmer/util.js',
-            './dist/packages/@glimmer/validator.js',
-            './dist/packages/@glimmer/vm.js',
-            './dist/packages/@glimmer/wire-format.js',
-            './dist/packages/@simple-dom/document.js',
+            './dist/packages/@glimmer/tracking/primitives/cache/index.js',
+            './dist/packages/@glimmer/util/index.js',
+            './dist/packages/@glimmer/validator/index.js',
+            './dist/packages/@glimmer/vm/index.js',
+            './dist/packages/@glimmer/wire-format/index.js',
+            './dist/packages/@simple-dom/document/index.js',
             './dist/packages/backburner.js/index.js',
-            './dist/packages/dag-map.js',
+            './dist/packages/dag-map/index.js',
             './dist/packages/ember/index.js',
             './dist/packages/ember/version.js',
-            './dist/packages/route-recognizer.js',
-            './dist/packages/router_js.js',
-            './dist/packages/rsvp.js',
+            './dist/packages/route-recognizer/index.js',
+            './dist/packages/router_js/index.js',
+            './dist/packages/rsvp/index.js',
           ],
           'implicit-test-modules': [
             './dist/packages/ember-testing/index.js',

pnpm-lock.yaml

@@ -86,6 +86,20 @@ function basicTest(scenarios: Scenarios, appName: string) {
           },
         },
         tests: {
+          unit: {
+            'v1-addon-without-eai-test.js': `
+              import { module, test } from 'qunit';
+              import { accessGlimmerValidator } from 'v1-addon-without-eai';
+              module('Acceptance | v1-addon-without-eai', function (hooks) {
+                // a v1 addon without ember-auto-import needs to maintain access
+                // to all the backward-compatible ember-provided packages, regardless
+                // of our build environment and optional-features.
+                test('can access things from ember', function(assert) {
+                  assert.strictEqual(accessGlimmerValidator(), 'it works');
+                })
+              });
+            `,
+          },
           acceptance: {
             'example-gjs-route-test.js': `
               import { module, test } from 'qunit';
@@ -226,6 +240,23 @@ function basicTest(scenarios: Scenarios, appName: string) {
           },
         },
       });
+
+      let v1AddonWithoutEAI = project.addDependency('v1-addon-without-eai');
+      v1AddonWithoutEAI.pkg.keywords = ['ember-addon'];
+      v1AddonWithoutEAI.linkDependency('ember-cli-babel', { baseDir: __dirname } );
+      v1AddonWithoutEAI.mergeFiles({
+        'index.js': 'module.exports = { name: "v1-addon-without-eai" }',
+        addon: {
+          'index.js': `
+            import { consumeTag } from '@glimmer/validator';
+            export function accessGlimmerValidator() {
+              if (typeof consumeTag === 'function') {
+                return "it works"
+              }
+            }
+          `
+        }
+      });
     })
     .forEachScenario((scenario) => {
       Qmodule(scenario.name, function (hooks) {

smoke-tests/scenarios/basic-test.ts

@@ -9,6 +9,7 @@
     "@swc/core": "^1.4.17",
     "@swc/types": "^0.1.6",
     "@types/node": "^20.12.7",
+    "ember-cli-babel": "^8.3.1",
     "ember-cli-htmlbars-6": "npm:ember-cli-htmlbars@^6.0.0",
     "qunit": "^2.20.1",
     "scenario-tester": "^4.0.0",