Skip to content

Commit cfe606e

Browse files
Merge pull request #21352 from NullVoxPopuli-ai-agent/nvp/fix-barrel-imports-lint
Preserve barrel side effects when rewriting deep imports
2 parents 753eba9 + fb0e583 commit cfe606e

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

packages/@glimmer/runtime/index.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
/**
2-
* @deprecated use RichIteratorResult<Tick, Return> or TemplateIterator instead
3-
*/
4-
import './lib/bootstrap';
5-
61
import type { RichIteratorResult } from '@glimmer/interfaces';
72

83
export { clear, ConcreteBounds, CursorImpl } from './lib/bounds';

packages/@glimmer/runtime/lib/vm/low-level.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ import { $fp, $pc, $ra, $sp } from '@glimmer/vm/lib/registers';
1616
import type { DebugState } from '../opcodes';
1717
import type { VM } from './append';
1818

19+
// Loading the VM is what creates the demand for opcode handlers — its
20+
// `evaluateSyscall` calls `APPEND_OPCODES.evaluate(...)`. Pull bootstrap in
21+
// here (rather than at the package barrel) so consumers using deep imports
22+
// still get every opcode handler registered before the VM runs.
23+
import '../bootstrap';
1924
import { APPEND_OPCODES } from '../opcodes';
2025

2126
export type LowLevelRegisters = [$pc: number, $ra: number, $sp: number, $fp: number];

0 commit comments

Comments
 (0)