Skip to content

Commit bd08bd0

Browse files
lifeartclaude
andcommitted
fix(gxt-backend): raise cumulative foreign-fire cap to 1500
CI evidence on commit a42b371: cumulative cap at 200 caught the hang (Basic Test 13min instead of 41min) but regressed 700+ tests in the load-bearing-leak cluster. The cap was firing on legitimate cross-test reactor activity (Ember test infrastructure propagates some dirties across tests for shared setup chains). Move the cap above the observed leak signature peak (1140 lifetime fires per leaked reactor in CI) but still bounded so an unbounded runaway can't saturate the runloop indefinitely. 1500 leaves room for shared-setup chains without leaving unbounded-leak headroom. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
1 parent a42b371 commit bd08bd0

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

packages/@ember/-internals/gxt-backend/validator.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -728,11 +728,13 @@ const REACTOR_FOREIGN_FIRE_CAP = 100;
728728
// Cap on CUMULATIVE fires across all foreign tests (never resets).
729729
// Catches slow leaks where fires are spread across many tests but
730730
// never concentrate enough in any one. CI evidence: leaked reactors
731-
// fire ~50 times per foreign test (under the per-test cap) but
732-
// totalForeignFires reaches 1000+ across the run. 200 catches this
733-
// well above any plausible legitimate cross-test reactivity (real
734-
// reactors don't fire across foreign tests at all).
735-
const REACTOR_TOTAL_FOREIGN_FIRE_CAP = 200;
731+
// fire ~50 times per foreign test, accumulating 1000-1140 lifetime
732+
// fires before timeout. 1500 sits above the observed peak so
733+
// legitimate cross-test reactor activity (some Ember test
734+
// infrastructure does propagate dirties across tests for shared
735+
// setup) isn't culled, while still bounding the unbounded-runaway
736+
// case where leaked reactors would fire indefinitely.
737+
const REACTOR_TOTAL_FOREIGN_FIRE_CAP = 1500;
736738
const NO_TEST_SENTINEL = '<no-test>';
737739

738740
function _fireClassicReactors() {

0 commit comments

Comments
 (0)