Cleanup

Author: NullVoxPopuli

smoke-tests/scenarios/strict-resolver-substates-test.ts

@@ -3,17 +3,6 @@ import type { PreparedApp } from 'scenario-tester';
 import * as QUnit from 'qunit';
 const { module: Qmodule, test } = QUnit;
 
-// Companion to `basic-test.ts`: builds a full v2 app wired up with the
-// strict resolver (modules: { ...import.meta.glob(...) }) and exercises
-// Ember's auto-generated loading/error substates through real route
-// transitions. Covers:
-//
-//   - visiting /         (plain route + template — sanity)
-//   - visiting /slow     (async model -> loading substate)
-//   - visiting /broken   (rejected model -> error substate)
-//
-// Nested/dynamic route coverage lives in strict-resolver-test.ts so we
-// don't pay to rebuild it here.
 strictAppScenarios
   .map('strict-resolver-substates', (project) => {
     project.mergeFiles({
@@ -47,9 +36,7 @@ strictAppScenarios
           });
         `,
         services: {
-          // A controllable gate for /slow's model. Tests call hold() to
-          // receive a promise and release() to resolve it — that lets the
-          // loading substate observably appear before the main template.
+          // RSVP.defer-as-a-service
           'gate.js': `
             import Service from '@ember/service';
 
@@ -114,14 +101,9 @@ strictAppScenarios
           'slow.hbs': `
             <div data-test="slow-ready">{{@model.message}}</div>
           `,
-          // Auto-generated loading substate for /slow. Ember will resolve
-          // template:slow_loading -> slow-loading -> templates/slow-loading.
           'slow-loading.hbs': `
             <div data-test="slow-loading">Loading slow route...</div>
           `,
-          // Auto-generated error substate for /broken. The error model is
-          // the thrown value, so we render its .message to prove the
-          // template received it.
           'broken-error.hbs': `
             <div data-test="broken-error">Caught error: {{@model.message}}</div>
           `,

smoke-tests/scenarios/strict-resolver-test.ts

@@ -19,8 +19,6 @@ strictAppScenarios
               ...import.meta.glob('./services/**/*.{js,ts}', { eager: true }),
               ...import.meta.glob('./controllers/**/*.{js,ts}', { eager: true }),
               ...import.meta.glob('./routes/**/*.{js,ts}', { eager: true }),
-              ...import.meta.glob('./components/**/*.{gjs,gts,js,ts}', { eager: true }),
-              ...import.meta.glob('./helpers/**/*.{js,ts}', { eager: true }),
               ...import.meta.glob('./templates/**/*.hbs', { eager: true }),
             };
           }
@@ -185,11 +183,6 @@ strictAppScenarios
               });
 
               test('parent route with auto-generated index renders both templates', async function (assert) {
-                // Visiting /posts activates posts + posts.index. Both
-                // templates must resolve: posts.hbs (with {{outlet}}) and
-                // posts/index.hbs (nested under a folder). Proves the
-                // strict resolver handles both the parent and the nested
-                // \`type:name.index\` -> \`type/name/index\` path.
                 await visit('/posts');
                 assert.strictEqual(currentURL(), '/posts');
                 assert.dom('[data-test="posts"]').exists('parent template rendered');
@@ -203,9 +196,6 @@ strictAppScenarios
               });
 
               test('dynamic nested child renders alongside its parent template', async function (assert) {
-                // /posts/42 activates both posts (parent) and posts.show
-                // (child). The parent template must still be present —
-                // the child renders into its {{outlet}}.
                 await visit('/posts/42');
                 assert.strictEqual(currentURL(), '/posts/42');
                 assert.dom('[data-test="posts"]').exists('parent template still rendered');
@@ -214,10 +204,6 @@ strictAppScenarios
               });
 
               test('three-level nested route resolves every level', async function (assert) {
-                // /posts/42/comments activates posts -> posts.show ->
-                // posts.show.comments. Every template in the chain must
-                // resolve, and the strict resolver must walk
-                // template:posts.show.comments -> templates/posts/show/comments.
                 await visit('/posts/42/comments');
                 assert.strictEqual(currentURL(), '/posts/42/comments');
                 assert.dom('[data-test="posts"]').exists('level 1: posts.hbs');