Skip to content

Commit 70a8c0e

Browse files
NullVoxPopuliclaude
andcommitted
Move build-info-test back to tests/node/
build-info-test tests build infrastructure (broccoli/build-info), not node support. It can't run as a smoke test because broccoli/ is not in the published package's files list. Co-Authored-By: Claude Opus 4.6 <[email protected]>
1 parent 1c760d5 commit 70a8c0e

3 files changed

Lines changed: 16 additions & 3 deletions

File tree

.github/workflows/ci-jobs.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,20 @@ jobs:
152152
run: |
153153
${{ matrix.command }}
154154
155+
node-test:
156+
name: Node.js Tests
157+
runs-on: ubuntu-latest
158+
needs: [basic-test, lint, types]
159+
steps:
160+
- uses: actions/checkout@v4
161+
- uses: ./.github/actions/setup
162+
- name: build
163+
env:
164+
SHOULD_TRANSPILE_FOR_NODE: true
165+
run: pnpm build
166+
- name: test
167+
run: pnpm test:node
168+
155169
blueprint-test:
156170
name: Blueprint Tests
157171
runs-on: ubuntu-latest

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@
5656
"lint:format:fix": "prettier --write .",
5757
"test": "testem ci -f testem.js --host 127.0.0.1 --port 13141",
5858
"test:blueprints": "mocha node-tests/blueprints/**/*-test.js",
59+
"test:node": "qunit tests/node/**/*-test.js",
5960
"test:browserstack": "node bin/run-browserstack-tests.js",
6061
"test:wip": "vite build --mode development --minify false && testem ci",
6162
"type-check:internals": "tsc --noEmit",

smoke-tests/node-template/tests/node/build-info-test.js renamed to tests/node/build-info-test.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
'use strict';
22

3-
const path = require('path');
4-
const emberSourceRoot = path.dirname(require.resolve('ember-source/package.json'));
5-
const { buildVersion, parseTagVersion, buildFromParts } = require(path.join(emberSourceRoot, 'broccoli', 'build-info'));
3+
const { buildVersion, parseTagVersion, buildFromParts } = require('../../broccoli/build-info');
64

75
QUnit.module('buildVersion', () => {
86
flatMap(

0 commit comments

Comments
 (0)