Merge pull request #21323 from johanrd/perf/destroyable-remove-swap-pop

Perf: destroyable remove swap pop (render)

Author: NullVoxPopuli

packages/@glimmer/destroyable/index.ts

@@ -67,7 +67,11 @@ function remove<T extends object>(collection: OneOrMany<T>, item: T, message: st
 
   if (isBrandedArray(collection) && collection.length > 1) {
     let index = collection.indexOf(item);
-    collection.splice(index, 1);
+    let lastIndex = collection.length - 1;
+    if (index !== lastIndex) {
+      collection[index] = collection[lastIndex] as T;
+    }
+    collection.length = lastIndex;
     return collection;
   } else {
     return null;