Merge pull request #21061 from emberjs/nvp/text-node-merging-fix-no-longer-needed

Remove 'text-node-merging-fix'

Author: NullVoxPopuli

packages/@glimmer/runtime/lib/compat/text-node-merging-fix.ts

@@ -3,17 +3,11 @@ import type {
   ElementNamespace,
   GlimmerTreeConstruction,
   Nullable,
-  SimpleDocument,
   SimpleElement,
 } from '@glimmer/interfaces';
-import { castToSimple } from '@glimmer/debug-util';
 
-import { applyTextNodeMergingFix } from '../compat/text-node-merging-fix';
 import { DOMOperations } from './operations';
 
-const doc: Nullable<SimpleDocument> =
-  typeof document === 'undefined' ? null : castToSimple(document);
-
 export class TreeConstruction extends DOMOperations implements GlimmerTreeConstruction {
   createElementNS(namespace: ElementNamespace, tag: string): SimpleElement {
     return this.document.createElementNS(namespace, tag);
@@ -33,11 +27,5 @@ export class TreeConstruction extends DOMOperations implements GlimmerTreeConstr
   }
 }
 
-let appliedTreeConstruction = TreeConstruction;
-appliedTreeConstruction = applyTextNodeMergingFix(
-  doc,
-  appliedTreeConstruction
-) as typeof TreeConstruction;
-
-export const DOMTreeConstruction = appliedTreeConstruction;
+export const DOMTreeConstruction = TreeConstruction;
 export type DOMTreeConstruction = TreeConstruction;

packages/@glimmer/runtime/lib/dom/api.ts

@@ -5,9 +5,7 @@ import type {
   SimpleElement,
   SimpleNode,
 } from '@glimmer/interfaces';
-import { castToSimple } from '@glimmer/debug-util';
 
-import { applyTextNodeMergingFix } from '../compat/text-node-merging-fix';
 import { BLACKLIST_TABLE, DOMOperations } from './operations';
 
 [
@@ -60,9 +58,6 @@ import { BLACKLIST_TABLE, DOMOperations } from './operations';
 const WHITESPACE =
   /[\t\n\v\f\r \xa0\u{1680}\u{180e}\u{2000}-\u{200a}\u{2028}\u{2029}\u{202f}\u{205f}\u{3000}\u{feff}]/u;
 
-const doc: Nullable<SimpleDocument> =
-  typeof document === 'undefined' ? null : castToSimple(document);
-
 export function isWhitespace(string: string) {
   return WHITESPACE.test(string);
 }
@@ -88,9 +83,5 @@ export class DOMChangesImpl extends DOMOperations implements GlimmerTreeChanges
   }
 }
 
-let helper = DOMChangesImpl;
-
-helper = applyTextNodeMergingFix(doc, helper) as typeof DOMChangesImpl;
-
-export const DOMChanges = helper;
+export const DOMChanges = DOMChangesImpl;
 export { DOMTreeConstruction } from './api';

packages/@glimmer/runtime/lib/dom/helper.ts

@@ -97,9 +97,6 @@ export class DOMOperations {
     } else {
       // Non-element nodes do not support insertAdjacentHTML, so add an
       // element and call it on that element. Then remove the element.
-      //
-      // This also protects Edge, IE and Firefox w/o the inspector open
-      // from merging adjacent text nodes. See ./compat/text-node-merging-fix.ts
       const { uselessElement } = this;
 
       parent.insertBefore(uselessElement, nextSibling);