fix review comments: use eslint config instead of globals DOMRect DOMRectList, unused function, and avoid declaring global types

Author: johanrd

eslint.config.mjs

@@ -154,6 +154,10 @@ export default [
         Symbol: true,
         WeakMap: true,
         Event: true,
+        MouseEvent: true,
+        KeyboardEvent: true,
+        DOMRect: true,
+        DOMRectList: true,
       },
 
       ecmaVersion: 2017,

packages/@ember/-internals/environment/lib/global.ts

@@ -1,15 +1,14 @@
 import type { GlobalContext } from './context';
 
-declare global {
-  var Ember: Partial<GlobalContext> | undefined;
-  var EmberENV:
-    | (Record<string, unknown> & {
-        EXTEND_PROTOTYPES?: boolean;
-        EMBER_LOAD_HOOKS?: Record<string, unknown>;
-        FEATURES?: Record<string, unknown>;
-      })
-    | undefined;
+export interface EmberGlobal {
+  Ember?: Partial<GlobalContext>;
+  EmberENV?: Record<string, unknown> & {
+    EXTEND_PROTOTYPES?: boolean;
+    EMBER_LOAD_HOOKS?: Record<string, unknown>;
+    FEATURES?: Record<string, unknown>;
+  };
+  [key: string]: unknown;
 }
 
 // export real global
-export default globalThis;
+export default globalThis as unknown as EmberGlobal;

packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-angle-test.js

@@ -1,4 +1,3 @@
-/* globals MouseEvent */
 import {
   ApplicationTestCase,
   ModuleBasedTestResolver,

packages/@ember/-internals/glimmer/tests/integration/components/utils-test.js

@@ -1,4 +1,3 @@
-/* globals DOMRect DOMRectList */
 import { moduleFor, ApplicationTestCase, RenderingTestCase, runTask } from 'internal-test-helpers';
 
 import { tracked } from '@glimmer/tracking';

packages/@ember/-internals/views/lib/system/utils.ts

@@ -204,7 +204,3 @@ export function getViewBoundingClientRect(view: View): DOMRect {
   let range = getViewRange(view);
   return range.getBoundingClientRect();
 }
-
-export function contains(a: Node, b: Node): boolean {
-  return a.contains(b);
-}