Skip to content

Commit 00e7e18

Browse files
Clean up comments in renderer.ts
Remove outdated comments regarding result association with root state.
1 parent b521501 commit 00e7e18

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

packages/@ember/-internals/glimmer/lib/renderer.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -232,15 +232,6 @@ class ClassicRootState {
232232

233233
let result = (this.result = iterator.sync());
234234

235-
// Associate the result with the root state (not the owner) so that
236-
// destruction cascades through:
237-
// Owner → Container → Renderer → RendererState → ClassicRootState → result
238-
// This ensures the container is still alive when component destructors
239-
// run (e.g. willDestroy looking up the renderer via injection).
240-
// Previously, associating with the owner made the result a sibling of
241-
// the Container, causing the Container to be destroyed first — which
242-
// broke FastBoot where the container was already dead by the time
243-
// component teardown tried to do lookups. (See: emberjs/ember.js#20984)
244235
associateDestroyableChild(this, result);
245236

246237
this.render = errorLoopTransaction(() => {

0 commit comments

Comments
 (0)