Merge pull request #127 from ember-tooling/fix-something

test eslint fix && with different ts eslint plugin versions

Author: NullVoxPopuli

.github/workflows/ci.yml

@@ -41,16 +41,19 @@ jobs:
       - run: pnpm --filter '*' test
 
   ts_support:
-    name: "TS: ${{ matrix.tsVersion }}"
+    name: "TS: ${{ matrix.tsVersion }}, eslint-ts-deps: ${{ matrix.eslintTsVersion }}"
     runs-on: ubuntu-latest
     needs: [tests]
     timeout-minutes: 2
     strategy:
       fail-fast: false
       matrix:
+        eslintTsVersion:
+          - ^6
+          - ^7
+          - ^8
+          - canary
         tsVersion:
-          - 5.1
-          - 5.2
           - 5.3 
           - 5.4
           - 5.5
@@ -61,11 +64,21 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: wyvox/action-setup-pnpm@v3
-      - name: 'Change TS to ${{ matrix.tsVersion }}'
-        run: |
-          tmp=$(mktemp)
-          jq '.pnpm.overrides.typescript = "${{ matrix.tsVersion }}"' package.json > "$tmp"
-          mv "$tmp" package.json
+      - name: 'TS: ${{ matrix.tsVersion }}, eslint-plugin-ts: ${{ matrix.eslintTsVersion }}'
+        run: |-
+          function sponge() {
+            local line;
+            tmp=$(mktemp)
+            while IFS= read -r line
+            do
+              echo $line >> $tmp;
+            done
+            mv "$tmp" $1
+          }
+          jq '.pnpm.overrides."@typescript-eslint/parser" = "${{ matrix.eslintTsVersion }}"' package.json | sponge package.json
+          jq '.pnpm.overrides."@typescript-eslint/scope-manager" = "${{ matrix.eslintTsVersion }}"' package.json | sponge package.json
+          jq '.pnpm.overrides."@typescript-eslint/visitor-keys" = "${{ matrix.eslintTsVersion }}"' package.json | sponge package.json
+          jq '.pnpm.overrides.typescript = "${{ matrix.tsVersion }}"' package.json | sponge package.json
       - run: pnpm install --no-frozen-lockfile
       - run: pnpm test
       - run: pnpm --filter '*' test:check

package.json

@@ -65,7 +65,7 @@
       "optional": true
     }
   },
-  "packageManager": "pnpm@10.1.0",
+  "packageManager": "pnpm@9.15.4",
   "engines": {
     "node": ">=16.0.0"
   },

test-projects/gts/.eslintrc.cjs

@@ -4,13 +4,20 @@ module.exports = {
   root: true,
   parserOptions: {
     project: true,
+    projectService: true,
     tsconfigRootDir: __dirname
   },
   rules: {
     'no-use-before-define': ['error'],
     'no-unused-vars': ['error'],
   },
   overrides: [
+    {
+      files: ['src-fixable/**/*'],
+      rules: {
+        'arrow-body-style':["error", "always"],
+      },
+    },
     {
       files: ['**/*.{js,ts}'],
       plugins: ['ember'],

test-projects/gts/package.json

@@ -2,8 +2,8 @@
   "name": "@test-project/gts",
   "private": true,
   "scripts": {
-    "test:check": "eslint . --max-warnings=0",
-    "test:fix": "eslint . --fix --max-warnings=0",
+    "test:check": "eslint src --max-warnings=0",
+    "test:fix": "eslint ./src-fixable --fix --max-warnings=0",
     "types": "tsc --noEmit"
   },
   "devDependencies": {

test-projects/gts/src-fixable/placeholder.gts

@@ -0,0 +1,3 @@
+
+const Bar = x => {return x as unknown};
+export default Bar

test-projects/gts/src-fixable/test-fix.gts

@@ -0,0 +1,2 @@
+const Bar = () => <template></template>;
+export default Bar