Nested helpers/subexp are collapsed

[tylerturdenpants]

One of the tests from https://github.com/ember-codemods/ember-angle-brackets-codemod/

Before ember-template-recast (correct)

input: 
{{some-component
  people=(array
    (hash
      name="Alex"
      age=5
      nested=(hash oldest=true amount=(format-currency 350 sign="£"))
      disabled=(eq foo "bar")
    )
    (hash name="Ben" age=4)
    (hash name="Sophie" age=1)
  )
}}

output: 
<SomeComponent
  @people={{array
    (hash
      name="Alex"
      age=5
      nested=(hash oldest=true amount=(format-currency 350 sign="£"))
      disabled=(eq foo "bar")
    )
    (hash name="Ben" age=4)
    (hash name="Sophie" age=1)
  }}
/>

After ember-template-recast refactor (incorrect)

input: 
{{some-component
  people=(array
    (hash
      name="Alex"
      age=5
      nested=(hash oldest=true amount=(format-currency 350 sign="£"))
      disabled=(eq foo "bar")
    )
    (hash name="Ben" age=4)
    (hash name="Sophie" age=1)
  )
}}


output: 
<SomeComponent @people={{array (hash name="Alex" age=5 nested=(hash oldest=true amount=(format-currency 350 sign="£")) disabled=(eq foo "bar")) (hash name="Ben" age=4) (hash name="Sophie" age=1)}}></SomeComponent>

[rwjblue]

Can you share where you are building the ElementNode? The reason I ask is that in order to preserve the formatting / whitespace you have to use the original hash value directly as an AttrNode value.

This test shows that it can work properly:

ember-template-recast/tests/smoke-test.js

Lines 415 to 433 in 0e3c597

	QUnit.test('preserves nested invocation whitespace', function(assert) {
	let template = stripIndent`
	{{foo-bar baz=(something
	goes=here
	and=here
	)}}
	`;
	let { code } = transform(template, codemod);
	assert.equal(
	code,
	stripIndent`
	<FooBar @baz={{something
	goes=here
	and=here
	}} />
	`
	);

See here how I ensure to preserve the original source as much as possible:

ember-template-recast/tests/smoke-test.js

Lines 386 to 399 in 0e3c597

	return b.element(
	{ name: tagName, selfClosing: true },
	{
	attrs: node.hash.pairs.map(pair => {
	let value = b.mustache(pair.value);
	if (pair.value.type === 'SubExpression') {
	pair.value.type = 'MustacheStatement';
	value = pair.value;
	}
	return b.attr(`@${pair.key}`, value);
	}),
	}