Skip to content

Commit 53ee52e

Browse files
author
Robert Jackson
committed
Ensure that destroyAppInstanceInMs does not throw if completed
1 parent 0893cec commit 53ee52e

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

src/ember-app.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,10 @@ class EmberApp {
187187
/**
188188
* Perform any cleanup that is needed
189189
*/
190-
destroy() {}
190+
destroy() {
191+
// TODO: expose as public api (through the top level) so that we can
192+
// cleanup pre-warmed visits
193+
}
191194

192195
/**
193196
* @private

src/result.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ class Result {
152152

153153
_destroy() {
154154
if (this.isDestroyed) {
155-
return true;
155+
return false;
156156
}
157157

158158
this.isDestroyed = true;
@@ -164,6 +164,8 @@ class Result {
164164
if (this.applicationInstance !== undefined) {
165165
this.applicationInstance.destroy();
166166
}
167+
168+
return true;
167169
}
168170

169171
_finalizeHTML() {

0 commit comments

Comments
 (0)