Skip to content

Commit 306c676

Browse files
authored
Merge pull request #104 from outdoorsy/use-ember-module-imports
Use ember module imports in doc code snippets
2 parents 3d905fd + 9e5a0bb commit 306c676

2 files changed

Lines changed: 13 additions & 11 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ To run the website locally:
1616
- `cd fastboot-website`
1717
- `npm install`
1818
- `ember serve`
19-
- Visit the app at <http://localhost:3000>.
19+
- Visit the app at <http://localhost:4200>.
2020

2121
### Running Tests
2222

markdown/docs/addon-author-guide.md

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,15 @@ our component file that's shared across all instances of the component:
9595

9696
```js
9797
// addon/components/resizable-component.js
98-
import Ember from "ember";
99-
import $ from "jquery";
98+
import Component from '@ember/component';
99+
import $ from 'jquery';
100100

101101
let componentsToNotify = [];
102102
$(window).on('resize', () => {
103103
componentsToNotify.forEach(c => c.windowDidResize());
104104
});
105105

106-
export default Ember.Component.extend({
106+
export default Component.extend({
107107
init() {
108108
componentsToNotify.push(this);
109109
},
@@ -135,8 +135,8 @@ and never in Node).
135135

136136
```js
137137
// addon/components/resizable-component.js
138-
import Ember from "ember";
139-
import $ from "jquery";
138+
import Component from '@ember/component';
139+
import $ from 'jquery';
140140

141141
let componentsToNotify = [];
142142
let didSetupListener = false;
@@ -148,7 +148,7 @@ function setupListener() {
148148
});
149149
}
150150

151-
export default Ember.Component.extend({
151+
export default Component.extend({
152152
didInsertElement() {
153153
if (!didSetupListener) { setupListener(); }
154154
componentsToNotify.push(this);
@@ -429,17 +429,19 @@ Instead, you can write a computed property that uses the low-level
429429
`getOwner` functionality to lookup the `fastboot` service directly:
430430

431431
```js
432-
import Ember from "ember";
432+
import Service from '@ember/service';
433+
import { computed } from '@ember/object';
434+
import { getOwner } from '@ember/application';
433435

434-
export default Ember.Service.extend({
436+
export default Service.extend({
435437
doSomething() {
436438
let fastboot = this.get('fastboot');
437439
if (!fastboot) { return; }
438440
// do something that requires FastBoot
439441
},
440442

441-
fastboot: Ember.computed(function() {
442-
let owner = Ember.getOwner(this);
443+
fastboot: computed(function() {
444+
let owner = getOwner(this);
443445

444446
return owner.lookup('service:fastboot');
445447
})

0 commit comments

Comments
 (0)