Fix failing tests

Author: tomdale

lib/fastboot-app-server.js

@@ -32,7 +32,9 @@ class FastBootAppServer {
 
       this.worker.start();
     } else {
-      this.workerCount = options.workerCount || os.cpus().length;
+      this.workerCount = options.workerCount ||
+        (process.env.NODE_ENV === 'test' ? 1 : null) ||
+        os.cpus().length;
 
       assert(this.distPath || this.downloader, "FastBootAppServer must be provided with either a distPath or a downloader option.");
       assert(!(this.distPath && this.downloader), "FastBootAppServer must be provided with either a distPath or a downloader option, but not both.");

package.json

@@ -4,7 +4,7 @@
   "description": "A production-ready app server for running Ember FastBoot apps",
   "main": "lib/fastboot-app-server.js",
   "scripts": {
-    "test": "mocha"
+    "test": "NODE_ENV=test mocha"
   },
   "repository": {
     "type": "git",

test/app-server-test.js

@@ -1,12 +1,22 @@
 "use strict";
 
+const path              = require('path');
+const fork              = require('child_process').fork;
 const expect            = require('chai').expect;
 const FastBootAppServer = require('../lib/fastboot-app-server');
 const request           = require('request-promise').defaults({ simple: false, resolveWithFullResponse: true });
 
+let server;
+
 describe("FastBootAppServer", function() {
   this.timeout(3000);
 
+  afterEach(function() {
+    if (server) {
+      server.kill();
+    }
+  });
+
   it("throws if no distPath or downloader is provided", function() {
     expect(() => {
       new FastBootAppServer();
@@ -23,16 +33,7 @@ describe("FastBootAppServer", function() {
   });
 
   it("serves an HTTP 500 response if the app can't be found", function() {
-    let server = new FastBootAppServer({
-      workerCount: 1,
-      downloader: {
-        download() {
-          return Promise.resolve();
-        }
-      }
-    });
-
-    return server.start()
+    return runServer('not-found-server')
       .then(() => request('http://localhost:3000'))
       .then(response => {
         expect(response.statusCode).to.equal(500);
@@ -41,3 +42,24 @@ describe("FastBootAppServer", function() {
   });
 
 });
+
+function runServer(name) {
+  return new Promise((res, rej) => {
+    let serverPath = path.join(__dirname, 'fixtures', `${name}.js`);
+    server = fork(serverPath, {
+      silent: true
+    });
+
+    server.on('error', rej);
+
+    server.stdout.on('data', data => {
+      if (data.toString().match(/HTTP server started/)) {
+        res();
+      }
+    });
+
+    server.stderr.on('data', data => {
+      console.log(data.toString());
+    });
+  });
+}

test/fixtures/not-found-server.js

@@ -0,0 +1,13 @@
+'use strict';
+
+const FastBootAppServer = require('../../lib/fastboot-app-server.js');
+
+let server = new FastBootAppServer({
+  downloader: {
+    download() {
+      return Promise.resolve();
+    }
+  }
+});
+
+server.start();