Skip to content

Commit f753e74

Browse files
authored
Merge pull request #94 from cibernox/update-to-glimmer
2 parents 7dbb122 + 47553c5 commit f753e74

45 files changed

Lines changed: 49368 additions & 12551 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
# misc
1515
/coverage/
1616
!.*
17+
.eslintcache
1718

1819
# ember-try
1920
/.node_modules.ember-try/

.eslintrc.js

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,53 +7,48 @@ module.exports = {
77
ecmaVersion: 2018,
88
sourceType: 'module',
99
ecmaFeatures: {
10-
legacyDecorators: true
11-
}
10+
legacyDecorators: true,
11+
},
1212
},
13-
plugins: [
14-
'ember'
15-
],
13+
plugins: ['ember'],
1614
extends: [
1715
'eslint:recommended',
18-
'plugin:ember/recommended'
16+
'plugin:ember/recommended',
17+
'plugin:prettier/recommended',
1918
],
2019
env: {
21-
browser: true
22-
},
23-
rules: {
24-
'ember/no-jquery': 'error',
25-
'ember/no-get': 'off',
20+
browser: true,
2621
},
22+
rules: {},
2723
overrides: [
2824
// node files
2925
{
3026
files: [
3127
'.eslintrc.js',
28+
'.prettierrc.js',
3229
'.template-lintrc.js',
3330
'ember-cli-build.js',
3431
'index.js',
3532
'testem.js',
3633
'blueprints/*/index.js',
3734
'config/**/*.js',
38-
'tests/dummy/config/**/*.js'
35+
'tests/dummy/config/**/*.js',
3936
],
4037
excludedFiles: [
4138
'addon/**',
4239
'addon-test-support/**',
4340
'app/**',
44-
'tests/dummy/app/**'
41+
'tests/dummy/app/**',
4542
],
4643
parserOptions: {
47-
sourceType: 'script'
44+
sourceType: 'script',
4845
},
4946
env: {
5047
browser: false,
51-
node: true
48+
node: true,
5249
},
5350
plugins: ['node'],
54-
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
55-
// add your custom rules and overrides for node files here
56-
})
57-
}
58-
]
51+
extends: ['plugin:node/recommended'],
52+
},
53+
],
5954
};

.github/workflows/build.yml

Lines changed: 17 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -19,41 +19,33 @@ jobs:
1919
fail-fast: false
2020
matrix:
2121
scenario:
22-
- default
2322
- default-with-lockfile
24-
- default-with-jquery
25-
- release
26-
- beta
27-
- canary
28-
- lts-3.16
29-
- lts-3.12
30-
- lts-3.8
31-
- lts-3.4
32-
- lts-2.18
33-
- embroider
23+
- ember-default-with-jquery
24+
- ember-release
25+
- ember-beta
26+
- ember-canary
27+
- ember-lts-3.16
28+
- ember-lts-3.20
29+
- embroider-safe
30+
- embroider-optimized
31+
3432
steps:
3533
- name: Checkout
3634
uses: actions/checkout@v1
3735
- name: Set up Volta
3836
uses: volta-cli/action@v1
39-
- name: Install dependencies (yarn)
40-
if: matrix.scenario == 'default-with-lockfile'
41-
run: yarn install --non-interactive --frozen-lockfile
42-
- name: Install dependencies (yarn)
43-
if: matrix.scenario != 'default-with-lockfile'
44-
run: yarn install --non-interactive --no-lockfile
37+
- name: Install dependencies
38+
run: npm ci
4539
- name: Setup ember-try scenario
46-
if: matrix.scenario != 'default' && matrix.scenario != 'default-with-lockfile'
40+
if: matrix.scenario != 'default-with-lockfile'
4741
run: >-
48-
yarn ember try:one ember-${{ matrix.scenario }} --skip-cleanup ---
42+
npx ember try:one ${{ matrix.scenario }} --skip-cleanup ---
4943
'[ -z "$EMBER_OPTIONAL_FEATURES" ] || echo "EMBER_OPTIONAL_FEATURES=$EMBER_OPTIONAL_FEATURES" >> $GITHUB_ENV'
50-
- name: Lint (hbs)
51-
run: yarn lint:hbs
52-
- name: Lint (js)
53-
run: yarn lint:js
44+
- name: Lint
45+
run: npm run lint
5446
- name: Build
55-
run: yarn ember build --environment test
47+
run: npx ember build --environment test
5648
- name: Run test
5749
# Due to a bug in ember-cli, running `ember test` with `--path` doesn't set `EMBER_ENV=test`
5850
# See https://github.com/ember-cli/ember-cli/issues/8922
59-
run: EMBER_ENV=test yarn test --path dist
51+
run: EMBER_ENV=test npm run test:ember -- --path dist

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
/.env*
1313
/.pnp*
1414
/.sass-cache
15+
/.eslintcache
1516
/connect.lock
1617
/coverage/
1718
/libpeerconnection.log

.npmignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,13 @@
1010
/.editorconfig
1111
/.ember-cli
1212
/.env*
13+
/.eslintcache
1314
/.eslintignore
1415
/.eslintrc.js
1516
/.git/
1617
/.gitignore
18+
/.prettierignore
19+
/.prettierrc.js
1720
/.template-lintrc.js
1821
/.travis.yml
1922
/.watchmanconfig

.prettierignore

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
/tmp/
8+
9+
# dependencies
10+
/bower_components/
11+
/node_modules/
12+
13+
# misc
14+
/coverage/
15+
!.*
16+
.eslintcache
17+
18+
# ember-try
19+
/.node_modules.ember-try/
20+
/bower.json.ember-try
21+
/package.json.ember-try

.prettierrc.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
singleQuote: true,
5+
};

.template-lintrc.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
'use strict';
22

33
module.exports = {
4-
extends: 'recommended',
5-
rules: {
6-
'no-html-comments': false
7-
}
4+
extends: 'octane',
85
};

CONTRIBUTING.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,12 @@
44

55
* `git clone <repository-url>`
66
* `cd ember-cli-head`
7-
* `yarn install`
7+
* `npm ci`
88

99
## Linting
1010

11-
* `yarn lint:hbs`
12-
* `yarn lint:js`
13-
* `yarn lint:js --fix`
11+
* `npm run lint`
12+
* `npm run lint:fix`
1413

1514
## Running tests
1615

README.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,9 @@ This addon lets you populate `<head>` tag from your Ember code without any direc
66

77
The hope is that, in the future, Ember will provide a mechanism for populating `<head>` tag from your app. Until then, this addon provides that functionality.
88

9-
10-
## Compatibility
11-
12-
* Ember.js v2.18 or above
9+
* Ember.js v3.16 or above
1310
* Ember CLI v2.13 or above
14-
* Node.js v10 or above
11+
* Node.js v12 or above
1512

1613

1714
## Installation

0 commit comments

Comments
 (0)