Fix linting issues

Robert Jackson · Robert Jackson · commit 32fb0ee9ab78 · 2021-05-24T15:51:10.000-04:00
diff --git a/addon/components/head-layout.hbs b/addon/components/head-layout.hbs
@@ -1,3 +1,4 @@
 {{#in-element this.headElement insertBefore=null}}
+  {{! template-lint-disable no-forbidden-elements }}
   <meta name="ember-cli-head-start" content=""><HeadContent/><meta name="ember-cli-head-end" content="">
 {{/in-element}}
diff --git a/addon/components/head-layout.js b/addon/components/head-layout.js
@@ -2,21 +2,21 @@ import Component from '@glimmer/component';
 import { inject as service } from '@ember/service';
 
 export default class HeadLayout extends Component {
-  @service('-document') document
+  @service('-document') document;
 
   /**
    * If true, this will tear down any existing head on init of this component.
    * This is useful if there is a head built with fastboot - it will then be torn down when this is initialized in the browser.
    * If you do not want this behavior, you can set this to false.
    * @public
    */
-  shouldTearDownOnInit = true
+  shouldTearDownOnInit = true;
 
   /**
    * The element to render into. Defaults to <head> in `init`, overridable for our own tests only.
    * @private
    */
-  headElement = this.args.headElement || this.document.head
+  headElement = this.args.headElement || this.document.head;
 
   constructor() {
     super(...arguments);
@@ -51,7 +51,6 @@ export default class HeadLayout extends Component {
   }
 
   _isFastboot() {
-    return typeof FastBoot !== 'undefined'
+    return typeof FastBoot !== 'undefined';
   }
-
 }
diff --git a/addon/services/head-data.js b/addon/services/head-data.js
@@ -1,4 +1,3 @@
 import Service from '@ember/service';
 
-export default class HeadData extends Service {
-}
+export default class HeadData extends Service {}
diff --git a/app/components/head-content.js b/app/components/head-content.js
@@ -5,5 +5,5 @@ import layout from '../templates/head';
 export default Component.extend({
   tagName: '',
   model: inject('head-data'),
-  layout
+  layout,
 });
diff --git a/app/components/head-layout.js b/app/components/head-layout.js
@@ -1 +1 @@
-export { default } from 'ember-cli-head/components/head-layout';
+export { default } from 'ember-cli-head/components/head-layout';
diff --git a/app/instance-initializers/head-browser.js b/app/instance-initializers/head-browser.js
@@ -4,5 +4,5 @@ export default {
     // do nothing!
     // this functionality has been moved into addon/components/head-layout.js
     // This is only here in order to not break existing addons relying on this, e.g. ember-page-title.
-  }
+  },
 };
diff --git a/app/templates/head.hbs b/app/templates/head.hbs
@@ -1,2 +1,3 @@
+{{! template-lint-disable no-html-comments }}
 <!-- ember-cli-head/templates/head.hbs -->
 <!-- If you see this your application's `head.hbs` has gone missing. -->
diff --git a/fastboot-tests/fixtures/fastboot/app/templates/head.hbs b/fastboot-tests/fixtures/fastboot/app/templates/head.hbs
@@ -1,3 +1,4 @@
+{{! template-lint-disable no-forbidden-elements no-html-comments }}
 <!-- Add content you wish automatically added to the documents head-->
 <!-- here. The 'model' available in this template can be populated by-->
 <!-- setting values on the 'head-data' service. -->
diff --git a/tests/.eslintrc.js b/tests/.eslintrc.js
@@ -1,5 +1,5 @@
 module.exports = {
   env: {
-    embertest: true
-  }
+    embertest: true,
+  },
 };
diff --git a/tests/acceptance/head-component-test.js b/tests/acceptance/head-component-test.js
@@ -2,18 +2,22 @@ import { module, test } from 'qunit';
 import { visit } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 
-module('Acceptance | head component', function(hooks) {
+module('Acceptance | head component', function (hooks) {
   setupApplicationTest(hooks);
 
-  test('has head-data service content', async function(assert) {
+  test('has head-data service content', async function (assert) {
     await visit('/');
 
     assert.dom('h1').hasText('Hello page');
-    assert.dom('head meta[property="og:title"]', document).hasAttribute('content', 'Hello page');
+    assert
+      .dom('head meta[property="og:title"]', document)
+      .hasAttribute('content', 'Hello page');
 
     await visit('/other-page');
 
     assert.dom('h1').hasText('Other page');
-    assert.dom('head meta[property="og:title"]', document).hasAttribute('content', 'Other page');
+    assert
+      .dom('head meta[property="og:title"]', document)
+      .hasAttribute('content', 'Other page');
   });
 });
diff --git a/tests/dummy/app/app.js b/tests/dummy/app/app.js
@@ -6,7 +6,7 @@ import config from 'dummy/config/environment';
 const App = Application.extend({
   modulePrefix: config.modulePrefix,
   podModulePrefix: config.podModulePrefix,
-  Resolver
+  Resolver,
 });
 
 loadInitializers(App, config.modulePrefix);
diff --git a/tests/dummy/app/router.js b/tests/dummy/app/router.js
@@ -3,7 +3,7 @@ import config from 'dummy/config/environment';
 
 const Router = EmberRouter.extend({
   location: config.locationType,
-  rootURL: config.rootURL
+  rootURL: config.rootURL,
 });
 
 export default Router.map(function () {
diff --git a/tests/dummy/app/routes/application.js b/tests/dummy/app/routes/application.js
@@ -5,6 +5,6 @@ import { set } from '@ember/object';
 export default Route.extend({
   headData: service(),
   afterModel() {
-    set(this, 'headData.title', "Hello page");
-  }
+    set(this, 'headData.title', 'Hello page');
+  },
 });
diff --git a/tests/dummy/app/routes/other-page.js b/tests/dummy/app/routes/other-page.js
@@ -5,6 +5,6 @@ import { set } from '@ember/object';
 export default Route.extend({
   headData: service(),
   afterModel() {
-    set(this, 'headData.title', "Other page");
-  }
+    set(this, 'headData.title', 'Other page');
+  },
 });
diff --git a/tests/dummy/app/templates/head.hbs b/tests/dummy/app/templates/head.hbs
@@ -1,3 +1,4 @@
+{{! template-lint-disable no-forbidden-elements no-html-comments }}
 <!-- Add content you wish automatically added to the documents head-->
 <!-- here. The 'model' available in this template can be populated by-->
 <!-- setting values on the 'head-data' service. -->
diff --git a/tests/dummy/config/environment.js b/tests/dummy/config/environment.js
@@ -13,7 +13,7 @@ module.exports = function (environment) {
       },
       EXTEND_PROTOTYPES: {
         // Prevent Ember Data from overriding Date.parse.
-        Date: false
+        Date: false,
       },
     },
 
diff --git a/tests/fastboot/head-component-test.js b/tests/fastboot/head-component-test.js
@@ -1,18 +1,25 @@
 import { module, test } from 'qunit';
-import { setup, visit, /* mockServer */ } from 'ember-cli-fastboot-testing/test-support';
+import {
+  setup,
+  visit /* mockServer */,
+} from 'ember-cli-fastboot-testing/test-support';
 
-module('FastBoot | head component', function(hooks) {
+module('FastBoot | head component', function (hooks) {
   setup(hooks);
 
-  test('has head-data service content', async function(assert) {
+  test('has head-data service content', async function (assert) {
     let res = await visit('/');
 
     assert.dom('h1').hasText('Hello page');
-    assert.dom('head meta[property="og:title"]', res.htmlDocument).hasAttribute('content', 'Hello page');
+    assert
+      .dom('head meta[property="og:title"]', res.htmlDocument)
+      .hasAttribute('content', 'Hello page');
 
     res = await visit('/other-page');
 
     assert.dom('h1').hasText('Other page');
-    assert.dom('head meta[property="og:title"]', res.htmlDocument).hasAttribute('content', 'Other page');
+    assert
+      .dom('head meta[property="og:title"]', res.htmlDocument)
+      .hasAttribute('content', 'Other page');
   });
 });
diff --git a/tests/helpers/resolver.js b/tests/helpers/resolver.js
@@ -5,7 +5,7 @@ const resolver = Resolver.create();
 
 resolver.namespace = {
   modulePrefix: config.modulePrefix,
-  podModulePrefix: config.podModulePrefix
+  podModulePrefix: config.podModulePrefix,
 };
 
 export default resolver;
diff --git a/tests/integration/components/head-layout-test.js b/tests/integration/components/head-layout-test.js
@@ -3,16 +3,20 @@ import { setupRenderingTest } from 'ember-qunit';
 import { render } from '@ember/test-helpers';
 import { hbs } from 'ember-cli-htmlbars';
 
-module('Integration | Component | head-layout', function(hooks) {
+module('Integration | Component | head-layout', function (hooks) {
   setupRenderingTest(hooks);
 
-  test('it renders', async function(assert) {
+  test('it renders', async function (assert) {
     let fragment = document.createDocumentFragment();
     this.stuff = fragment;
 
     await render(hbs`<HeadLayout @headElement={{this.stuff}}/>`);
 
-    assert.dom('meta[name="ember-cli-head-start"]', fragment).exists({ count: 1 });
-    assert.dom('meta[name="ember-cli-head-end"]', fragment).exists({ count: 1 });
+    assert
+      .dom('meta[name="ember-cli-head-start"]', fragment)
+      .exists({ count: 1 });
+    assert
+      .dom('meta[name="ember-cli-head-end"]', fragment)
+      .exists({ count: 1 });
   });
 });
diff --git a/tests/unit/services/head-data-test.js b/tests/unit/services/head-data-test.js
@@ -1,11 +1,11 @@
 import { module, test } from 'qunit';
 import { setupTest } from 'ember-qunit';
 
-module('Unit | Service | head data', function(hooks) {
+module('Unit | Service | head data', function (hooks) {
   setupTest(hooks);
 
   // TODO: Replace this with your real tests.
-  test('it exists', function(assert) {
+  test('it exists', function (assert) {
     // just test that it's available
     let service = this.owner.lookup('service:head-data');
     assert.ok(service);

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-export { default } from 'ember-cli-head/components/head-layout';`
	`1`	`+export { default } from 'ember-cli-head/components/head-layout';`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
	`1`	`+{{! template-lint-disable no-html-comments }}`
`1`	`2`	`<!-- ember-cli-head/templates/head.hbs -->`
`2`	`3`	<!-- If you see this your application's `head.hbs` has gone missing. -->
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+{{! template-lint-disable no-forbidden-elements no-html-comments }}`
`1`	`2`	`<!-- Add content you wish automatically added to the documents head-->`
`2`	`3`	`<!-- here. The 'model' available in this template can be populated by-->`
`3`	`4`	`<!-- setting values on the 'head-data' service. -->`