Skip to content

Commit c0eca89

Browse files
authored
Merge pull request #241 from ember-fastboot/revert-238-postbuild-to-outputready
Revert "Use outputReady instead of postBuild"
2 parents d2d49ee + b766648 commit c0eca89

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ module.exports = {
123123
return fastbootBuild.toTree();
124124
},
125125

126-
outputReady: function() {
127-
this.emit('outputReady');
128-
}
126+
postBuild: function() {
127+
this.emit('postBuild');
128+
},
129129

130130
};

lib/commands/fastboot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module.exports = function(addon) {
3434
const blockForever = this.blockForever;
3535

3636
return this.checkPort(options)
37-
.then(runServer) // starts on outputReady event
37+
.then(runServer) // starts on postBuild SIGHUP
3838
.then(options.build ? runBuild : noop)
3939
.then(blockForever);
4040
},

lib/tasks/fastboot-server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ module.exports = CoreObject.extend({
2121
run(options) {
2222
debug('run');
2323
const restart = () => this.restart(options);
24-
this.addon.on('outputReady', restart);
24+
this.addon.on('postBuild', restart);
2525
},
2626

2727
start(options) {

test/lib-tasks-fastboot-server-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@ describe('fastboot server task', function() {
5454
});
5555

5656
describe('run', function() {
57-
it('calls restart on outputReady', function() {
57+
it('calls restart on postBuild', function() {
5858
const restartStub = this.sinon.stub(task, 'restart');
5959
task.run(options);
60-
addon.emit('outputReady');
60+
addon.emit('postBuild');
6161
expect(restartStub.called).to.be.ok;
6262
});
6363
});

0 commit comments

Comments
 (0)