Skip to content

Commit 4d729b6

Browse files
committed
Fix linking errors
1 parent fb410e1 commit 4d729b6

14 files changed

Lines changed: 730 additions & 315 deletions

File tree

.eslintrc.js

Lines changed: 46 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,54 @@ module.exports = {
44
ecmaVersion: 2017,
55
sourceType: 'module'
66
},
7-
extends: 'eslint:recommended',
7+
plugins: [
8+
'ember'
9+
],
10+
extends: [
11+
'eslint:recommended',
12+
'plugin:ember/recommended'
13+
],
814
env: {
915
browser: true
1016
},
1117
rules: {
12-
}
18+
},
19+
overrides: [
20+
// node files
21+
{
22+
files: [
23+
'index.js',
24+
'testem.js',
25+
'ember-cli-build.js',
26+
'config/**/*.js',
27+
'tests/dummy/config/**/*.js',
28+
'lib/**/*.js'
29+
],
30+
excludedFiles: [
31+
'app/**',
32+
'addon/**'
33+
],
34+
parserOptions: {
35+
sourceType: 'script',
36+
ecmaVersion: 2015
37+
},
38+
env: {
39+
browser: false,
40+
node: true
41+
},
42+
plugins: ['node'],
43+
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
44+
// add your custom rules and overrides for node files here
45+
})
46+
},
47+
48+
// test files
49+
{
50+
files: ['tests/**/*.js'],
51+
excludedFiles: ['tests/dummy/**/*.js'],
52+
env: {
53+
embertest: true
54+
}
55+
}
56+
]
1357
};

.npmignore

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
/bower_components
2+
/config/ember-try.js
23
/dist
34
/test
45
/tests
@@ -7,10 +8,15 @@
78
.bowerrc
89
.editorconfig
910
.ember-cli
10-
.gitignore
1111
.eslintrc.js
12+
.gitignore
1213
.watchmanconfig
1314
.travis.yml
1415
bower.json
1516
ember-cli-build.js
1617
testem.js
18+
19+
# ember-try
20+
.node_modules.ember-try/
21+
bower.json.ember-try
22+
package.json.ember-try

app/locations/none.js

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
1-
import Ember from 'ember';
2-
3-
const {
4-
computed,
5-
computed: { bool, readOnly },
6-
inject: { service },
7-
get,
8-
getOwner
9-
} = Ember;
1+
import { computed, get } from '@ember/object';
2+
import { bool, readOnly } from '@ember/object/computed';
3+
import { inject as service } from '@ember/service';
4+
import { getOwner } from '@ember/application'
5+
import NoneLocation from '@ember/routing/none-location'
106

117
const TEMPORARY_REDIRECT_CODE = 307;
128

13-
export default Ember.NoneLocation.extend({
9+
export default NoneLocation.extend({
1410
implementation: 'fastboot',
1511
fastboot: service(),
1612

app/services/fastboot.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
/* global FastBoot */
2-
import Ember from "ember";
3-
4-
const { deprecate, computed, get, assert } = Ember;
5-
const { deprecatingAlias, readOnly } = computed;
6-
7-
const RequestObject = Ember.Object.extend({
2+
import { deprecate } from '@ember/application/deprecations';
3+
import { computed, get } from '@ember/object';
4+
import { deprecatingAlias, readOnly } from '@ember/object/computed';
5+
import { assert } from '@ember/debug';
6+
import EObject from '@ember/object';
7+
import Service from '@ember/service';
8+
9+
const RequestObject = EObject.extend({
810
init() {
911
this._super(...arguments);
1012

@@ -28,7 +30,7 @@ const RequestObject = Ember.Object.extend({
2830
})
2931
});
3032

31-
const Shoebox = Ember.Object.extend({
33+
const Shoebox = EObject.extend({
3234
put(key, value) {
3335
assert('shoebox.put is only invoked from the FastBoot rendered application', this.get('fastboot.isFastBoot'));
3436
assert('the provided key is a string', typeof key === 'string');
@@ -62,7 +64,7 @@ const Shoebox = Ember.Object.extend({
6264
}
6365
});
6466

65-
const FastBootService = Ember.Service.extend({
67+
const FastBootService = Service.extend({
6668
cookies: deprecatingAlias('request.cookies', { id: 'fastboot.cookies-to-request', until: '0.9.9' }),
6769
headers: deprecatingAlias('request.headers', { id: 'fastboot.headers-to-request', until: '0.9.9' }),
6870
isFastBoot: typeof FastBoot !== 'undefined',

config/environment.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-env node */
21
'use strict';
32

43
module.exports = function(/* environment, appConfig */) {

ember-cli-build.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-env node */
21
'use strict';
32

43
const EmberAddon = require('ember-cli/lib/broccoli/ember-addon');

lib/broccoli/fastboot-config.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,10 @@ module.exports = class FastBootConfig extends Plugin {
143143

144144
this.dependencies = dependencies;
145145
this.moduleWhitelist = uniq(moduleWhitelist);
146-
};
146+
}
147147

148148
readAssetManifest() {
149149
let assetMapPath = path.join(this.inputPaths[0], this.assetMapPath);
150-
const assetMapEnabled = this.assetMapEnabled;
151150

152151
try {
153152
let assetMap = JSON.parse(fs.readFileSync(assetMapPath));
@@ -206,10 +205,10 @@ module.exports = class FastBootConfig extends Plugin {
206205
}
207206

208207
buildHostWhitelist() {
209-
if (!!this.fastbootAppConfig) {
208+
if (this.fastbootAppConfig) {
210209
this.hostWhitelist = this.fastbootAppConfig.hostWhitelist;
211210
}
212-
};
211+
}
213212

214213
toJSONString() {
215214
return stringify({

package.json

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
"repository": "https://github.com/ember-fastboot/ember-cli-fastboot",
1515
"scripts": {
1616
"build": "ember build",
17-
"start": "ember server",
17+
"lint:js": "eslint ./*.js addon addon-test-support app config lib server test-support tests",
18+
"start": "ember serve",
1819
"test": "mocha && ember test",
1920
"test:precook": "node node_modules/ember-cli-addon-tests/scripts/precook-node-modules.js"
2021
},
@@ -26,7 +27,8 @@
2627
"chalk": "^2.0.1",
2728
"ember-cli-babel": "^6.7.2",
2829
"ember-cli-lodash-subset": "2.0.1",
29-
"ember-cli-version-checker": "^2.0.0",
30+
"ember-cli-version-checker": "^2.1.0",
31+
"ember-cli-preprocess-registry": "^3.1.0",
3032
"fastboot": "^1.1.0",
3133
"fastboot-express-middleware": "^1.1.0",
3234
"fastboot-transform": "^0.1.2",
@@ -43,23 +45,25 @@
4345
"chai-fs": "^2.0.0",
4446
"co": "^4.6.0",
4547
"ember-ajax": "^3.0.0",
46-
"ember-cli": "~2.16.2",
48+
"ember-cli": "~2.18.0",
4749
"ember-cli-addon-tests": "^0.11.0",
4850
"ember-cli-dependency-checker": "^2.0.1",
49-
"ember-cli-eslint": "^4.1.0",
51+
"ember-cli-eslint": "^4.2.1",
5052
"ember-cli-htmlbars": "^2.0.2",
5153
"ember-cli-htmlbars-inline-precompile": "^1.0.2",
5254
"ember-cli-inject-live-reload": "^1.4.1",
53-
"ember-cli-qunit": "^4.0.0",
54-
"ember-cli-shims": "^1.1.0",
55+
"ember-cli-qunit": "^4.2.1",
56+
"ember-cli-shims": "^1.2.0",
5557
"ember-cli-sri": "^2.1.0",
5658
"ember-cli-uglify": "^2.0.0",
5759
"ember-disable-prototype-extensions": "^1.1.2",
5860
"ember-export-application-global": "^2.0.0",
5961
"ember-load-initializers": "^1.0.0",
6062
"ember-resolver": "^4.3.0",
6163
"ember-sinon": "^1.0.0",
62-
"ember-source": "~2.16.0",
64+
"ember-source": "~2.18.0",
65+
"eslint-plugin-ember": "^5.0.0",
66+
"eslint-plugin-node": "^5.2.1",
6367
"glob": "^7.0.0",
6468
"loader.js": "^4.2.3",
6569
"mocha": "^4.0.0",

testem.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-env node */
21
module.exports = {
32
test_page: 'tests/index.html?hidepassed',
43
disable_watching: true,
@@ -12,10 +11,11 @@ module.exports = {
1211
Chrome: {
1312
mode: 'ci',
1413
args: [
15-
'--disable-gpu',
16-
'--headless',
17-
'--remote-debugging-port=9222',
18-
'--window-size=1440,900'
14+
'--disable-gpu',
15+
'--headless',
16+
'--no-sandbox',
17+
'--remote-debugging-port=0',
18+
'--window-size=1440,900'
1919
]
2020
}
2121
}

tests/dummy/config/environment.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-env node */
21
'use strict';
32

43
module.exports = function(environment) {
@@ -41,10 +40,11 @@ module.exports = function(environment) {
4140
ENV.APP.LOG_VIEW_LOOKUPS = false;
4241

4342
ENV.APP.rootElement = '#ember-testing';
43+
ENV.APP.autoboot = false;
4444
}
4545

4646
if (environment === 'production') {
47-
47+
// here you can enable a production-specific feature
4848
}
4949

5050
return ENV;

0 commit comments

Comments
 (0)