Merge pull request #775 from kiwiupover/adding-basic-test-app

Author: Robert Jackson

.github/workflows/ci.yml

@@ -19,29 +19,38 @@ on:
   - cron:  '0 6 * * 0'
 
 jobs:
-  test-mocha:
-    name: Mocha Tests - ${{ matrix.node-version }}
+  test-legacy-mocha:
+    name: Legacy Mocha Tests - ${{ matrix.node-version }}
     runs-on: ubuntu-latest
 
     strategy:
+      fail-fast: false
       matrix:
-        node-version: [12.x, 10.x]
+        node-version: ['10', '12']
 
     steps:
       - name: Checkout Code
         uses: actions/checkout@v2
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: volta-cli/action@v1
         with:
           node-version: ${{ matrix.node-version }}
-      - name: Install NPM version 4
+
+      # Remove test-packages folder so that we don't leak node_modules between apps
+      - name: Remove test-packages
         run: |
-          npm config set spin false
-          npm install -g npm@4
+          rm -rf test-packages
       - name: Yarn Install
-        run: yarn install --ignore-engines
+        working-directory: ./packages/ember-cli-fastboot
+        run: |
+          yarn install --ignore-engines --frozen-lockfile
       - name: Run Mocha Tests
-        run: yarn workspace ember-cli-fastboot test:mocha
+        working-directory: ./packages/ember-cli-fastboot
+        run: |
+          volta install npm@4
+          npm --version
+          yarn test:mocha
+
 
   test-ember:
     name: Ember Tests
@@ -60,7 +69,28 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
       - name: Yarn Install
-        run: yarn install --ignore-engines
+        run: yarn install --ignore-engines --frozen-lockfile
       - name: Run Tests
         run: yarn workspace ember-cli-fastboot test:ember
 
+
+  test-packages:
+    name: Test Packages
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        node-version: [12.x, 10.x]
+        os: [ubuntu-latest, windows-latest]
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Yarn Install
+        run: yarn install --ignore-engines --frozen-lockfile
+      - name: Basic App
+        run: yarn workspace basic-app test:mocha

README.md

@@ -1,7 +1,7 @@
 # Ember FastBoot
 
 [![npm version](https://badge.fury.io/js/ember-cli-fastboot.svg)](https://badge.fury.io/js/ember-cli-fastboot)
-[![Actions Status](hhttps://github.com/ember-fastboot/ember-cli-fastboot/workflows/CI/badge.svg)](https://github.com/ember-fastboot/ember-cli-fastboot/actions)
+[![Actions Status](https://github.com/ember-fastboot/ember-cli-fastboot/workflows/CI/badge.svg)](https://github.com/ember-fastboot/ember-cli-fastboot/actions)
 
 An Ember CLI addon that allows you to render and serve Ember.js apps on
 the server. Using FastBoot, you can serve rendered HTML to browsers and

package.json

@@ -2,6 +2,7 @@
 {
   "private": true,
   "workspaces": [
-    "packages/ember-cli-fastboot"
+    "packages/ember-cli-fastboot",
+    "test-packages/basic-app"
   ]
 }

packages/ember-cli-fastboot/test/build-test.js

@@ -0,0 +1,3 @@
+### Test Packages App
+
+- [Basic App](./test-packages/basic-app) This basic ember app that is fastbooted using ember-cli-fastboot. Most test will be against this basic-app. When an app needs custom ember-cli-fastboot setup another ember app should be added to the test-packages folder.

test-packages/README.md

@@ -0,0 +1,19 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+[*]
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+indent_style = space
+indent_size = 2
+
+[*.hbs]
+insert_final_newline = false
+
+[*.{diff,md}]
+trim_trailing_whitespace = false

test-packages/basic-app/.editorconfig

@@ -0,0 +1,9 @@
+{
+  /**
+    Ember CLI sends analytics information by default. The data is completely
+    anonymous, but there are times when you might want to disable this behavior.
+
+    Setting `disableAnalytics` to true will prevent any data from being sent.
+  */
+  "disableAnalytics": false
+}

test-packages/basic-app/.ember-cli

@@ -0,0 +1,20 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/coverage/
+!.*
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try

test-packages/basic-app/.eslintignore

@@ -0,0 +1,53 @@
+'use strict';
+
+module.exports = {
+  root: true,
+  parser: 'babel-eslint',
+  parserOptions: {
+    ecmaVersion: 2018,
+    sourceType: 'module',
+    ecmaFeatures: {
+      legacyDecorators: true
+    }
+  },
+  plugins: [
+    'ember'
+  ],
+  extends: [
+    'eslint:recommended',
+    'plugin:ember/recommended'
+  ],
+  env: {
+    browser: true
+  },
+  rules: {},
+  overrides: [
+    // node files
+    {
+      files: [
+        '.eslintrc.js',
+        '.template-lintrc.js',
+        'ember-cli-build.js',
+        'testem.js',
+        'blueprints/*/index.js',
+        'config/**/*.js',
+        'lib/*/index.js',
+        'server/**/*.js'
+      ],
+      parserOptions: {
+        sourceType: 'script'
+      },
+      env: {
+        browser: false,
+        node: true
+      },
+      plugins: ['node'],
+      extends: ['plugin:node/recommended'],
+      rules: {
+        // this can be removed once the following is fixed
+        // https://github.com/mysticatea/eslint-plugin-node/issues/77
+        'node/no-unpublished-require': 'off'
+      }
+    }
+  ]
+};

test-packages/basic-app/.eslintrc.js

@@ -0,0 +1,25 @@
+# See https://help.github.com/ignore-files/ for more about ignoring files.
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/.env*
+/.pnp*
+/.sass-cache
+/connect.lock
+/coverage/
+/libpeerconnection.log
+/npm-debug.log*
+/testem.log
+/yarn-error.log
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try