Skip to content

Commit 18f0157

Browse files
authored
Merge pull request #378 from kratiahuja/fix-version-checker
Fix beta checks correctly by using `gt` API
2 parents 42dee47 + 3cbfa71 commit 18f0157

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ module.exports = {
147147
var app = options.app;
148148
var options = options.options;
149149

150-
if (emberCliVersion.satisfies('>= 2.12.0-beta.1')) {
150+
if (emberCliVersion.gt('2.12.0-beta.0')) {
151151
// only run the middleware when ember-cli version for app is above 2.12.0-beta.1 since
152152
// that version contains API to hook fastboot into ember-cli
153153

lib/commands/fastboot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ module.exports = function(addon) {
8181
var checker = new VersionChecker(this);
8282
var dep = checker.for('ember-cli', 'npm');
8383

84-
if (dep.satisfies('>= 2.12.0-beta.1')) {
84+
if (dep.gt('2.12.0-beta.0')) {
8585
this.ui.writeDeprecateLine('`ember fastboot --serve-assets` is deprecated. Please use `ember serve` to serve your fastboot assets.');
8686
} else {
8787
this.ui.writeWarnLine('`ember fastboot` will no longer work after FastBoot 1.0 is released.');

0 commit comments

Comments
 (0)