Extract findStringArrayProperties() function

Author: Turbo87

lib/__tests__/find-properties.js

@@ -128,6 +128,7 @@ describe('findClassNameBindings()', () => {
     ['classNameBindings: 5', /Unexpected `classNameBindings` value: 5/],
     ['classNameBindings: foo', /Unexpected `classNameBindings` value: foo/],
     ['classNameBindings: [42]', /Unexpected `classNameBindings` value: \[42]/],
+    ["classNameBindings: ['a:b:c:d']", /Unexpected `classNameBindings` value: a:b:c:d/],
   ];
 
   for (let [input, expected] of TESTS) {

lib/transform.js

@@ -161,79 +161,44 @@ function findElementId(properties) {
   return findStringProperty(properties, 'elementId');
 }
 
-function findAttributeBindings(properties) {
-  let attrBindingsProperty = properties.filter(path => isProperty(path, 'attributeBindings'))[0];
-  if (!attrBindingsProperty) {
-    return new Map();
+function findStringArrayProperties(properties, name) {
+  let propertyPath = properties.filter(path => isProperty(path, name))[0];
+  if (!propertyPath) {
+    return [];
   }
 
-  let arrayPath = attrBindingsProperty.get('value');
+  let arrayPath = propertyPath.get('value');
   if (arrayPath.value.type !== 'ArrayExpression') {
-    throw new SilentError(`Unexpected \`attributeBindings\` value: ${j(arrayPath).toSource()}`);
+    throw new SilentError(`Unexpected \`${name}\` value: ${j(arrayPath).toSource()}`);
   }
 
-  let elements = arrayPath.get('elements').value;
-
-  let attrBindings = new Map();
-  for (let element of elements) {
+  return arrayPath.get('elements').value.map(element => {
     if (element.type !== 'StringLiteral') {
-      throw new SilentError(`Unexpected \`attributeBindings\` value: ${j(arrayPath).toSource()}`);
+      throw new SilentError(`Unexpected \`${name}\` value: ${j(arrayPath).toSource()}`);
     }
 
-    let [from, to] = element.value.split(':');
+    return element.value;
+  });
+}
+
+function findAttributeBindings(properties) {
+  let attrBindings = new Map();
+  for (let binding of findStringArrayProperties(properties, 'attributeBindings')) {
+    let [from, to] = binding.split(':');
     attrBindings.set(from, to || from);
   }
 
   return attrBindings;
 }
 
 function findClassNames(properties) {
-  let classNamesProperty = properties.filter(path => isProperty(path, 'classNames'))[0];
-  if (!classNamesProperty) {
-    return [];
-  }
-
-  let arrayPath = classNamesProperty.get('value');
-  if (arrayPath.value.type !== 'ArrayExpression') {
-    throw new SilentError(`Unexpected \`classNames\` value: ${j(arrayPath).toSource()}`);
-  }
-
-  let elements = arrayPath.get('elements').value;
-
-  let classNames = [];
-  for (let element of elements) {
-    if (element.type !== 'StringLiteral') {
-      throw new SilentError(`Unexpected \`classNames\` value: ${j(arrayPath).toSource()}`);
-    }
-
-    classNames.push(element.value);
-  }
-
-  return classNames;
+  return findStringArrayProperties(properties, 'classNames');
 }
 
 function findClassNameBindings(properties) {
-  let classNameBindingsProperty = properties.filter(path =>
-    isProperty(path, 'classNameBindings')
-  )[0];
-  if (!classNameBindingsProperty) {
-    return new Map();
-  }
-
-  let arrayPath = classNameBindingsProperty.get('value');
-  if (arrayPath.value.type !== 'ArrayExpression') {
-    throw new SilentError(`Unexpected \`classNameBindings\` value: ${j(arrayPath).toSource()}`);
-  }
-
-  let elements = arrayPath.get('elements').value;
-
   let classNameBindings = new Map();
-  for (let element of elements) {
-    if (element.type !== 'StringLiteral') {
-      throw new SilentError(`Unexpected \`classNameBindings\` value: ${j(arrayPath).toSource()}`);
-    }
-
-    let parts = element.value.split(':');
+  for (let binding of findStringArrayProperties(properties, 'classNameBindings')) {
+    let parts = binding.split(':');
 
     if (parts.length === 1) {
       classNameBindings.set(parts[0], [stringUtils.dasherize(parts[0]), null]);
@@ -242,7 +207,7 @@ function findClassNameBindings(properties) {
     } else if (parts.length === 3) {
       classNameBindings.set(parts[0], [parts[1] || null, parts[2]]);
     } else {
-      throw new SilentError(`Unexpected \`classNameBindings\` value: ${j(arrayPath).toSource()}`);
+      throw new SilentError(`Unexpected \`classNameBindings\` value: ${binding}`);
     }
   }