Skip to content

Commit 0cea526

Browse files
committed
Allow colocated templates for potential pods components
1 parent b0f8ea4 commit 0cea526

2 files changed

Lines changed: 40 additions & 12 deletions

File tree

lib/__tests__/template-paths.js

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,28 +4,50 @@ describe('possibleTemplatePaths()', () => {
44
const TESTS = [
55
[
66
'app/components/checkbox.js',
7-
['app/templates/components/checkbox.hbs', 'app/components/checkbox.hbs'],
7+
['app/components/checkbox.hbs', 'app/templates/components/checkbox.hbs'],
88
],
99
[
1010
'app/components/nested/sub/checkbox.js',
1111
[
12-
'app/templates/components/nested/sub/checkbox.hbs',
1312
'app/components/nested/sub/checkbox.hbs',
13+
'app/templates/components/nested/sub/checkbox.hbs',
14+
],
15+
],
16+
[
17+
'app/components/checkbox/component.js',
18+
[
19+
'app/components/checkbox/template.hbs',
20+
'app/components/checkbox/component.hbs',
21+
'app/templates/components/checkbox/component.hbs',
1422
],
1523
],
16-
['app/components/checkbox/component.js', ['app/components/checkbox/template.hbs']],
1724
[
1825
'app/components/nested/sub/component/component.js',
19-
['app/components/nested/sub/component/template.hbs'],
26+
[
27+
'app/components/nested/sub/component/template.hbs',
28+
'app/components/nested/sub/component/component.hbs',
29+
'app/templates/components/nested/sub/component/component.hbs',
30+
],
2031
],
2132
[
2233
'app/components/checkbox.ts',
23-
['app/templates/components/checkbox.hbs', 'app/components/checkbox.hbs'],
34+
['app/components/checkbox.hbs', 'app/templates/components/checkbox.hbs'],
35+
],
36+
[
37+
'app/components/checkbox/component.ts',
38+
[
39+
'app/components/checkbox/template.hbs',
40+
'app/components/checkbox/component.hbs',
41+
'app/templates/components/checkbox/component.hbs',
42+
],
2443
],
25-
['app/components/checkbox/component.ts', ['app/components/checkbox/template.hbs']],
2644
[
2745
'app/components/nested/sub/component/component.ts',
28-
['app/components/nested/sub/component/template.hbs'],
46+
[
47+
'app/components/nested/sub/component/template.hbs',
48+
'app/components/nested/sub/component/component.hbs',
49+
'app/templates/components/nested/sub/component/component.hbs',
50+
],
2951
],
3052
];
3153

lib/transform.js

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,15 +101,21 @@ function transform(source, template, options = {}) {
101101
}
102102

103103
function possibleTemplatePaths(componentPath) {
104+
let classicTemplatePath = componentPath
105+
.replace('/components/', '/templates/components/')
106+
.replace(/\.(js|ts)$/, '.hbs');
107+
108+
let colocatedTemplatePath = componentPath.replace(/\.(js|ts)$/, '.hbs');
109+
110+
let templatePaths = [colocatedTemplatePath, classicTemplatePath];
111+
104112
let isPods = path.basename(componentPath, path.extname(componentPath)) === 'component';
105113
if (isPods) {
106-
return [path.dirname(componentPath) + '/template.hbs'];
114+
let podsTemplatePath = path.dirname(componentPath) + '/template.hbs';
115+
templatePaths.unshift(podsTemplatePath);
107116
}
108117

109-
return [
110-
componentPath.replace('/components/', '/templates/components/').replace(/\.(js|ts)$/, '.hbs'),
111-
componentPath.replace(/\.(js|ts)$/, '.hbs'),
112-
];
118+
return templatePaths;
113119
}
114120

115121
module.exports = {

0 commit comments

Comments
 (0)