Merge pull request #2 from ember-codemods/add-import-statement

Add import statement

Author: scalvert

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ember-test-onerror-codemod",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "scripts": {
     "test": "codemod-cli test",
     "update-docs": "codemod-cli update-docs"

transforms/remove-onerror-assignments/__testfixtures__/convert-onerror-assignment-no-import.input.js

@@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
+
+    Ember.onerror = function() {};
+    Ember.onerror = () => {};
+    Ember.onerror = fn;
+  });
+});

transforms/remove-onerror-assignments/__testfixtures__/convert-onerror-assignment-no-import.output.js

@@ -0,0 +1,12 @@
+import { setupOnerror } from '@ember/test-helpers';
+import { module, test } from 'qunit';
+
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
+
+    setupOnerror(function() {});
+    setupOnerror(() => {});
+    setupOnerror(fn);
+  });
+});

transforms/remove-onerror-assignments/__testfixtures__/convert-onerror-assignment.input.js

@@ -1,7 +1,12 @@
-test('foo test', async function (assert) {
-  assert.expect(1);
+import { module, test } from 'qunit';
+import { click } from '@ember/test-helpers';
 
-  Ember.onerror = function() {};
-  Ember.onerror = () => {};
-  Ember.onerror = fn;
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
+
+    Ember.onerror = function() {};
+    Ember.onerror = () => {};
+    Ember.onerror = fn;
+  });
 });

transforms/remove-onerror-assignments/__testfixtures__/convert-onerror-assignment.output.js

@@ -1,7 +1,12 @@
-test('foo test', async function (assert) {
-  assert.expect(1);
+import { module, test } from 'qunit';
+import { click, setupOnerror } from '@ember/test-helpers';
 
-  setupOnerror(function() {});
-  setupOnerror(() => {});
-  setupOnerror(fn);
-});
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
+
+    setupOnerror(function() {});
+    setupOnerror(() => {});
+    setupOnerror(fn);
+  });
+});

transforms/remove-onerror-assignments/index.js

@@ -1,4 +1,5 @@
 const { getParser } = require('codemod-cli').jscodeshift;
+const { addImportStatement, writeImportStatements } = require('../utils');
 
 module.exports = function transformer(file, api) {
   const j = getParser(api);
@@ -10,19 +11,24 @@ module.exports = function transformer(file, api) {
     let onError = node.right;
 
     return j.callExpression(j.identifier('setupOnerror'), [onError]);
-  }
+  };
 
-  root.find(j.AssignmentExpression, {
+  let replacements = root.find(j.AssignmentExpression, {
     left: {
       object: {
-        name: 'Ember'
+        name: 'Ember',
       },
       property: {
-        name: 'onerror'
-      }
-    }
-  })
-  .replaceWith(replacer);
+        name: 'onerror',
+      },
+    },
+  });
+
+  if (replacements.length > 0) {
+    replacements.replaceWith(replacer);
+    addImportStatement(['setupOnerror']);
+    writeImportStatements(j, root);
+  }
 
-  return root.toSource();
-}
+  return root.toSource({ quote: 'single' });
+};

transforms/remove-onerror-sinon-stubs/__testfixtures__/convert-sandbox-no-import.input.js

@@ -0,0 +1,19 @@
+import { module, test } from 'qunit';
+
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
+
+    sandbox.stub(Ember, 'onerror', function() {});
+    sandbox.stub(Ember, 'onerror', () => {});
+    sandbox.stub(Ember, 'onerror', fn);
+
+    sandbox.stub(Ember, 'foo', function() {});
+    sandbox.stub(Ember, 'foo', () => {});
+    sandbox.stub(Ember, 'foo', fn);
+
+    this.sandbox.stub(Ember, 'onerror', function() {});
+    this.sandbox.stub(Ember, 'onerror', () => {});
+    this.sandbox.stub(Ember, 'onerror', fn);
+  });
+});

transforms/remove-onerror-sinon-stubs/__testfixtures__/convert-sandbox-no-import.output.js

@@ -0,0 +1,20 @@
+import { setupOnerror } from '@ember/test-helpers';
+import { module, test } from 'qunit';
+
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
+
+    setupOnerror(function() {});
+    setupOnerror(() => {});
+    setupOnerror(fn);
+
+    sandbox.stub(Ember, 'foo', function() {});
+    sandbox.stub(Ember, 'foo', () => {});
+    sandbox.stub(Ember, 'foo', fn);
+
+    setupOnerror(function() {});
+    setupOnerror(() => {});
+    setupOnerror(fn);
+  });
+});

transforms/remove-onerror-sinon-stubs/__testfixtures__/convert-sandbox.input.js

@@ -1,15 +1,20 @@
-test('foo test', async function (assert) {
-  assert.expect(1);
+import { module, test } from 'qunit';
+import { click } from '@ember/test-helpers';
 
-  sandbox.stub(Ember, 'onerror', function() {});
-  sandbox.stub(Ember, 'onerror', () => {});
-  sandbox.stub(Ember, 'onerror', fn);
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
 
-  sandbox.stub(Ember, 'foo', function() {});
-  sandbox.stub(Ember, 'foo', () => {});
-  sandbox.stub(Ember, 'foo', fn);
+    sandbox.stub(Ember, 'onerror', function() {});
+    sandbox.stub(Ember, 'onerror', () => {});
+    sandbox.stub(Ember, 'onerror', fn);
 
-  this.sandbox.stub(Ember, 'onerror', function() {});
-  this.sandbox.stub(Ember, 'onerror', () => {});
-  this.sandbox.stub(Ember, 'onerror', fn);
-});
+    sandbox.stub(Ember, 'foo', function() {});
+    sandbox.stub(Ember, 'foo', () => {});
+    sandbox.stub(Ember, 'foo', fn);
+
+    this.sandbox.stub(Ember, 'onerror', function() {});
+    this.sandbox.stub(Ember, 'onerror', () => {});
+    this.sandbox.stub(Ember, 'onerror', fn);
+  });
+});

transforms/remove-onerror-sinon-stubs/__testfixtures__/convert-sandbox.output.js

@@ -1,15 +1,20 @@
-test('foo test', async function (assert) {
-  assert.expect(1);
+import { module, test } from 'qunit';
+import { click, setupOnerror } from '@ember/test-helpers';
 
-  setupOnerror(function() {});
-  setupOnerror(() => {});
-  setupOnerror(fn);
+module('foo', function() {
+  test('foo test', async function(assert) {
+    assert.expect(1);
 
-  sandbox.stub(Ember, 'foo', function() {});
-  sandbox.stub(Ember, 'foo', () => {});
-  sandbox.stub(Ember, 'foo', fn);
+    setupOnerror(function() {});
+    setupOnerror(() => {});
+    setupOnerror(fn);
 
-  setupOnerror(function() {});
-  setupOnerror(() => {});
-  setupOnerror(fn);
+    sandbox.stub(Ember, 'foo', function() {});
+    sandbox.stub(Ember, 'foo', () => {});
+    sandbox.stub(Ember, 'foo', fn);
+
+    setupOnerror(function() {});
+    setupOnerror(() => {});
+    setupOnerror(fn);
+  });
 });