Skip to content

Commit 9865532

Browse files
authored
Merge pull request #30 from simonihmig/fix-empty-jq-selector
Skip converting :eq() and :selected without a selector
2 parents 6d70d5c + 2250d7f commit 9865532

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

transforms/integration/__testfixtures__/jq-extensions.input.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,14 @@ test('it renders', function(assert) {
3333
assert.ok(this.$('.foo:radio').length);
3434
assert.ok(this.$('.foo:reset').length);
3535
assert.ok(this.$('.foo:selected').length);
36+
assert.ok(this.$(':selected').length);
3637
assert.ok(this.$('.foo:submit').length);
3738
assert.ok(this.$('.foo:text').length);
3839
assert.ok(this.$('.foo:visible').length);
3940
assert.ok(this.$(JQEXTENSION_SELECTOR_AS_LOCAL_CONST).length);
4041
assert.ok(this.$(ANY_SELECTOR_AS_IMPORTED_CONST).length);
4142

43+
assert.ok(this.$(':eq(0)').length);
4244
assert.ok(this.$('.foo:eq(0)').length);
4345
assert.ok(this.$('.foo:eq(1)').length);
4446
assert.ok(this.$('.foo:first-child').length);

transforms/integration/__testfixtures__/jq-extensions.output.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,14 @@ test('it renders', function(assert) {
3434
assert.ok(this.$('.foo:radio').length);
3535
assert.ok(this.$('.foo:reset').length);
3636
assert.ok(findAll('.foo:checked').length);
37+
assert.ok(this.$(':selected').length);
3738
assert.ok(this.$('.foo:submit').length);
3839
assert.ok(this.$('.foo:text').length);
3940
assert.ok(this.$('.foo:visible').length);
4041
assert.ok(this.$(JQEXTENSION_SELECTOR_AS_LOCAL_CONST).length);
4142
assert.ok(this.$(ANY_SELECTOR_AS_IMPORTED_CONST).length);
4243

44+
assert.ok(this.$(':eq(0)').length);
4345
assert.ok(findAll(find('.foo')).length);
4446
assert.ok(findAll('.foo')[1].length);
4547
assert.ok(findAll('.foo:first-child').length);

transforms/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ const jqExtensions = [
2828
];
2929

3030
const supportedJqExtensions = [
31-
/:eq/,
32-
/:selected/,
31+
/.+:eq/,
32+
/.+:selected/,
3333
];
3434

3535
const tailEqRegex = /:eq\(\d+\)$/;

0 commit comments

Comments
 (0)