Merge pull request #8 from simonihmig/get-transform

Get transform

Author: simonihmig

README.md

@@ -54,6 +54,7 @@ This addon will perform the following transformations suitable for integration t
 | `this.$('.foo').html()`                              | `find('.foo').innerHTML`                                              | `html.js`      |
 | `this.$('.foo').html('foo')`                         | `find('.foo').innerHTML = 'foo'`                                      | `html.js`      |
 | `this.$('.foo').each((index, elem) => {...})`        | `findAll('.foo').forEach((elem, index) => {...})`                     | `each.js`      |
+| `this.$('.foo').get(3)`                              | `findAll('.foo')[3]`                                                  | `get.js`     |
 
 
 If you want to run only selected transforms on your code, you can pick just the needed transform:
@@ -84,6 +85,7 @@ These transformations are available for acceptance tests:
 | `find('.foo').html()`                                | `find('.foo').innerHTML`                                              | `html.js`      |
 | `find('.foo').html('foo')`                           | `find('.foo').innerHTML = 'foo'`                                      | `html.js`      |
 | `find('.foo').each((index, elem) => {...})`          | `findAll('.foo').forEach((elem, index) => {...})`                     | `each.js`      |
+| `find('.foo').get(3)`                                | `findAll('.foo')[3]`                                                  | `get.js`     |
 
 If you want to run only selected transforms on your code, you can pick just the needed transform:
 

__testfixtures__/acceptance/get.input.js

@@ -0,0 +1,10 @@
+import { test } from 'qunit';
+import moduleForAcceptance from '../../tests/helpers/module-for-acceptance';
+
+moduleForAcceptance('get');
+
+test('transforms get() correctly', function(assert) {
+  assert.ok(find('.foo bar').get(3));
+
+  const otherGet = someOtherObj.get(1);
+});

__testfixtures__/acceptance/get.output.js

@@ -0,0 +1,11 @@
+import { findAll } from '@ember/test-helpers';
+import { test } from 'qunit';
+import moduleForAcceptance from '../../tests/helpers/module-for-acceptance';
+
+moduleForAcceptance('get');
+
+test('transforms get() correctly', function(assert) {
+  assert.ok(findAll('.foo bar')[3]);
+
+  const otherGet = someOtherObj.get(1);
+});

__testfixtures__/integration/get.input.js

@@ -0,0 +1,12 @@
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+
+moduleForComponent('foo-bar', 'Integration | Component | foo bar', {
+  integration: true
+});
+
+test('transforms get() correctly', function(assert) {
+  assert.ok(this.$('.foo').get(1));
+
+  const otherGet = someOtherObj.get(1);
+});

__testfixtures__/integration/get.output.js

@@ -0,0 +1,13 @@
+import { findAll } from '@ember/test-helpers';
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+
+moduleForComponent('foo-bar', 'Integration | Component | foo bar', {
+  integration: true
+});
+
+test('transforms get() correctly', function(assert) {
+  assert.ok(findAll('.foo')[1]);
+
+  const otherGet = someOtherObj.get(1);
+});

lib/transforms/acceptance/each.js

@@ -1,11 +1,10 @@
 const {
   createFindAllExpression,
-  createPropExpression,
   isFindExpression,
   addImportStatement,
   writeImportStatements,
   transformEachsCallbackArgs
- } = require('../../utils');
+} = require('../../utils');
 
 /**
  * Creates a `findAll(selector).forEach()` expression

lib/transforms/acceptance/get.js

@@ -0,0 +1,65 @@
+const {
+  createFindAllExpression,
+  isFindExpression,
+  addImportStatement,
+  writeImportStatements,
+} = require('../../utils');
+
+/**
+ * Creates a `findAll(selector)[0]` expression
+ *
+ * @param j
+ * @param findArgs
+ * @param indexArg
+ * @returns {*}
+ */
+function createExpression(j, findArgs, indexArg) {
+  const index = indexArg[0] && indexArg[0].value || 0;
+  return j.memberExpression(
+    createFindAllExpression(j, findArgs),
+    j.literal(index)
+  );
+}
+
+/**
+ * Check if `node` is a `find(selector).get(0)` expression
+ *
+ * @param j
+ * @param node
+ * @returns {*|boolean}
+ */
+function isJQueryExpression(j, node) {
+  return j.CallExpression.check(node)
+    && j.MemberExpression.check(node.callee)
+    && isFindExpression(j, node.callee.object)
+    && j.Identifier.check(node.callee.property)
+    && node.callee.property.name === 'get';
+}
+
+/**
+ * Transform `find(selector).get(0)` to `findAll(selector)[0]`
+ *
+ * @param file
+ * @param api
+ * @returns {*|string}
+ */
+function transform(file, api) {
+  let source = file.source;
+  let j = api.jscodeshift;
+
+  let root = j(source);
+
+  let replacements = root
+    .find(j.CallExpression)
+    .filter(({ node }) => isJQueryExpression(j, node))
+    .replaceWith(({ node }) => createExpression(j, node.callee.object.arguments, node.arguments));
+
+  if (replacements.length > 0) {
+    addImportStatement(['findAll']);
+  }
+
+  writeImportStatements(j, root);
+  return root.toSource({ quote: 'single' });
+}
+
+module.exports = transform;

lib/transforms/integration/get.js

@@ -0,0 +1,66 @@
+const {
+  createFindAllExpression,
+  isJQuerySelectExpression,
+  addImportStatement,
+  writeImportStatements,
+} = require('../../utils');
+
+/**
+ * Creates a `findAll(selector)[0]` expression
+ *
+ * @param j
+ * @param findArgs
+ * @param indexArg
+ * @returns {*}
+ */
+function createExpression(j, findArgs, indexArg) {
+  const index = indexArg[0] && indexArg[0].value || 0;
+  return j.memberExpression(
+    createFindAllExpression(j, findArgs),
+    j.literal(index)
+  );
+}
+
+/**
+ * Check if `node` is a `this.$(selector).get(0)` expression
+ *
+ * @param j
+ * @param node
+ * @returns {*|boolean}
+ */
+function isJQueryExpression(j, path) {
+  let node = path.node;
+  return j.CallExpression.check(node)
+    && j.MemberExpression.check(node.callee)
+    && isJQuerySelectExpression(j, node.callee.object, path)
+    && j.Identifier.check(node.callee.property)
+    && node.callee.property.name === 'get';
+}
+
+/**
+ * Transforms `this.$(selector).get(0)` to `findAll(selector)[0]`
+ *
+ * @param file
+ * @param api
+ * @returns {*|string}
+ */
+function transform(file, api) {
+  let source = file.source;
+  let j = api.jscodeshift;
+
+  let root = j(source);
+
+  let replacements = root
+    .find(j.CallExpression)
+    .filter((path) => isJQueryExpression(j, path))
+    .replaceWith(({ node }) => createExpression(j, node.callee.object.arguments, node.arguments));
+
+  if (replacements.length > 0) {
+    addImportStatement(['findAll']);
+  }
+
+  writeImportStatements(j, root);
+  return root.toSource({ quote: 'single' });
+}
+
+module.exports = transform;