Skip to content

Commit 270fcf4

Browse files
author
Robert Jackson
committed
Avoid adding module import when not needed.
1 parent 2417f93 commit 270fcf4

3 files changed

Lines changed: 26 additions & 1 deletion

File tree

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import resolver from './helpers/resolver';
2+
import {
3+
setResolver
4+
} from 'ember-qunit';
5+
import { start } from 'ember-cli-qunit';
6+
7+
setResolver(resolver);
8+
start();
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import resolver from './helpers/resolver';
2+
import {
3+
setResolver
4+
} from 'ember-qunit';
5+
import { start } from 'ember-cli-qunit';
6+
7+
setResolver(resolver);
8+
start();

ember-qunit-codemod.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ module.exports = function(file, api, options) {
4545
// Find `module` and `test` imports
4646
let migrateToQUnitImport = ['module', 'test', 'skip', 'todo'];
4747

48-
let specifiers = new Set(['module']);
48+
let specifiers = new Set();
4949
// Replace old with new test helpers imports
5050
emberQUnitImports
5151
.find(j.ImportSpecifier)
@@ -84,6 +84,15 @@ module.exports = function(file, api, options) {
8484
let importName = p.node.imported.name;
8585
let mappedName = mapping[importName] || importName;
8686

87+
if (mappedName !== importName) {
88+
ensureImportWithSpecifiers({
89+
source: 'qunit',
90+
anchor: 'ember-qunit',
91+
positionMethod: 'insertBefore',
92+
specifiers: ['module'],
93+
});
94+
}
95+
8796
// If importName is `moduleForComponent` determine if we need
8897
// `setupTest` (unit) or `setupRenderingTest` (integration)
8998
if (importName === 'moduleForComponent') {

0 commit comments

Comments
 (0)