Merge pull request #20 from rwjblue/module-for-model

Fix `this.subject()` usage within `moduleForModel`.

Author: rwjblue

__testfixtures__/ember-qunit-codemod/subject.output.js

@@ -21,27 +21,27 @@ module('Unit | Model | Foo', function(hooks) {
   setupTest(hooks);
 
   test('has some thing', function (assert) {
-    let subject = this.owner.factoryFor('model:foo').create();
+    let subject = this.owner.lookup('service:store').createRecord('foo');
   });
 
   test('has another thing', function (assert) {
-    let subject = this.owner.factoryFor('model:foo').create({ size: 'big' });
+    let subject = this.owner.lookup('service:store').createRecord('foo', { size: 'big' });
   });
 });
 
 module('Integration | Model | Foo', function(hooks) {
   setupTest(hooks);
 
   test('has some thing', function (assert) {
-    let subject = this.owner.factoryFor('model:foo').create();
+    let subject = this.owner.lookup('service:store').createRecord('foo');
   });
 });
 
 module('Unit | Model | Foo', function(hooks) {
   setupTest(hooks);
 
   test('has some thing', function (assert) {
-    let subject = this.owner.factoryFor('model:foo').create();
+    let subject = this.owner.lookup('service:store').createRecord('foo');
   });
 });
 

ember-qunit-codemod.js

@@ -246,7 +246,7 @@ module.exports = function(file, api, options) {
 
       thisDotSubjectUsage.forEach(p => {
         let options = p.node.arguments[0];
-        let subjectType = subject.value.split(':')[0];
+        let [subjectType, subjectName] = subject.value.split(':');
         let isSingletonSubject = !['model', 'component'].includes(subjectType);
 
         // if we don't have `options` and the type is a singleton type
@@ -261,6 +261,22 @@ module.exports = function(file, api, options) {
               [subject]
             )
           );
+        } else if (subjectType === 'model') {
+          p.replace(
+            j.callExpression(
+              j.memberExpression(
+                j.callExpression(
+                  j.memberExpression(
+                    j.memberExpression(j.thisExpression(), j.identifier('owner')),
+                    j.identifier('lookup')
+                  ),
+                  [j.literal('service:store')]
+                ),
+                j.identifier('createRecord')
+              ),
+              [j.literal(subjectName), options].filter(Boolean)
+            )
+          );
         } else {
           p.replace(
             j.callExpression(