Skip to content

Commit d06b16a

Browse files
Turbo87NullVoxPopuli
authored andcommitted
Merge pull request #70 from Turbo87/tele
Move `getTelemetry()` call out of `plugin.js` file
1 parent f05ebce commit d06b16a

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

transforms/no-implicit-this/helpers/plugin.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
const { getTelemetry } = require('ember-codemods-telemetry-helpers');
21
// everything is copy-pasteable to astexplorer.net.
32
// sorta. telemetry needs to be defined.
43
// telemtry can be populated with -mock-telemetry.json
@@ -11,7 +10,8 @@ function transformPlugin(env, options = {}) {
1110
let { builders: b } = env.syntax;
1211

1312
let scopedParams = [];
14-
let [components, helpers] = populateInvokeables();
13+
let telemetry = options.telemetry || {};
14+
let [components, helpers] = populateInvokeables(telemetry);
1515

1616
let customHelpers = options.customHelpers || [];
1717

@@ -146,10 +146,9 @@ function transformPlugin(env, options = {}) {
146146
};
147147
}
148148

149-
function populateInvokeables() {
149+
function populateInvokeables(telemetry) {
150150
let components = [];
151151
let helpers = [];
152-
let telemetry = getTelemetry();
153152

154153
for (let name of Object.keys(telemetry)) {
155154
let entry = telemetry[name];

transforms/no-implicit-this/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ const path = require('path');
22
const fs = require('fs');
33

44
const recast = require('ember-template-recast');
5+
const { getTelemetry } = require('ember-codemods-telemetry-helpers');
56
const transformPlugin = require('./helpers/plugin');
67
const { getOptions: getCLIOptions } = require('codemod-cli');
78
const DEFAULT_OPTIONS = {};
@@ -34,6 +35,7 @@ function getOptions() {
3435
let cliOptions = getCLIOptions();
3536
let options = {
3637
customHelpers: _getCustomHelpersFromConfig(cliOptions.config),
38+
telemetry: getTelemetry(),
3739
};
3840
return options;
3941
}

0 commit comments

Comments
 (0)