Fix the integration tests by upgrading codemode-cli so that we can properly

NullVoxPopuli · NullVoxPopuli · commit a28968c77761 · 2019-07-12T22:58:24.000-04:00
run the integration tests (and, in general, invoke the codemod)
Should be good for external testing to begin once this is merged.

update the cli.js

update deps

Update bin/cli.js

Co-Authored-By: Robert Jackson &lt;me@rwjblue.com&gt;

idk

they run! yay!

try to get input and output the same

fix linting
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 node_modules
 tmp
-*.log
+*.log
+test/**/yarn.lock
diff --git a/README.md b/README.md
@@ -8,7 +8,7 @@ A collection of codemod's for ember-no-implicit-this-codemod.
 To run a specific codemod from this project, you would run the following:
 
 ```
-npx ember-no-implicit-this-codemod <TRANSFORM NAME> path/of/files/ or/some**/*glob.js
+npx ember-no-implicit-this-codemod no-implicit-this path/of/files/ or/some**/*glob.hbs
 
 # or
 
diff --git a/bin/cli.js b/bin/cli.js
@@ -4,6 +4,4 @@
 const transformName = process.argv[2];
 const args = process.argv.slice(3);
 
-console.log(transformName, args);
-
-require('codemod-cli').runTransform(__dirname, transformName, args);
+require('codemod-cli').runTransform(__dirname, transformName, args, 'hbs');
diff --git a/package.json b/package.json
@@ -31,26 +31,26 @@
     "codemod-cli"
   ],
   "dependencies": {
-    "codemod-cli": "^1.0.0",
-    "ember-template-recast": "^2.0.0",
+    "codemod-cli": "^1.1.0",
+    "ember-template-recast": "^3.1.1",
     "fs-extra": "^8.1.0",
     "git-repo-info": "^2.1.0",
     "minimatch": "^3.0.4",
     "puppeteer": "^1.18.1",
     "sync-disk-cache": "^1.3.3",
-    "walk-sync": "^2.0.1",
+    "walk-sync": "^2.0.2",
     "winston": "^3.2.1"
   },
   "devDependencies": {
     "babel-plugin-htmlbars-inline-precompile": "^1.0.0",
-    "coveralls": "^3.0.4",
+    "coveralls": "^3.0.5",
     "eslint": "^6.0.1",
     "eslint-config-prettier": "^6.0.0",
     "eslint-plugin-prettier": "^3.1.0",
-    "execa": "^2.0.1",
+    "execa": "^2.0.3",
     "jest": "^24.8.0",
     "prettier": "^1.18.2",
-    "release-it": "^12.3.0",
+    "release-it": "^12.3.3",
     "release-it-lerna-changelog": "^1.0.3"
   },
   "engines": {
diff --git a/test/fixtures/input/README.md b/test/fixtures/input/README.md
@@ -1,4 +1,4 @@
-# input
+# app
 
 This README outlines the details of collaborating on this Ember application.
 A short introduction of this app could easily go here.
@@ -15,7 +15,7 @@ You will need the following things properly installed on your computer.
 ## Installation
 
 * `git clone <repository-url>` this repository
-* `cd input`
+* `cd app`
 * `npm install`
 
 ## Running / Development
diff --git a/test/fixtures/input/app/index.html b/test/fixtures/input/app/index.html
@@ -3,22 +3,22 @@
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
-    <title>Input</title>
+    <title>App</title>
     <meta name="description" content="">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 
     {{content-for "head"}}
 
     <link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
-    <link integrity="" rel="stylesheet" href="{{rootURL}}assets/input.css">
+    <link integrity="" rel="stylesheet" href="{{rootURL}}assets/app.css">
 
     {{content-for "head-footer"}}
   </head>
   <body>
     {{content-for "body"}}
 
     <script src="{{rootURL}}assets/vendor.js"></script>
-    <script src="{{rootURL}}assets/input.js"></script>
+    <script src="{{rootURL}}assets/app.js"></script>
 
     {{content-for "body-footer"}}
   </body>
diff --git a/test/fixtures/input/config/environment.js b/test/fixtures/input/config/environment.js
@@ -2,7 +2,7 @@
 
 module.exports = function(environment) {
   let ENV = {
-    modulePrefix: 'input',
+    modulePrefix: 'app',
     environment,
     rootURL: '/',
     locationType: 'auto',
diff --git a/test/fixtures/input/package.json b/test/fixtures/input/package.json
@@ -1,8 +1,8 @@
 {
-  "name": "input",
+  "name": "app",
   "version": "0.0.0",
   "private": true,
-  "description": "Small description for input goes here",
+  "description": "Small description for app goes here",
   "repository": "",
   "license": "MIT",
   "author": "",
diff --git a/test/fixtures/input/tests/index.html b/test/fixtures/input/tests/index.html
@@ -3,15 +3,15 @@
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
-    <title>Input Tests</title>
+    <title>App Tests</title>
     <meta name="description" content="">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 
     {{content-for "head"}}
     {{content-for "test-head"}}
 
     <link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
-    <link rel="stylesheet" href="{{rootURL}}assets/input.css">
+    <link rel="stylesheet" href="{{rootURL}}assets/app.css">
     <link rel="stylesheet" href="{{rootURL}}assets/test-support.css">
 
     {{content-for "head-footer"}}
@@ -24,7 +24,7 @@
     <script src="/testem.js" integrity=""></script>
     <script src="{{rootURL}}assets/vendor.js"></script>
     <script src="{{rootURL}}assets/test-support.js"></script>
-    <script src="{{rootURL}}assets/input.js"></script>
+    <script src="{{rootURL}}assets/app.js"></script>
     <script src="{{rootURL}}assets/tests.js"></script>
 
     {{content-for "body-footer"}}
diff --git a/test/fixtures/output/.eslintignore b/test/fixtures/output/.eslintignore
@@ -2,7 +2,7 @@
 /blueprints/*/files/
 /vendor/
 
-# compiled output
+# compiled app
 /dist/
 /tmp/
 
diff --git a/test/fixtures/output/.gitignore b/test/fixtures/output/.gitignore
@@ -1,6 +1,6 @@
 # See https://help.github.com/ignore-files/ for more about ignoring files.
 
-# compiled output
+# compiled app
 /dist/
 /tmp/
 
diff --git a/test/fixtures/output/README.md b/test/fixtures/output/README.md
@@ -1,4 +1,4 @@
-# output
+# app
 
 This README outlines the details of collaborating on this Ember application.
 A short introduction of this app could easily go here.
@@ -15,7 +15,7 @@ You will need the following things properly installed on your computer.
 ## Installation
 
 * `git clone <repository-url>` this repository
-* `cd output`
+* `cd app`
 * `npm install`
 
 ## Running / Development
diff --git a/test/fixtures/output/app/index.html b/test/fixtures/output/app/index.html
@@ -3,22 +3,22 @@
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
-    <title>Output</title>
+    <title>App</title>
     <meta name="description" content="">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 
     {{content-for "head"}}
 
     <link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
-    <link integrity="" rel="stylesheet" href="{{rootURL}}assets/output.css">
+    <link integrity="" rel="stylesheet" href="{{rootURL}}assets/app.css">
 
     {{content-for "head-footer"}}
   </head>
   <body>
     {{content-for "body"}}
 
     <script src="{{rootURL}}assets/vendor.js"></script>
-    <script src="{{rootURL}}assets/output.js"></script>
+    <script src="{{rootURL}}assets/app.js"></script>
 
     {{content-for "body-footer"}}
   </body>
diff --git a/test/fixtures/output/config/environment.js b/test/fixtures/output/config/environment.js
@@ -2,7 +2,7 @@
 
 module.exports = function(environment) {
   let ENV = {
-    modulePrefix: 'output',
+    modulePrefix: 'app',
     environment,
     rootURL: '/',
     locationType: 'auto',
@@ -35,7 +35,7 @@ module.exports = function(environment) {
     // Testem prefers this...
     ENV.locationType = 'none';
 
-    // keep test console output quieter
+    // keep test console app quieter
     ENV.APP.LOG_ACTIVE_GENERATION = false;
     ENV.APP.LOG_VIEW_LOOKUPS = false;
 
diff --git a/test/fixtures/output/ember-cli-build.js b/test/fixtures/output/ember-cli-build.js
@@ -8,7 +8,7 @@ module.exports = function(defaults) {
   });
 
   // Use `app.import` to add additional libraries to the generated
-  // output files.
+  // app files.
   //
   // If you need to use different assets in different
   // environments, specify an object as the first parameter. That
diff --git a/test/fixtures/output/package-lock.json b/test/fixtures/output/package-lock.json
diff --git a/test/fixtures/output/package.json b/test/fixtures/output/package.json
@@ -1,8 +1,8 @@
 {
-  "name": "output",
+  "name": "app",
   "version": "0.0.0",
   "private": true,
-  "description": "Small description for output goes here",
+  "description": "Small description for app goes here",
   "repository": "",
   "license": "MIT",
   "author": "",
diff --git a/test/fixtures/output/tests/index.html b/test/fixtures/output/tests/index.html
@@ -3,15 +3,15 @@
   <head>
     <meta charset="utf-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
-    <title>Output Tests</title>
+    <title>App Tests</title>
     <meta name="description" content="">
     <meta name="viewport" content="width=device-width, initial-scale=1">
 
     {{content-for "head"}}
     {{content-for "test-head"}}
 
     <link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
-    <link rel="stylesheet" href="{{rootURL}}assets/output.css">
+    <link rel="stylesheet" href="{{rootURL}}assets/app.css">
     <link rel="stylesheet" href="{{rootURL}}assets/test-support.css">
 
     {{content-for "head-footer"}}
@@ -24,7 +24,7 @@
     <script src="/testem.js" integrity=""></script>
     <script src="{{rootURL}}assets/vendor.js"></script>
     <script src="{{rootURL}}assets/test-support.js"></script>
-    <script src="{{rootURL}}assets/output.js"></script>
+    <script src="{{rootURL}}assets/app.js"></script>
     <script src="{{rootURL}}assets/tests.js"></script>
 
     {{content-for "body-footer"}}
diff --git a/test/run-test.js b/test/run-test.js
@@ -30,7 +30,7 @@ const execOpts = { cwd: inputDir, stderr: 'inherit' };
 
   console.log('running codemod');
 
-  await execa('../../../bin/cli.js', ['http://localhost:4200', 'app'], execOpts);
+  await execa('../../../bin/cli.js', ['no-implicit-this', 'app'], execOpts);
 
   console.log('codemod complete, ending serve');
 
diff --git a/yarn.lock b/yarn.lock

-Original file line number
+Diff line change
@@ @@ -1,3 +1,4 @@ @@
 node_modules
 tmp
 -*.log
 +*.log
 +test/**/yarn.lock