Skip to content

Commit 9b46cd6

Browse files
Fixes Void element bug (#23)
* Add test for void element transform * upgrading did not fix this bug * update recast
1 parent d129f08 commit 9b46cd6

5 files changed

Lines changed: 461 additions & 362 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"dependencies": {
3434
"codemod-cli": "^1.1.0",
3535
"ember-codemods-telemetry-helpers": "^0.4.0",
36-
"ember-template-recast": "^3.1.1",
36+
"ember-template-recast": "^3.1.3",
3737
"fs-extra": "^8.1.0",
3838
"git-repo-info": "^2.1.0",
3939
"minimatch": "^3.0.4",

transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,10 @@
4646
"computedProperties": ["foo", "property"],
4747
"getters": ["someGetter"]
4848
},
49+
"void-elements.input": {
50+
"type": "Component",
51+
"computedProperties": ["previewImageUrl"]
52+
},
4953
"my-helper": { "type": "Helper" },
5054
"a-helper": { "type": "Helper" },
5155
"link-to": { "type": "Helper" },
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<img
2+
id="Preview"
3+
src="{{previewImageUrl}}"
4+
class="image"
5+
>
6+
7+
<img
8+
id="Preview"
9+
src="{{previewImageUrl}}"
10+
class="image"
11+
/>
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<img
2+
id="Preview"
3+
src="{{this.previewImageUrl}}"
4+
class="image"
5+
>
6+
7+
<img
8+
id="Preview"
9+
src="{{this.previewImageUrl}}"
10+
class="image"
11+
/>

0 commit comments

Comments
 (0)