this way of testing makes much more sense

NullVoxPopuli · NullVoxPopuli · commit 8260dd1c7c3c · 2019-07-03T20:39:21.000-04:00
diff --git a/transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json b/transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json
@@ -14,17 +14,30 @@
       "foos"
     ]
   },
-  "component-invocation.input": {
+  "built-in-helpers.input": {
     "type": "Component",
-    "computedProperties": ["ab", "records", "varisalsoacomponent"],
-    "ownProperties": ["property"],
+    "computedProperties": ["foo", "records"],
     "ownActions": ["myAction"]
   },
-  "controller-property.input": {
-    "type": "Controller",
-    "computedProperties": ["model", "controllerProp"],
-    "ownActions": ["actionName"]
+  "handlebars-with-positional-params.input": {
+    "type": "Component",
+    "computedProperties": ["foo", "property"],
+    "ownActions": ["myAction"]
+  },
+  "handlebars-with-hash-params.input": {
+    "type": "Component",
+    "computedProperties": ["foo", "property"],
+    "ownActions": ["myAction"]
+  },
+  "handlebars-with-block-params.input": {
+    "type": "Component",
+    "computedProperties": ["foo", "property"]
+  },
+  "handlebars-without-params.input": {
+    "type": "Component",
+    "computedProperties": ["foo", "property"]
   },
+  "my-helper": { "type": "Helper" },
   "a-helper": { "type": "Helper" },
   "unescaped": { "type": "Helper" },
   "someting": { "type": "Helper" },
diff --git a/transforms/no-implicit-this/__testfixtures__/built-in-helpers.input.hbs b/transforms/no-implicit-this/__testfixtures__/built-in-helpers.input.hbs
@@ -0,0 +1,19 @@
+{{debugger}}
+{{has-block}}
+{{hasBlock}}
+{{input}}
+{{outlet}}
+{{textarea}}
+{{yield}}
+
+{{#let (concat "a" "b") as |ab|}}
+  {{ab}}
+{{/let}}
+
+{{#each records as |record|}}
+  {{record.property}}
+{{/each}}
+
+
+<button {{on 'click' myAction}}>Action</button>
+<button {{on 'click' (fn myAction foo)}}>Action</button>
diff --git a/transforms/no-implicit-this/__testfixtures__/built-in-helpers.output.hbs b/transforms/no-implicit-this/__testfixtures__/built-in-helpers.output.hbs
@@ -0,0 +1,19 @@
+{{debugger}}
+{{has-block}}
+{{hasBlock}}
+{{input}}
+{{outlet}}
+{{textarea}}
+{{yield}}
+
+{{#let (concat "a" "b") as |ab|}}
+  {{ab}}
+{{/let}}
+
+{{#each this.records as |record|}}
+  {{record.property}}
+{{/each}}
+
+
+<button {{on 'click' this.myAction}}>Action</button>
+<button {{on 'click' (fn this.myAction this.foo)}}>Action</button>
diff --git a/transforms/no-implicit-this/__testfixtures__/component-invocation.input.hbs b/transforms/no-implicit-this/__testfixtures__/component-invocation.input.hbs
diff --git a/transforms/no-implicit-this/__testfixtures__/component-invocation.output.hbs b/transforms/no-implicit-this/__testfixtures__/component-invocation.output.hbs
diff --git a/transforms/no-implicit-this/__testfixtures__/controller-property.input.hbs b/transforms/no-implicit-this/__testfixtures__/controller-property.input.hbs
diff --git a/transforms/no-implicit-this/__testfixtures__/controller-property.output.hbs b/transforms/no-implicit-this/__testfixtures__/controller-property.output.hbs
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-with-block-params.input.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-with-block-params.input.hbs
@@ -0,0 +1,15 @@
+{{#my-component as |foo myAction hash components|}}
+  {{foo}} {{myAction}}
+  {{hash.property}} {{hash.foo}}
+
+  {{components.foo}}
+
+  {{#components.my-component}}
+
+  {{/components.my-component}}
+
+  {{#components.block as |block|}}
+    {{block}}
+  {{/components.block}}
+{{/my-component}}
+
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-with-block-params.output.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-with-block-params.output.hbs
@@ -0,0 +1,15 @@
+{{#my-component as |foo myAction hash components|}}
+  {{foo}} {{myAction}}
+  {{hash.property}} {{hash.foo}}
+
+  {{components.foo}}
+
+  {{#components.my-component}}
+
+  {{/components.my-component}}
+
+  {{#components.block as |block|}}
+    {{block}}
+  {{/components.block}}
+{{/my-component}}
+
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-with-hash-params.input.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-with-hash-params.input.hbs
@@ -0,0 +1,9 @@
+{{my-component arg="string"}}
+{{my-component arg=2}}
+{{my-component arg=foo}}
+{{my-component arg=property}}
+{{my-component arg=(my-helper property)}}
+{{my-component arg=(my-helper (fn myAction property) foo)}}
+{{my-component arg=property arg2=foo}}
+{{my-component arg=property arg2=(fn myAction foo)}}
+
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-with-hash-params.output.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-with-hash-params.output.hbs
@@ -0,0 +1,9 @@
+{{my-component arg="string"}}
+{{my-component arg=2}}
+{{my-component arg=this.foo}}
+{{my-component arg=this.property}}
+{{my-component arg=(my-helper this.property)}}
+{{my-component arg=(my-helper (fn this.myAction this.property) this.foo)}}
+{{my-component arg=this.property arg2=this.foo}}
+{{my-component arg=this.property arg2=(fn this.myAction this.foo)}}
+
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-with-positional-params.input.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-with-positional-params.input.hbs
@@ -0,0 +1,8 @@
+{{my-component "string"}}
+{{my-component 1}}
+{{my-component foo}}
+{{my-component property}}
+{{my-component (my-helper property)}}
+{{my-component (my-helper "string")}}
+{{my-component (my-helper 1)}}
+
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-with-positional-params.output.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-with-positional-params.output.hbs
@@ -0,0 +1,8 @@
+{{my-component "string"}}
+{{my-component 1}}
+{{my-component this.foo}}
+{{my-component this.property}}
+{{my-component (my-helper this.property)}}
+{{my-component (my-helper "string")}}
+{{my-component (my-helper 1)}}
+
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-without-params.input.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-without-params.input.hbs
@@ -0,0 +1,4 @@
+{{my-component}}
+{{a-helper}}
+{{foo}}
+{{property}}
diff --git a/transforms/no-implicit-this/__testfixtures__/handlebars-without-params.output.hbs b/transforms/no-implicit-this/__testfixtures__/handlebars-without-params.output.hbs
@@ -0,0 +1,4 @@
+{{my-component}}
+{{a-helper}}
+{{this.foo}}
+{{this.property}}
