Fix type-checking errors

Author: gitKrystan

.gitignore

@@ -3,3 +3,10 @@ node_modules
 tmp
 *.log
 test/**/yarn.lock
+test/**/*.js
+test/**/*.js.map
+transforms/**/*.js
+transforms/**/*.js.map
+helpers/**/*.js
+helpers/**/*.js.map
+!**/__testfixtures__/**/*

helpers/types.ts

@@ -0,0 +1,6 @@
+/** Type predicate. Checks if the given value is a `Record<string, unknown>`. */
+export function isRecord<R extends Record<string, unknown>>(
+  value: unknown
+): value is R {
+  return value !== null && typeof value === 'object';
+}

package.json

@@ -12,13 +12,19 @@
   },
   "homepage": "https://github.com/ember-codemods/ember-no-implicit-this-codemod#readme",
   "author": "",
+  "files": [
+    "/bin",
+    "/helpers/**/*.js",
+    "/transforms/no-implicit-this/index.js",
+    "/transforms/no-implicit-this/helpers/**/*.js"
+  ],
   "scripts": {
     "release": "release-it",
     "prepublishOnly": "yarn build",
-    "postpublish": "yarn clean",
     "build": "tsc",
     "clean": "tsc --build --clean",
     "test": "jest",
+    "pretest:integration": "yarn build",
     "test:integration": "ts-node ./test/run-test.ts",
     "update-docs": "codemod-cli update-docs",
     "coveralls": "cat ./coverage/lcov.info | node node_modules/.bin/coveralls",
@@ -36,16 +42,21 @@
     "codemod-cli"
   ],
   "dependencies": {
-    "codemod-cli": "^2.1.0",
+    "@babel/core": "^7.21.8",
+    "@babel/preset-env": "^7.21.5",
+    "codemod-cli": "^3.2.0",
     "debug": "^4.1.1",
     "ember-codemods-telemetry-helpers": "^2.1.0",
-    "ember-template-recast": "^3.3.2"
+    "ember-template-recast": "^6.1.4",
+    "zod": "^3.21.4"
   },
   "devDependencies": {
     "@tsconfig/node16": "^1.0.4",
     "@tsconfig/strictest": "^2.0.1",
     "@types/chalk": "^2.2.0",
     "@types/common-tags": "^1.8.0",
+    "@types/debug": "^4.1.8",
+    "@types/jscodeshift": "^0.11.6",
     "@types/node": "^20.2.3",
     "@typescript-eslint/eslint-plugin": "^5.59.7",
     "@typescript-eslint/parser": "^5.59.7",
@@ -57,10 +68,11 @@
     "eslint-config-prettier": "^6.15.0",
     "eslint-plugin-prettier": "^3.4.0",
     "execa": "^3.4.0",
-    "jest": "^26.6.3",
+    "jest": "^29.1.0",
     "prettier": "^1.19.1",
     "release-it": "^14.6.2",
     "release-it-lerna-changelog": "^3.1.0",
+    "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",
     "typescript": "~5.0.4"
   },
@@ -69,8 +81,9 @@
   },
   "jest": {
     "testEnvironment": "node",
+    "preset": "ts-jest",
     "testMatch": [
-      "<rootDir>/transforms/**/test.js"
+      "<rootDir>/transforms/**/test.{js,ts}"
     ]
   },
   "publishConfig": {

test/helpers/sequence.ts

@@ -23,4 +23,5 @@ export async function runTestIntegrationSequence(version: string) {
 
   log(`Comparing Results`);
   await runner.compare();
+  log(`Success`);
 }

test/helpers/test-runner.ts

@@ -1,6 +1,7 @@
-import path from 'path';
 import execa, { CommonOptions } from 'execa';
-import { log, timeoutAfter, kill, error } from './utils';
+import path from 'node:path';
+import { kill, timeoutAfter } from './utils';
+import { isRecord } from '../../helpers/types';
 
 const devServerTimeout = 60000;
 
@@ -37,13 +38,13 @@ export class TestRunner {
       },
     });
 
-    if (process.env.DEBUG) {
-      emberServe.stdout.pipe(process.stdout);
-      emberServe.stderr.pipe(process.stderr);
+    if (process.env['DEBUG']) {
+      emberServe.stdout?.pipe(process.stdout);
+      emberServe.stderr?.pipe(process.stderr);
     }
 
-    const serverWaiter = new Promise(resolve => {
-      emberServe.stdout.on('data', data => {
+    const serverWaiter = new Promise<void>(resolve => {
+      emberServe.stdout?.on('data', data => {
         if (data.toString().includes('Build successful')) {
           resolve();
         }
@@ -61,7 +62,10 @@ export class TestRunner {
   }
 
   async stopEmber(): Promise<void> {
-    await timeoutAfter(devServerTimeout, kill(this.emberProcess));
+    const { emberProcess } = this;
+    if (emberProcess) {
+      await timeoutAfter(devServerTimeout, kill(emberProcess));
+    }
   }
 
   async compare() {
@@ -71,7 +75,7 @@ export class TestRunner {
 
       await execa('diff', ['-rq', actual, expectedApp], { cwd: this.inputDir, stdio: 'inherit' });
     } catch (e) {
-      console.log(e.stdout);
+      console.log(isRecord(e) ? e['stdout']: 'codemod did not run successfully');
 
       throw new Error('codemod did not run successfully');
     }

test/helpers/utils.ts

@@ -1,11 +1,12 @@
 import chalk from 'chalk';
 import execa from 'execa';
+import { isRecord } from '../../helpers/types';
 
-export function log(msg: string): void {
+export function log(msg: unknown): void {
   console.log(chalk.yellowBright(msg));
 }
 
-export function error(msg: string): void {
+export function error(msg: unknown): void {
   console.error(chalk.redBright(msg));
 }
 
@@ -20,8 +21,8 @@ export function timeoutAfter<T>(ms: number, promise: Promise<T>) {
   return Promise.race([promise, timeout]);
 }
 
-export async function kill(subprocess: execa.ExecaChildProcess) {
-  if (!subprocess) {
+export async function kill(subprocess: execa.ExecaChildProcess): Promise<void> {
+  if (!subprocess || !subprocess.pid) {
     throw new Error('Cannot kill non-running process');
   }
 
@@ -32,7 +33,7 @@ export async function kill(subprocess: execa.ExecaChildProcess) {
   } catch (e) {
     console.log(`PID ${subprocess.pid} has stopped.`);
     console.log(`\tKilled: ${subprocess.killed}`);
-    console.log(`\tCancelled: ${e.isCanceled}`);
+    console.log(`\tCancelled: ${isRecord(e) ? e['isCanceled']: 'unknown'}`);
   }
 
   return new Promise(resolve => {

test/run-test.ts

@@ -8,7 +8,7 @@ import { runTestIntegrationSequence } from './helpers/sequence';
 const allVersions = ['3.10', '3.13'];
 
 (async (): Promise<void> => {
-  const emberVersion = process.env.EMBER_VERSION;
+  const emberVersion = process.env['EMBER_VERSION'];
 
   if (!emberVersion) {
     console.error(`No EMBER_VERSION set. No scenarios to run.`);
@@ -23,7 +23,7 @@ const allVersions = ['3.10', '3.13'];
   let didSucceed = false;
 
   try {
-    process.env.DEBUG = 'true'; // hacks for now
+    process.env['DEBUG'] = 'true'; // hacks for now
     await runTestIntegrationSequence(emberVersion);
     didSucceed = true;
   } catch (e) {

transforms/no-implicit-this/__testfixtures__/-mock-telemetry.d.json.ts

@@ -0,0 +1,5 @@
+export type Telemetry = Record<string, Record<string, unknown>>;
+
+declare const telemetry: Telemetry;
+
+export default telemetry;

transforms/no-implicit-this/babel-config.ts

@@ -40,4 +40,4 @@ const KNOWN_HELPERS = [
   '-get-dynamic-var', // glimmer internal helper
 ];
 
-module.exports = KNOWN_HELPERS;
+export default KNOWN_HELPERS;