Merge pull request #49 from suchitadoshi1987/suchita/supportwallstreet

Add support for ember-holy-futuristic-template-namespacing-batman syntax and Nested Invocations in Angle Bracket Syntax

Author: NullVoxPopuli

transforms/no-implicit-this/__testfixtures__/-mock-telemetry.json

@@ -1,6 +1,7 @@
 {
   "some-component": { "type": "Component" },
   "my-component": { "type": "Component" },
+  "namespace/my-component": { "type": "Component" },
   "block-component": { "type": "Component" },
   "foo": { "type": "Component" },
   "namespace/foo": { "type": "Component" },
@@ -32,6 +33,11 @@
     "computedProperties": ["foo", "property"],
     "ownActions": ["myAction"]
   },
+  "handlebars-with-wall-street-syntax": {
+    "type": "Component",
+    "computedProperties": ["foo", "property"],
+    "ownActions": ["myAction"]
+  },
   "handlebars-with-hash-params": {
     "type": "Component",
     "computedProperties": ["foo", "property"],

transforms/no-implicit-this/__testfixtures__/angle-brackets-with-hash-params.input.hbs

@@ -5,6 +5,8 @@
 <SomeComponent @arg=1 />
 <SomeComponent @arg=foo />
 <SomeComponent @arg={{foo}} @bar={{property}} />
+<MyAddon$MyComponent @arg={{foo}} @bar={{property}} />
+<MyAddon$Namespace::MyComponent @arg={{foo}} @bar={{property}} />
 <SomeComponent @arg={{foo}} @bar={{fn myAction}} />
 <Select
   data-test-select

transforms/no-implicit-this/__testfixtures__/angle-brackets-with-hash-params.output.hbs

@@ -5,6 +5,8 @@
 <SomeComponent @arg=1 />
 <SomeComponent @arg=foo />
 <SomeComponent @arg={{this.foo}} @bar={{this.property}} />
+<MyAddon$MyComponent @arg={{this.foo}} @bar={{this.property}} />
+<MyAddon$Namespace::MyComponent @arg={{this.foo}} @bar={{this.property}} />
 <SomeComponent @arg={{this.foo}} @bar={{fn this.myAction}} />
 <Select
   data-test-select

transforms/no-implicit-this/__testfixtures__/handlebars-with-wall-street-syntax.input.hbs

@@ -0,0 +1,6 @@
+{{my-addon$my-component foo}}
+{{my-addon$namespace::my-component @foo}}
+{{my-addon$namespace::my-component property}}
+{{my-addon$my-component (my-helper property)}}
+{{my-addon$my-component (my-helper "string")}}
+{{my-addon$namespace::my-component (my-helper 1)}}

transforms/no-implicit-this/__testfixtures__/handlebars-with-wall-street-syntax.output.hbs

@@ -0,0 +1,6 @@
+{{my-addon$my-component this.foo}}
+{{my-addon$namespace::my-component @foo}}
+{{my-addon$namespace::my-component this.property}}
+{{my-addon$my-component (my-helper this.property)}}
+{{my-addon$my-component (my-helper "string")}}
+{{my-addon$namespace::my-component (my-helper 1)}}

transforms/no-implicit-this/helpers/plugin.js

@@ -87,6 +87,16 @@ function doesTokenNeedThis(
     return true;
   }
 
+  // This is to support the ember-holy-futuristic-template-namespacing-batman syntax
+  // as well as support for Nested Invocations in Angle Bracket Syntax
+  // Ref: https://github.com/rwjblue/ember-holy-futuristic-template-namespacing-batman
+  if (token.includes('$')) {
+    token = token.split('$')[1];
+  }
+  if (token.includes('::')) {
+    token = token.replace(/::/g, '/');
+  }
+
   let isComponent = components.find(path => path.endsWith(token));
 
   if (isComponent) {