Clean up validation errors

Author: gitKrystan

transforms/helpers/eo-prop/private/call-expression.ts

@@ -64,7 +64,7 @@ export default class EOCallExpressionProp extends AbstractEOProp<EOPropertyWithC
     }
   }
 
-  private get calleeName(): string {
+  get calleeName(): string {
     return this.calleeObject.callee.name;
   }
 

transforms/helpers/transform.ts

@@ -30,13 +30,13 @@ export default function maybeTransformEmberObjects(
   userOptions: UserOptions
 ): boolean | undefined {
   if (isTestFile(filePath)) {
-    logger.warn(`[${filePath}]: Skipping test file`);
+    logger.warn(`[${filePath}]: SKIPPED: test file`);
     return;
   }
 
   if (userOptions.type && !isFileOfType(filePath, userOptions.type)) {
     logger.warn(
-      `[${filePath}]: FAILURE Type mismatch, expected type '${userOptions.type}' did not match type of file`
+      `[${filePath}]: SKIPPED: Type mismatch, expected type '${userOptions.type}' did not match type of file`
     );
     return;
   }
@@ -46,7 +46,7 @@ export default function maybeTransformEmberObjects(
     : getTelemetryFor(path.resolve(filePath));
   if (!runtimeData || !isRuntimeData(runtimeData)) {
     logger.warn(
-      `[${filePath}]: SKIPPED Could not find runtime data NO_RUNTIME_DATA`
+      `[${filePath}]: SKIPPED: Could not find runtime data NO_RUNTIME_DATA`
     );
     return;
   }
@@ -123,7 +123,7 @@ function _maybeTransformEmberObjects(
       }
 
       if (errors.length > 0) {
-        logger.warn(
+        logger.error(
           `[${filePath}]: FAILURE \nValidation errors: \n\t${errors.join(
             '\n\t'
           )}`

transforms/helpers/validation-helper.ts

@@ -80,19 +80,29 @@ export function hasValidProps(
     }
 
     if (
-      (!decorators &&
-        (instanceProp.hasDecorators ||
-          instanceProp instanceof EOClassDecoratorProp)) ||
-      unsupportedPropNames.includes(instanceProp.name) ||
-      (instanceProp instanceof EOCallExpressionProp &&
-        !instanceProp.hasDecorators)
+      !decorators &&
+      (instanceProp.hasDecorators ||
+        instanceProp instanceof EOClassDecoratorProp ||
+        instanceProp instanceof EOCallExpressionProp)
     ) {
       errors.push(
-        `[${instanceProp.name}]: Transform not supported - need option '--decorators=true' or the property type ${instanceProp.type} can not be transformed`
+        `[${instanceProp.name}]: Transform not supported - need option '--decorators=true'`
+      );
+    }
+
+    if (unsupportedPropNames.includes(instanceProp.name)) {
+      errors.push(
+        `[${instanceProp.name}]: Transform not supported - property with name '${instanceProp.name}' and type ${instanceProp.type} can not be transformed`
       );
     }
 
     if (instanceProp instanceof EOCallExpressionProp) {
+      if (!instanceProp.hasDecorators) {
+        errors.push(
+          `[${instanceProp.name}]: Transform not supported - call to '${instanceProp.calleeName}' can not be transformed`
+        );
+      }
+
       if (instanceProp.hasModifierWithArgs) {
         errors.push(
           `[${instanceProp.name}]: Transform not supported - value has modifiers like 'property' or 'meta'`