Add NO_TELEMETRY config

Author: gitKrystan

.gitignore

@@ -1,3 +1,5 @@
 node_modules
 *.log
 .eslintcache
+transforms/**/*.js
+!transforms/ember-object/__testfixtures__/**/*.js

README.md

@@ -50,6 +50,12 @@ If you have any _lazily loaded_ modules, such as modules from Ember Engines,
 you'll need to make sure that the URL you provide loads these modules as well.
 Otherwise, the codemod will not be able to detect them or analyze them.
 
+To disable this feature, run with `NO_TELEMETRY=true` and omit the path to your local server:
+
+```shell
+NO_TELEMETRY=true npx ember-native-class-codemod [OPTIONS] path/of/files/ or/some**/*glob.js
+```
+
 ### Types
 
 The `type` option can be used to further narrow down transforms to a particular type of

bin/cli.js

@@ -4,11 +4,11 @@
 const { gatherTelemetryForUrl, analyzeEmberObject } = require('ember-codemods-telemetry-helpers');
 
 (async () => {
-  await gatherTelemetryForUrl(process.argv[2], analyzeEmberObject);
+  let args = process.argv.slice(2);
+  if (process.env['NO_TELEMETRY'] !== 'true') {
+    await gatherTelemetryForUrl(process.argv[2], analyzeEmberObject);
+    args = process.argv.slice(1);
+  }
 
-  require('codemod-cli').runTransform(
-    __dirname,
-    'ember-object',
-    process.argv.slice(2) /* paths or globs */
-  );
+  require('codemod-cli').runTransform(__dirname, 'ember-object', args);
 })();

transforms/helpers/config.ts

@@ -22,6 +22,9 @@ export default function getConfig(dir = process.cwd()): UserOptions {
     getFileConfig(dir),
     getCliConfig()
   );
+  if (process.env['NO_TELEMETRY'] === 'true') {
+    config.noTelemetry = true;
+  }
   return UserOptionsSchema.parse(config);
 }
 

transforms/helpers/decorator-info.ts

@@ -1,6 +1,6 @@
-import { assert } from './util/types';
-import { COMPUTED_DECORATOR_NAME, METHOD_DECORATORS } from './util/index';
 import type * as AST from '../helpers/ast';
+import { COMPUTED_DECORATOR_NAME, METHOD_DECORATORS } from './util/index';
+import { assert } from './util/types';
 
 export interface DecoratorImportInfo {
   name: string;

transforms/helpers/eo-prop/private/abstract.ts

@@ -36,7 +36,7 @@ export default abstract class AbstractEOProp<
 
   protected decorators: DecoratorImportInfo[] = [];
 
-  protected readonly runtimeData: RuntimeData;
+  protected readonly runtimeData: RuntimeData | null;
 
   /**
    * Override to `true` if the property type supports object literal decorators
@@ -55,7 +55,7 @@ export default abstract class AbstractEOProp<
     protected readonly options: Options
   ) {
     this.runtimeData = options.runtimeData;
-    if (this.runtimeData.type) {
+    if (this.runtimeData) {
       const { offProperties, unobservedProperties } = this.runtimeData;
 
       const unobservedArgs = unobservedProperties[this.name];
@@ -163,15 +163,15 @@ export default abstract class AbstractEOProp<
   }
 
   protected get isOverridden(): boolean {
-    return this.runtimeData.overriddenProperties.includes(this.name);
+    return this.runtimeData?.overriddenProperties.includes(this.name) ?? false;
   }
 
   protected get replaceSuperWithUndefined(): boolean {
     return this.hasRuntimeData && !this.isOverridden;
   }
 
   private get hasRuntimeData(): boolean {
-    return !!this.runtimeData.type;
+    return this.runtimeData !== null;
   }
 
   protected get hasDecorators(): boolean {

transforms/helpers/eo-prop/private/actions/method.ts

@@ -87,6 +87,6 @@ export default class EOActionMethod extends EOMethod implements Action {
   }
 
   protected override get isOverridden(): boolean {
-    return this.runtimeData.overriddenActions.includes(this.name);
+    return this.runtimeData?.overriddenActions.includes(this.name) ?? false;
   }
 }

transforms/helpers/eo-prop/private/computed/index.ts

@@ -99,7 +99,7 @@ function getDecorators(
   const decoratorImportInfo = existingDecoratorImportInfos.get(calleeName);
   if (decoratorImportInfo) {
     decorators.push(decoratorImportInfo);
-  } else if (options.runtimeData.computedProperties.includes(raw.key.name)) {
+  } else if (options.runtimeData?.computedProperties.includes(raw.key.name)) {
     decorators.push({ name: calleeName });
   }
   return decorators;

transforms/helpers/options.ts

@@ -97,6 +97,9 @@ export const UserOptionsSchema = z.object({
   ignoreLeakingState: StringArraySchema.describe(
     'Allow-list for ObjectExpression or ArrayExpression properties to ignore issues detailed in eslint-plugin-ember/avoid-leaking-state-in-ember-objects.'
   ),
+  noTelemetry: StringBooleanSchema.describe(
+    'Disable telemetry. Enabled by default.'
+  ),
   type: TypeSchema.describe(
     'Apply transformation to only passed type.'
   ).optional(),
@@ -145,7 +148,7 @@ function logConfigError(
 
 interface PrivateOptions {
   /** @private */
-  runtimeData: RuntimeData;
+  runtimeData: RuntimeData | null;
 }
 
 export type Options = UserOptions & PrivateOptions;
@@ -156,6 +159,7 @@ export const DEFAULT_OPTIONS: UserOptions = {
   classicDecorator: true,
   quote: 'single',
   ignoreLeakingState: ['queryParams'],
+  noTelemetry: false,
 };
 
 class ConfigError extends Error {

transforms/helpers/runtime-data.ts

@@ -18,16 +18,16 @@ export type RuntimeData = z.infer<typeof RuntimeDataSchema>;
  * Gets telemetry data for the file and parses it into a valid `RuntimeData`
  * object.
  */
-export function getRuntimeData(filePath: string): RuntimeData {
-  let rawTelemetry = getTelemetryFor(path.resolve(filePath));
+export function getRuntimeData(filePath: string): RuntimeData | null {
+  const rawTelemetry = getTelemetryFor(path.resolve(filePath));
   if (!rawTelemetry) {
     // Do not re-throw. The most likely reason this happened was because
     // the user's app threw an error. We still want the codemod to work if so.
     logger.error({
       filePath,
       error: new RuntimeDataError('Could not find runtime data'),
     });
-    rawTelemetry = {};
+    return null;
   }
 
   const result = RuntimeDataSchema.safeParse(rawTelemetry);