Fixes discovered during dogfooding

Author: gitKrystan

package.json

@@ -31,6 +31,8 @@
   ],
   "scripts": {
     "release": "release-it",
+    "prepare": "yarn build",
+    "postpublish": "yarn clean",
     "build": "tsc",
     "clean": "tsc --build --clean",
     "fixme": "yarn build; codemod-cli test && node ./test/run-test.js && git checkout test/fixtures; yarn clean",
@@ -60,7 +62,7 @@
     "@babel/core": "^7.20.12",
     "@babel/eslint-parser": "^7.19.1",
     "@babel/preset-env": "^7.20.2",
-    "@tsconfig/node-lts-strictest": "^18.12.1",
+    "@tsconfig/node12": "^1.0.11",
     "@types/jscodeshift": "^0.11.6",
     "@typescript-eslint/eslint-plugin": "^5.48.1",
     "@typescript-eslint/parser": "^5.48.1",
@@ -79,7 +81,7 @@
     "typescript": "^4.9.4"
   },
   "engines": {
-    "node": "10.* || 12.* || >= 14"
+    "node": "12.* || >= 14"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"

transforms/helpers/ast.ts

@@ -1,6 +1,7 @@
 /* eslint-disable @typescript-eslint/no-empty-interface, jsdoc/require-jsdoc */
 
 import type { Type } from 'ast-types/lib/types';
+import type { ExpressionKind } from 'ast-types/gen/kinds';
 import type {
   ASTNode,
   ArrayExpression,
@@ -283,12 +284,7 @@ export function isEOIdentifierAction(u: unknown): u is EOIdentifierAction {
 }
 
 export interface EOPropertySimple extends EOProperty {
-  value:
-    | ArrayExpression
-    | Identifier
-    | Literal
-    | MemberExpression
-    | ObjectExpression;
+  value: ExpressionKind; // UNSAFE: We don't check this anywhere
 }
 
 interface EOActionInfiniteCall extends CallExpression {

transforms/helpers/eo-prop/private/call-expression.ts

@@ -43,9 +43,9 @@ export default class EOCallExpressionProp extends AbstractEOProp<EOPropertyWithC
     const modifiers = [getModifier(calleeObject)];
     while (
       'callee' in calleeObject &&
-      calleeObject.callee.type === 'MemberExpression'
+      calleeObject.callee.type === 'MemberExpression' &&
+      calleeObject.callee.object.type === 'CallExpression'
     ) {
-      assert(calleeObject.callee.object.type === 'CallExpression');
       calleeObject = calleeObject.callee.object;
       modifiers.push(getModifier(calleeObject));
     }

tsconfig.json

@@ -1,12 +1,26 @@
 {
-  "extends": "@tsconfig/node-lts-strictest/tsconfig.json",
+  "extends": "@tsconfig/node12/tsconfig.json",
   "compilerOptions": {
     "paths": {
       "*": ["./types/*"]
     },
     "checkJs": false,
     "noEmitOnError": false,
-    "skipLibCheck": true
+    "skipLibCheck": false,
+
+    "strict": true,
+    "forceConsistentCasingInFileNames": true,
+    "allowUnusedLabels": false,
+    "allowUnreachableCode": false,
+    "exactOptionalPropertyTypes": true,
+    "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
+    "noImplicitReturns": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noUncheckedIndexedAccess": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "importsNotUsedAsValues": "error"
   },
   "include": ["transforms/**/*"],
   "exclude": ["transforms/ember-object/__testfixtures__/**/*"]

yarn.lock

@@ -1526,10 +1526,10 @@
   resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-1.1.2.tgz#ccb91445360179a04e7fe6aff78c00ffc1eeaf82"
   integrity sha512-RbzJvlNzmRq5c3O09UipeuXno4tA1FE6ikOjxZK0tuxVv3412l64l5t1W5pj4+rJq9vpkm/kwiR07aZXnsKPxw==
 
-"@tsconfig/node-lts-strictest@^18.12.1":
-  version "18.12.1"
-  resolved "https://registry.yarnpkg.com/@tsconfig/node-lts-strictest/-/node-lts-strictest-18.12.1.tgz#9d574cc30c5d90e4b4517b4b3833ba9ca2897c51"
-  integrity sha512-pn6cefRFlBVSEo5lO82bJnGmaptr90Wu8zCROkMUYXEz0f4AgCD65Guhq4u3PIuIlsYImaOmdoiHajx1gVTiQw==
+"@tsconfig/node12@^1.0.11":
+  version "1.0.11"
+  resolved "https://registry.yarnpkg.com/@tsconfig/node12/-/node12-1.0.11.tgz#ee3def1f27d9ed66dac6e46a295cffb0152e058d"
+  integrity sha512-cqefuRsh12pWyGsIoBKJA9luFu3mRxCA+ORZvA4ktLSzIuCUtWVxGIuXigEwO5/ywWFMZ2QEGKWvkZG1zDMTag==
 
 "@types/babel__core@^7.0.0", "@types/babel__core@^7.1.14":
   version "7.1.14"