Skip to content

Commit 1aa2f08

Browse files
committed
Clean up FIXMEs
1 parent d3fa91a commit 1aa2f08

3 files changed

Lines changed: 17 additions & 7 deletions

File tree

.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ module.exports = {
3737
'unicorn/consistent-destructuring': 'off',
3838
'unicorn/consistent-function-scoping': ['error', { checkArrowFunctions: false }],
3939
'unicorn/custom-error-definition': 'error',
40-
'unicorn/filename-case': ['error', { case: 'kebabCase' }],
40+
'unicorn/filename-case': 'off',
4141
'unicorn/no-array-callback-reference': 'off',
4242
'unicorn/no-array-method-this-argument': 'off', // False positives
4343
'unicorn/no-null': 'off',

transforms/ember-object/test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
1-
import { describe, expect, test, beforeEach, afterEach } from '@jest/globals';
1+
import { afterEach, beforeEach, describe, expect, test } from '@jest/globals';
22
import { setTelemetry } from 'ember-codemods-telemetry-helpers';
33
import { globSync } from 'glob';
4-
// @ts-expect-error FIXME
54
import { applyTransform } from 'jscodeshift/dist/testUtils';
65
import { existsSync, readFileSync } from 'node:fs';
76
import path from 'node:path';
87
import transform, { parser } from '../ember-object/index';
9-
import mockTelemetryData from './__testfixtures__/-mock-telemetry.json';
108
import { assert } from '../helpers/util/types';
9+
import mockTelemetryData from './__testfixtures__/-mock-telemetry.json';
1110

1211
const fixtureDir = 'transforms/ember-object/__testfixtures__/';
1312
const testFiles = globSync(`${fixtureDir}**/*.input.js`);
@@ -120,9 +119,10 @@ function runTest(
120119
}
121120
}
122121

123-
function runTransform(input: string, testPath: string): string {
124-
// FIXME
125-
// eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-call
122+
function runTransform(
123+
input: string,
124+
testPath: string
125+
): string | null | undefined {
126126
return applyTransform(
127127
transform,
128128
// NOTE: This version of options unused in the transform
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
import type { FileInfo, Options, Parser, Transform } from 'jscodeshift';
2+
3+
declare module 'jscodeshift/dist/testUtils' {
4+
export function applyTransform(
5+
transform: Transform,
6+
transformOptions: Options,
7+
fileInfo: FileInfo,
8+
testOptions?: { parser: Parser }
9+
): string | null | undefined;
10+
}

0 commit comments

Comments
 (0)