Always pass through object literal decorators on methods

Author: gitKrystan

transforms/ember-object/__testfixtures__/object-literal-with-decorators-invalid.input.js

@@ -12,3 +12,8 @@ const Foo2 = EmberObject.extend({
 const Foo3 = EmberObject.extend({
   @tracked arr: [1, 2, 3],
 });
+
+// Do not function expression if not on allowlist
+const Foo4 = EmberObject.extend({
+  @userAdded methodish: () => {},
+});

transforms/ember-object/__testfixtures__/object-literal-with-decorators-invalid.output.js

@@ -11,4 +11,9 @@ const Foo2 = EmberObject.extend({
 // Do not transform array
 const Foo3 = EmberObject.extend({
   @tracked arr: [1, 2, 3],
+});
+
+// Do not function expression if not on allowlist
+const Foo4 = EmberObject.extend({
+  @userAdded methodish: () => {},
 });

transforms/ember-object/__testfixtures__/object-literal-with-decorators.input.js

@@ -97,4 +97,9 @@ const Foo = EmberObject.extend({
   bar() {
     // Executes whenever barEvent is emitted
   },
+
+  @userAdded
+  yolo() {
+    // methods always pass through decorators, even if not on allow-list
+  }
 });

transforms/ember-object/__testfixtures__/object-literal-with-decorators.output.js

@@ -157,4 +157,9 @@ class Foo extends EmberObject {
   bar() {
     // Executes whenever barEvent is emitted
   }
+
+  @userAdded
+  yolo() {
+    // methods always pass through decorators, even if not on allow-list
+  }
 }

transforms/ember-object/__testfixtures__/options/object-literal-decorators.input.js

@@ -2,7 +2,5 @@ import EmberObject from '@ember/object';
 
 const Foo = EmberObject.extend({
   @userAdded
-  toggleShowing() {
-    set(this, 'isShowing', !this.isShowing);
-  }
+  whatever: undefined
 });

transforms/ember-object/__testfixtures__/options/object-literal-decorators.output.js

@@ -4,7 +4,5 @@ import EmberObject from '@ember/object';
 @classic
 class Foo extends EmberObject {
   @userAdded
-  toggleShowing() {
-    set(this, 'isShowing', !this.isShowing);
-  }
+  whatever;
 }

transforms/helpers/eo-prop/private/abstract.ts

@@ -38,8 +38,14 @@ export default abstract class AbstractEOProp<
 
   protected readonly runtimeData: RuntimeData;
 
-  /** Override to `true` if the property type supports object literal decorators. */
-  protected readonly supportsObjectLiteralDecorators: boolean = false;
+  /**
+   * Override to `true` if the property type supports object literal decorators
+   * or to `'withVerification'` if the property type supports object literal
+   * decorators as long as they are on the allow-list.
+   */
+  protected readonly objectLiteralDecoratorSupport:
+    | boolean
+    | 'withVerification' = false;
 
   constructor(
     protected readonly rawProp: P & {
@@ -95,7 +101,7 @@ export default abstract class AbstractEOProp<
     const { decorators, objectLiteralDecorators } = this.options;
 
     if (this.existingDecorators) {
-      if (!this.supportsObjectLiteralDecorators) {
+      if (!this.objectLiteralDecoratorSupport) {
         errors.push(
           this.makeError(
             'can only transform object literal decorators on methods or properties with literal values (string, number, boolean, null, undefined)'
@@ -116,12 +122,12 @@ export default abstract class AbstractEOProp<
             this.makeError('decorator expression type not supported')
           );
         } else if (
-          // TODO: Don't check this for EOMethodProp
+          this.objectLiteralDecoratorSupport === 'withVerification' &&
           !allowObjectLiteralDecorator(decoratorName, objectLiteralDecorators)
         ) {
           errors.push(
             this.makeError(
-              "decorator '@${decoratorName}' not included in ALLOWED_OBJECT_LITERAL_DECORATORS or option '--objectLiteralDecorators'"
+              `decorator '@${decoratorName}' not included in ALLOWED_OBJECT_LITERAL_DECORATORS or option '--objectLiteralDecorators'`
             )
           );
         }

transforms/helpers/eo-prop/private/function-expression.ts

@@ -39,7 +39,8 @@ export default class EOFunctionExpressionProp extends AbstractEOProp<
 
   protected readonly value = this.rawProp.value;
 
-  protected override readonly supportsObjectLiteralDecorators = true;
+  protected override readonly objectLiteralDecoratorSupport =
+    'withVerification' as const;
 
   build(): AST.ClassMethod {
     return replaceMethodSuperExpressions(

transforms/helpers/eo-prop/private/method.ts

@@ -43,7 +43,7 @@ export default class EOMethod extends AbstractEOProp<
 
   protected readonly value = this.rawProp;
 
-  protected override readonly supportsObjectLiteralDecorators = true;
+  protected override readonly objectLiteralDecoratorSupport = true;
 
   build(): AST.ClassMethod {
     return replaceMethodSuperExpressions(

transforms/helpers/eo-prop/private/simple.ts

@@ -45,7 +45,8 @@ export default class EOSimpleProp extends AbstractEOProp<
 
   protected readonly value = this.rawProp.value;
 
-  protected override readonly supportsObjectLiteralDecorators = true;
+  protected override readonly objectLiteralDecoratorSupport =
+    'withVerification' as const;
 
   build(): AST.ClassProperty {
     const classProp = j.classProperty.from({