Merge pull request #67 from kellyselden/not-ember-app-test

add test for not an ember app

Author: Kelly Selden

__tests__/bin-test.js

@@ -5,38 +5,74 @@ const fs = require('fs-extra');
 const cp = require('child_process');
 const tmp = require('tmp');
 
+const inputFile = path.join(process.cwd(), '__testfixtures__/final-boss.input.js');
+const outputFile = path.join(process.cwd(), '__testfixtures__/final-boss.output.js');
+
 describe('bin acceptance', function() {
   let tmpPath;
+  let tmpFile;
+  let tmpPackageJson;
 
   beforeEach(function() {
     tmpPath = tmp.dirSync().name;
 
-    fs.ensureDirSync(path.join(tmpPath, 'app'));
+    tmpPackageJson = path.join(tmpPath, 'package.json');
 
-    fs.writeJsonSync(path.join(tmpPath, 'package.json'), {
-      devDependencies: {
-        'ember-cli': ''
-      }
-    });
-  });
+    fs.ensureDirSync(path.join(tmpPath, 'app'));
 
-  it('works', function() {
-    let inputFile = path.join(process.cwd(), '__testfixtures__/final-boss.input.js');
-    let outputFile = path.join(process.cwd(), '__testfixtures__/final-boss.output.js');
-    let tmpFile = path.join(tmpPath, 'app/final-boss.js');
+    tmpFile = path.join(tmpPath, 'app/final-boss.js');
 
     fs.copySync(
       path.join(process.cwd(), '__testfixtures__/final-boss.input.js'),
       tmpFile
     );
+  });
+
+  it('handles non-ember projects', function() {
+    let stderr = '';
+    let exitCode;
+
+    return new Promise(resolve => {
+      let ps = cp.spawn('node', [
+        path.join(process.cwd(), 'bin/ember-modules-codemod')
+      ], {
+        cwd: tmpPath
+      });
 
-    cp.spawnSync('node', [
-      path.join(process.cwd(), 'bin/ember-modules-codemod')
-    ], {
-      cwd: tmpPath,
-      stdio: 'inherit'
+      ps.stderr.on('data', data => {
+        stderr += data.toString();
+      });
+
+      ps.on('exit', (code, signal) => {
+        exitCode = code;
+
+        resolve();
+      });
+    }).then(() => {
+      expect(exitCode).not.toEqual(0);
+
+      expect(stderr).toEqual(`It doesn't look like you're inside an Ember app. I couldn't find a package.json at ${tmpPackageJson}\n`);
+    });
+  });
+
+  describe('with valid package.json', function() {
+    beforeEach(function() {
+      fs.writeJsonSync(tmpPackageJson, {
+        devDependencies: {
+          'ember-cli': ''
+        }
+      });
     });
 
-    expect(fs.readFileSync(tmpFile, 'utf8')).toEqual(fs.readFileSync(outputFile, 'utf8'));
+    it('works', function() {
+      cp.spawnSync('node', [
+        path.join(process.cwd(), 'bin/ember-modules-codemod')
+      ], {
+        cwd: tmpPath,
+        stdio: 'inherit'
+      });
+
+      expect(fs.readFileSync(tmpFile, 'utf8')).toEqual(fs.readFileSync(outputFile, 'utf8'));
+    });
   });
 });

bin/ember-modules-codemod.js

@@ -8,7 +8,7 @@ const path = require("path");
 const glob = require("glob");
 
 let cwd = process.cwd();
-let pkgPath = cwd + "/package.json";
+let pkgPath = path.join(cwd, 'package.json');
 
 try {
   let pkg = JSON.parse(fs.readFileSync(pkgPath));