use ember serve instead of yarn start

Author: Suchita Doshi

lib/gather/gather-single-telemetry.test.js

@@ -54,8 +54,6 @@ describe('Gather single telemetry', () => {
 
   afterAll(async () => {
     console.log(`Killing PID: ${app.emberServe.pid}`);
-    await app.emberServe.kill('SIGTERM', {
-      forceKillAfterTimeout: 200,
-    });
+    await app.emberServe.shutdown();
   }, APP_TIMEOUT);
 });

lib/gather/gather-telemetry.test.js

@@ -69,8 +69,6 @@ describe('Provide a personalized `Gathering Function`', () => {
 
   afterAll(async () => {
     console.log(`Killing PID: ${app.emberServe.pid}`);
-    await app.emberServe.kill('SIGTERM', {
-      forceKillAfterTimeout: 200,
-    });
+    await app.emberServe.shutdown();
   }, APP_TIMEOUT);
 });

test/helpers/start-app.js

@@ -3,14 +3,14 @@ const path = require('path');
 
 module.exports = async function startApp(appPath) {
   const classicAppDir = path.resolve(appPath);
-  const execOpts = { cwd: classicAppDir, stderr: 'inherit' };
+  const execOpts = { cwd: classicAppDir, stderr: 'inherit', preferLocal: true };
   console.log('installing deps');
 
   await execa('rm', ['-rf', 'node_modules'], execOpts);
   await execa('yarn', ['install'], execOpts);
 
   console.log('starting serve');
-  const emberServe = execa('yarn', ['start'], execOpts);
+  const emberServe = execa('ember', ['serve'], execOpts);
   emberServe.stdout.pipe(process.stdout);
 
   await new Promise(resolve => {
@@ -22,5 +22,17 @@ module.exports = async function startApp(appPath) {
     });
   });
 
+  emberServe.shutdown = async function() {
+    this.kill();
+    try {
+      await this;
+    } catch (e) {
+      // Process is allowed to exit with a non zero exit status code.
+    }
+    if (!this.killed) {
+      throw new Error(`the process ${this.pid} wasn't killed.`);
+    }
+  };
+
   return { emberServe };
 };