Skip to content

Commit e37a93b

Browse files
committed
Use named functions instead of const arrow functions
1 parent e0969a0 commit e37a93b

1 file changed

Lines changed: 39 additions & 38 deletions

File tree

transforms/angle-brackets/index.js

Lines changed: 39 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -149,28 +149,28 @@ const IGNORE_MUSTACHE_STATEMENTS = [
149149
'app-version',
150150
];
151151

152-
const isAttribute = key => {
152+
function isAttribute(key) {
153153
return HTML_ATTRIBUTES.includes(key) || key.startsWith('data-');
154-
};
154+
}
155155

156-
const isNestedComponentTagName = tagName => {
156+
function isNestedComponentTagName(tagName) {
157157
return tagName && tagName.includes && (tagName.includes('/') || tagName.includes('-'));
158-
};
158+
}
159159

160160
/**
161161
* Returns a capitalized tagname for angle brackets syntax
162162
* {{my-component}} => MyComponent
163163
*/
164-
const capitalizedTagName = tagname => {
164+
function capitalizedTagName(tagname) {
165165
return tagname
166166
.split('-')
167167
.map(s => {
168168
return s[0].toUpperCase() + s.slice(1);
169169
})
170170
.join('');
171-
};
171+
}
172172

173-
const transformTagName = tagName => {
173+
function transformTagName(tagName) {
174174
if (tagName.includes('.')) {
175175
return tagName;
176176
}
@@ -180,14 +180,14 @@ const transformTagName = tagName => {
180180
}
181181

182182
return capitalizedTagName(tagName);
183-
};
183+
}
184184

185-
const transformNestedTagName = tagName => {
185+
function transformNestedTagName(tagName) {
186186
const paths = tagName.split('/');
187187
return paths.map(name => capitalizedTagName(name)).join('::');
188-
};
188+
}
189189

190-
const transformNestedSubExpression = subExpression => {
190+
function transformNestedSubExpression(subExpression) {
191191
let positionalArgs = subExpression.params.map(param => {
192192
if (param.type === 'SubExpression') {
193193
return transformNestedSubExpression(param);
@@ -215,9 +215,9 @@ const transformNestedSubExpression = subExpression => {
215215

216216
let args = positionalArgs.concat(namedArgs);
217217
return `(${subExpression.path.original} ${args.join(' ')})`;
218-
};
218+
}
219219

220-
const shouldSkipFile = (fileInfo, config) => {
220+
function shouldSkipFile(fileInfo, config) {
221221
let source = fileInfo.source;
222222

223223
if (source.includes('~')) {
@@ -236,7 +236,7 @@ const shouldSkipFile = (fileInfo, config) => {
236236
}
237237

238238
return false;
239-
};
239+
}
240240

241241
function transform(fileInfo, config) {
242242
if (shouldSkipFile(fileInfo, config)) {
@@ -247,12 +247,13 @@ function transform(fileInfo, config) {
247247
mode: 'codemod',
248248
parseOptions: { ignoreStandalone: true },
249249
});
250+
250251
const b = glimmer.builders;
251252

252253
/**
253254
* Transform the attributes names & values properly
254255
*/
255-
const transformAttrs = attrs => {
256+
function transformAttrs(attrs) {
256257
return attrs.map(a => {
257258
let _key = a.key;
258259
let _valueType = a.value.type;
@@ -299,26 +300,26 @@ function transform(fileInfo, config) {
299300

300301
return b.attr(_key, _value);
301302
});
302-
};
303+
}
303304

304-
const isQueryParam = param => {
305+
function isQueryParam(param) {
305306
return (
306307
param &&
307308
param.type === 'SubExpression' &&
308309
param.path &&
309310
param.path.original === 'query-params'
310311
);
311-
};
312+
}
312313

313-
const transformLinkToTextParam = textParam => {
314+
function transformLinkToTextParam(textParam) {
314315
if (textParam.type.includes('Literal')) {
315316
return b.text(textParam.value);
316317
} else {
317318
return b.mustache(textParam.original);
318319
}
319-
};
320+
}
320321

321-
const transformModelParams = modelParam => {
322+
function transformModelParams(modelParam) {
322323
let type = modelParam.type;
323324
if (type === 'StringLiteral') {
324325
return b.text(modelParam.value);
@@ -327,9 +328,9 @@ function transform(fileInfo, config) {
327328
} else {
328329
return b.mustache(modelParam.original);
329330
}
330-
};
331+
}
331332

332-
const transformLinkToAttrs = params => {
333+
function transformLinkToAttrs(params) {
333334
let attributes = [];
334335
let dataAttributes = getDataAttributesFromParams(params);
335336
params = getNonDataAttributesFromParams(params);
@@ -380,36 +381,36 @@ function transform(fileInfo, config) {
380381
}
381382

382383
return attributes.concat(dataAttributes);
383-
};
384+
}
384385

385-
const tranformValuelessDataParams = params => {
386+
function tranformValuelessDataParams(params) {
386387
let dataAttributes = getDataAttributesFromParams(params);
387388
let valuelessDataAttributes = dataAttributes.map(param =>
388389
b.attr(param.parts[0], b.text(_EMPTY_STRING_))
389390
);
390391
return valuelessDataAttributes;
391-
};
392+
}
392393

393-
const transformNodeAttributes = node => {
394+
function transformNodeAttributes(node) {
394395
let params = tranformValuelessDataParams(node.params);
395396
let attributes = transformAttrs(node.hash.pairs);
396397

397398
return params.concat(attributes);
398-
};
399+
}
399400

400-
const getDataAttributesFromParams = params => {
401+
function getDataAttributesFromParams(params) {
401402
return params.filter(param => param.original && `${param.original}`.startsWith('data-'));
402-
};
403+
}
403404

404-
const getNonDataAttributesFromParams = params => {
405+
function getNonDataAttributesFromParams(params) {
405406
return params.filter(p => !(p.original && `${p.original}`.startsWith('data-')));
406-
};
407+
}
407408

408-
const shouldIgnoreMustacheStatement = name => {
409+
function shouldIgnoreMustacheStatement(name) {
409410
return IGNORE_MUSTACHE_STATEMENTS.includes(name) || config.helpers.includes(name);
410-
};
411+
}
411412

412-
const nodeHasPositionalParameters = node => {
413+
function nodeHasPositionalParameters(node) {
413414
if (node.params.length > 0) {
414415
let firstParamType = node.params[0].type;
415416

@@ -423,9 +424,9 @@ function transform(fileInfo, config) {
423424
}
424425

425426
return false;
426-
};
427+
}
427428

428-
const transformNode = node => {
429+
function transformNode(node) {
429430
const tagName = node.path.original;
430431

431432
if (config.skipBuiltInComponents && BUILT_IN_COMPONENTS.includes(tagName)) {
@@ -467,7 +468,7 @@ function transform(fileInfo, config) {
467468
children,
468469
blockParams,
469470
});
470-
};
471+
}
471472

472473
glimmer.traverse(ast, {
473474
MustacheStatement(node) {

0 commit comments

Comments
 (0)