Use telemetry data to detect known components and helpers (#154)

* first pass

* intergration test

* update readme for usage

* PR fixes

* dog fooding

* improve test converage

* re-enable debug

* fix tests

* more tests

* rename tests

* add attr node bailout

* coerce boolean and numbers to string

* define isWallStreet

* improve test coverage

* revert failing test

* regex

* update ember-codemods-telemetry-helpers

Author: tylerturdenpants

.eslintignore

@@ -1 +1,2 @@
-**/__testfixtures__/**/*.*
+**/__testfixtures__/**/*.js
+**/fixtures/**

.eslintrc.js

@@ -13,7 +13,7 @@ module.exports = {
     "prettier/prettier": "error"
   },
   overrides: [{
-    files: ['**/test.js'],
+    files: ['**/test.js', '**/*.test.js'],
     env: {
       jest: true
     }

.gitignore

@@ -62,3 +62,9 @@ typings/
 
 #editors
 .vscode
+
+
+tmp
+*.log
+test/**/yarn.lock
+-mock-telemetry.json

.travis.yml

@@ -8,6 +8,7 @@ cache: yarn
 script:
   - yarn lint
   - yarn test
+  - yarn test:integration
 
 after_success:
 - yarn coveralls

README.md

@@ -1,7 +1,7 @@
 # ember-angle-brackets-codemod
 
 [![Ember Observer Score](https://emberobserver.com/badges/ember-angle-brackets-codemod.svg)](https://emberobserver.com/addons/ember-angle-brackets-codemod)
-[![Build Status](https://travis-ci.org/ember-codemods/ember-angle-brackets-codemod.svg?branch=master)](https://travis-ci.org/ember-codemods/ember-angle-brackets-codemod) 
+[![Build Status](https://travis-ci.org/ember-codemods/ember-angle-brackets-codemod.svg?branch=master)](https://travis-ci.org/ember-codemods/ember-angle-brackets-codemod)
 [![Coverage Status](https://coveralls.io/repos/github/ember-codemods/ember-angle-brackets-codemod/badge.svg?branch=master)](https://coveralls.io/github/ember-codemods/ember-angle-brackets-codemod?branch=master)
 [![npm version](http://img.shields.io/npm/v/ember-angle-brackets-codemod.svg?style=flat)](https://npmjs.org/package/ember-angle-brackets-codemod "View this project on npm")
 [![dependencies Status](https://david-dm.org/ember-codemods/ember-angle-brackets-codemod/status.svg)](https://david-dm.org/ember-codemods/ember-angle-brackets-codemod)
@@ -12,16 +12,18 @@ in an Ember.js app
 
 Refer to this [RFC](https://github.com/emberjs/rfcs/blob/master/text/0311-angle-bracket-invocation.md) for more details on Angle brackets invocation syntax.
 
-## Usage 
+## Usage
 
 **WARNING**: `jscodeshift`, and thus this codemod, **edits your files in place**.
 It does not make a copy. Make sure your code is checked into a source control
 repository like Git and that you have no outstanding changes to commit before
 running this tool.
 
+1. Start your ember development server
+2. Run Codemod, pointing it at the address of the development server
 ```sh
 $ cd my-ember-app-or-addon
-$ npx ember-angle-brackets-codemod angle-brackets app/templates
+$ npx ember-angle-brackets-codemod http://localhost:4200 path/of/files/ or /some**/*glob.hbs
 ```
 
 ## From
@@ -62,7 +64,7 @@ To help the codemod disambiguate components and helpers, you can define a list o
 ```js
 {
   "helpers": [
-    "date-formatter", 
+    "date-formatter",
     "info-pill"
   ]
 }
@@ -115,7 +117,7 @@ If there are files that don't convert well, you can skip them by specifying an o
 
 ## Debugging Workflow
 Oftentimes, you want to debug the codemod or the transform to identify issues with the code or to understand
-how the transforms are working, or to troubleshoot why some tests are failing. 
+how the transforms are working, or to troubleshoot why some tests are failing.
 
 Hence we recommend a debugging work-flow like below to quickly find out what is causing the issue.
 
@@ -134,11 +136,11 @@ const params = a.value.params.map(p => {
 ### 2. Inspect the process with node debug
 Here we are going to start the tests selectively in node debug mode. Since the
 codemod is bootstrapped using [codemod-cli](https://github.com/rwjblue/codemod-cli) which is using [jest](https://jestjs.io/) in turn
-to run the tests, jest is having an option `-t <name-of-spec>` to run a particular 
+to run the tests, jest is having an option `-t <name-of-spec>` to run a particular
 set of tests instead of running the whole test suite.
 
 We are making use of both these features to start our tests in this particular fashion.
-For more details on node debug, visit the [official](https://nodejs.org/en/docs/guides/debugging-getting-started/) 
+For more details on node debug, visit the [official](https://nodejs.org/en/docs/guides/debugging-getting-started/)
 Node.js debugging guide, and for jest documentation on tests, please refer [here](https://jestjs.io/docs/en/cli).
 
 ```sh

bin/cli.js

@@ -1,9 +1,14 @@
 #!/usr/bin/env node
 'use strict';
+const { gatherTelemetryForUrl, analyzeEmberObject } = require('ember-codemods-telemetry-helpers');
 
-require('codemod-cli').runTransform(
-  __dirname,
-  process.argv[2] /* transform name */,
-  process.argv.slice(3) /* paths or globs */,
-  'hbs'
-);
+(async () => {
+  await gatherTelemetryForUrl(process.argv[2], analyzeEmberObject);
+
+  require('codemod-cli').runTransform(
+    __dirname,
+    'angle-brackets' /* transform name */,
+    process.argv.slice(2) /* paths or globs */,
+    'hbs'
+  );
+})();

package.json

@@ -21,8 +21,10 @@
   "bin": "./bin/cli.js",
   "scripts": {
     "coveralls": "cat ./coverage/lcov.info | node node_modules/.bin/coveralls",
+    "debug:integration": "node --inspect-brk ./test/run-test.js",
     "deploy": "npm version patch && git push && git push --tags && npm publish",
     "lint": "eslint . --cache",
+    "test:integration": "node ./test/run-test.js",
     "test": "codemod-cli test --coverage"
   },
   "jest": {
@@ -31,18 +33,21 @@
     ]
   },
   "dependencies": {
-    "codemod-cli": "^2.0.0",
+    "codemod-cli": "^2.1.0",
+    "ember-codemods-telemetry-helpers": "^1.1.0",
     "ember-template-recast": "^3.2.8",
-    "winston": "^3.2.1"
+    "winston": "^3.2.1",
+    "debug": "^4.1.1"
   },
   "devDependencies": {
     "coveralls": "^3.0.7",
     "eslint": "^6.6.0",
     "eslint-config-prettier": "^6.7.0",
     "eslint-plugin-prettier": "^3.1.1",
+    "execa": "^3.3.0",
     "jest": "^24.9.0",
     "prettier": "^1.19.1",
-    "release-it": "^12.2.1",
+    "release-it": "^12.4.3",
     "release-it-lerna-changelog": "^1.0.3"
   },
   "engines": {

test/fixtures/input/.editorconfig

@@ -0,0 +1,20 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+
+[*]
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+indent_style = space
+indent_size = 2
+
+[*.hbs]
+insert_final_newline = false
+
+[*.{diff,md}]
+trim_trailing_whitespace = false

test/fixtures/input/.ember-cli

@@ -0,0 +1,9 @@
+{
+  /**
+    Ember CLI sends analytics information by default. The data is completely
+    anonymous, but there are times when you might want to disable this behavior.
+
+    Setting `disableAnalytics` to true will prevent any data from being sent.
+  */
+  "disableAnalytics": false
+}

test/fixtures/input/.eslintignore

@@ -0,0 +1,16 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+
+# misc
+/coverage/
+
+# ember-try
+/.node_modules.ember-try/