Fix issues when converting dasherized curly component invocation into angle bracket invocation (#183)

* Fix issues when converting dasherized curly component invocation into angle bracket invocation

* remove stale console

* fix indents

* fix prettier

* refactor to remove the need of transformNestedTagName function

* unify capitalizedT

Author: suchitadoshi1987

transforms/angle-brackets/test.js

@@ -1023,3 +1023,23 @@ test('hyphens with nested usage', () => {
       "
   `);
 });
+
+test('wallstreet.hbs', () => {
+  let input = `
+    {{#foo-bar$baz-bang/foo-bar::bang}}
+      <div ...attributes>
+        {{foo bar="baz"}}
+      </div>
+    {{/foo-bar$baz-bang/foo-bar::bang}}
+  `;
+
+  expect(runTest('wallstreet.hbs', input)).toMatchInlineSnapshot(`
+    "
+        <FooBar$BazBang::FooBar::Bang>
+          <div ...attributes>
+            <Foo @bar=\\"baz\\" />
+          </div>
+        </FooBar$BazBang::FooBar::Bang>
+      "
+  `);
+});

transforms/angle-brackets/transform.js

@@ -28,34 +28,31 @@ function isNestedComponentTagName(tagName) {
 }
 
 /**
- *  Returns a capitalized tagname for angle brackets syntax
+ *  Returns a transformed capitalized tagname for angle brackets syntax
  *  {{my-component}} => MyComponent
  */
-function capitalizedTagName(tagname) {
-  return tagname
-    .split('-')
-    .map(s => {
-      if (!s) return '-';
-      return s[0].toUpperCase() + s.slice(1);
-    })
-    .join('');
-}
-
 function transformTagName(tagName) {
+  const SIMPLE_DASHERIZE_REGEXP = /[a-z]|\/|-/g;
+  const ALPHA = /[A-Za-z0-9]/;
+
   if (tagName.includes('.')) {
     return tagName;
   }
 
-  if (isNestedComponentTagName(tagName)) {
-    return transformNestedTagName(tagName);
-  }
+  tagName = tagName.replace(SIMPLE_DASHERIZE_REGEXP, (char, index) => {
+    if (char === '/') {
+      return '::';
+    }
 
-  return capitalizedTagName(tagName);
-}
+    if (index === 0 || !ALPHA.test(tagName[index - 1])) {
+      return char.toUpperCase();
+    }
+
+    // Remove all occurances of '-'s from the tagName that aren't starting with `-`
+    return char === '-' ? '' : char.toLowerCase();
+  });
 
-function transformNestedTagName(tagName) {
-  const paths = tagName.split('/');
-  return paths.map(name => capitalizedTagName(name)).join('::');
+  return tagName;
 }
 
 function transformNestedSubExpression(subExpression) {