break out if attr space

Author: tylerturdenpants

transforms/angle-brackets/test.js

@@ -1043,3 +1043,17 @@ test('wallstreet.hbs', () => {
       "
   `);
 });
+
+test('attr-space', () => {
+  let input = `
+    <MyComp::Test @color={{"custom-2"}} @visible={{Group.item.isNew}} />
+    <MyComp @value={{value}} @cont={{this}} @class={{model.some-stuff-here}} />
+  `;
+
+  expect(runTest('attr-space.hbs', input)).toMatchInlineSnapshot(`
+      "
+          <MyComp::Test @color={{\\"custom-2\\"}} @visible={{Group.item.isNew}} />
+          <MyComp @value={{value}} @cont={{this}} @class={{model.some-stuff-here}} />
+        "
+    `);
+});

transforms/angle-brackets/transform.js

@@ -11,6 +11,8 @@ const { builders: b } = recast;
 const HTML_ATTRIBUTES = ['class', 'placeholder', 'required'];
 const BUILT_IN_COMPONENTS = ['link-to', 'input', 'textarea'];
 
+let inAttr = false;
+
 function isAttribute(key) {
   return HTML_ATTRIBUTES.includes(key) || isDataAttribute(key);
 }
@@ -299,7 +301,7 @@ function transformNode(node, fileInfo, config) {
     return;
   }
 
-  const newTagName = transformTagName(tagName);
+  const newTagName = transformTagName(tagName, inAttr);
 
   let attributes;
   let children = node.program ? node.program.body : undefined;
@@ -321,7 +323,7 @@ function transformNode(node, fileInfo, config) {
     let namesParams = transformAttrs(tagName, node.hash.pairs);
     attributes = attributes.concat(namesParams);
   } else {
-    if (nodeHasPositionalParameters(node)) {
+    if (nodeHasPositionalParameters(node) || inAttr) {
       logger.warn(
         `WARNING: {{${node.path.original}}} was not converted as it has positional parameters which can't be automatically converted. Source: ${fileInfo.path}`
       );
@@ -391,5 +393,13 @@ function transformToAngleBracket(_, fileInfo, config) {
         return transformNode(node, fileInfo, config);
       }
     },
+    AttrNode: {
+      enter() {
+        inAttr = true;
+      },
+      exit() {
+        inAttr = false;
+      },
+    },
   };
 }