Skip to content

Commit 05bc8cc

Browse files
Turbo87tylerturdenpants
authored andcommitted
Update list of common helpers (#137)
* Sort `IGNORE_MUSTACHE_STATEMENTS` list and add more addon names * Remove `ember-ast-hot-load` helpers from `IGNORE_MUSTACHE_STATEMENTS` list The addon does not expose these helpers publicly, they are only use internally, so we don't need to care about them for this codemod. * Add `ember-animated` helpers to `IGNORE_MUSTACHE_STATEMENTS` list * Remove unknown helpers from `IGNORE_MUSTACHE_STATEMENTS` list We don't know where these helper names are coming from and EmberObserver code search is now showing any results for these either. If people actually rely on them they can add them manually to the helpers list. * Add more `ember-route-helpers` helpers to `IGNORE_MUSTACHE_STATEMENTS` list
1 parent d6e781b commit 05bc8cc

1 file changed

Lines changed: 58 additions & 55 deletions

File tree

transforms/angle-brackets/transform.js

Lines changed: 58 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -15,90 +15,86 @@ const BUILT_IN_COMPONENTS = ['link-to', 'input', 'textarea'];
1515
* Politely lifted from https://github.com/lifeart/ember-ast-hot-load/blob/master/lib/ast-transform.js#L26
1616
*/
1717
const IGNORE_MUSTACHE_STATEMENTS = [
18-
'identity', // glimmer blocks
19-
'render-inverse', // glimmer blocks
20-
'-get-dynamic-var', // glimmer internal helper
21-
'-lf-get-outlet-state', // dunno
18+
// Ember.js
2219
'action',
20+
'array',
2321
'component',
24-
'hot-content',
25-
'hot-placeholder',
26-
'if',
27-
'if-unless',
22+
'concat',
23+
'debugger',
2824
'each',
2925
'each-in',
30-
'format-date',
31-
'format-message',
32-
'format-relative',
33-
'format-time',
34-
'format-money',
35-
'format-number',
36-
'unless',
26+
'else',
27+
'get',
28+
'hash',
29+
'if',
30+
'if-unless',
3731
'in-element',
38-
'query-params',
3932
'-in-element',
40-
'-class',
41-
'-html-safe',
42-
'-input-type',
43-
'-normalize-class',
44-
'concat',
45-
'get',
33+
'let',
34+
'loc',
35+
'log',
4636
'mut',
37+
'outlet',
38+
'partial',
39+
'query-params',
4740
'readonly',
4841
'unbound',
49-
'debugger',
50-
'else',
51-
'let',
42+
'unless',
5243
'with',
53-
'log',
54-
'loc',
55-
'hash',
56-
'partial',
5744
'yield',
58-
't',
59-
't-for',
45+
46+
// Glimmer VM
47+
'identity', // glimmer blocks
48+
'render-inverse', // glimmer blocks
49+
'-get-dynamic-var', // glimmer internal helper
50+
51+
// ember-route-helpers
6052
'transition-to',
61-
'get-meta',
62-
'get-attr',
63-
'index-of',
64-
'array',
53+
'replace-with',
54+
'transition-to-external',
55+
'replace-with-external',
6556

66-
//ember-moment
57+
// ember-intl
58+
'format-date',
59+
'format-message',
60+
'format-relative',
61+
'format-time',
62+
'format-money',
63+
'format-number',
64+
't',
65+
66+
// ember-moment
67+
'is-after',
68+
'is-before',
69+
'is-between',
70+
'is-same',
71+
'is-same-or-after',
72+
'is-same-or-before',
6773
'moment',
74+
'moment-calendar',
75+
'moment-diff',
76+
'moment-duration',
6877
'moment-format',
69-
'moment-from-now',
7078
'moment-from',
79+
'moment-from-now',
7180
'moment-to',
7281
'moment-to-now',
73-
'moment-duration',
74-
'moment-calendar',
75-
'moment-diff',
76-
77-
'outlet',
78-
79-
'is-before',
80-
'is-after',
81-
'is-same',
82-
'is-same-or-before',
83-
'is-same-or-after',
84-
'is-between',
8582
'now',
8683
'unix',
8784

88-
//cp-validations
85+
// ember-cp-validations
8986
'v-get',
9087

91-
//route-action
88+
// ember-route-action-helper
9289
'route-action',
9390

94-
// composable-helpers
91+
// ember-composable-helpers
9592
'map-by',
9693
'sort-by',
9794
'filter-by',
9895
'reject-by',
9996
'find-by',
10097
'object-at',
101-
'hasBlock',
10298
'has-block',
10399
'has-next',
104100
'has-previous',
@@ -108,7 +104,7 @@ const IGNORE_MUSTACHE_STATEMENTS = [
108104
'is-empty',
109105
'is-equal',
110106

111-
// liquid
107+
// liquid-fire
112108
'liquid-unless',
113109
'liquid-container',
114110
'liquid-outlet',
@@ -120,7 +116,14 @@ const IGNORE_MUSTACHE_STATEMENTS = [
120116
'liquid-child',
121117
'liquid-if',
122118

123-
//app-version
119+
// ember-animated
120+
'animated-beacon',
121+
'animated-each',
122+
'animated-if',
123+
'animated-orphans',
124+
'animated-value',
125+
126+
// ember-app-version
124127
'app-version',
125128
];
126129

0 commit comments

Comments
 (0)