From eb03e6b60a6b2afa4abdd66873c6e1ec7ef1bfc0 Mon Sep 17 00:00:00 2001 From: Tommy Carter Date: Fri, 3 Apr 2026 13:35:18 -0500 Subject: [PATCH 1/3] Test cases for no-invalid-link-text --- .../rules/template-no-invalid-link-text.js | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tests/lib/rules/template-no-invalid-link-text.js b/tests/lib/rules/template-no-invalid-link-text.js index f6e74ce8a8..59e75709de 100644 --- a/tests/lib/rules/template-no-invalid-link-text.js +++ b/tests/lib/rules/template-no-invalid-link-text.js @@ -53,6 +53,29 @@ ruleTester.run('template-no-invalid-link-text', rule, { filename: 'test.gjs', code: "import { LinkTo } from '@ember/routing'; ", }, + { + filename: 'test.gjs', + code: '', + }, + { + filename: 'test.gjs', + code: ` + import { LinkTo } from '@ember/routing'; + + `, + }, + { + filename: 'test.gjs', + code: ``, + }, ], invalid: [ From 0e09f9e252e1784f55cc0ae12e894a0ce95bd2f4 Mon Sep 17 00:00:00 2001 From: Tommy Carter Date: Sat, 4 Apr 2026 09:37:13 -0500 Subject: [PATCH 2/3] Add GlimmerBlockStatement to dynamic determination --- lib/rules/template-no-invalid-link-text.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rules/template-no-invalid-link-text.js b/lib/rules/template-no-invalid-link-text.js index 04fdea310c..a4b02c9097 100644 --- a/lib/rules/template-no-invalid-link-text.js +++ b/lib/rules/template-no-invalid-link-text.js @@ -4,7 +4,11 @@ function getTextContentResult(node) { if (node.type === 'GlimmerTextNode') { return { text: node.chars.replaceAll(' ', ' '), hasDynamic: false }; } - if (node.type === 'GlimmerMustacheStatement' || node.type === 'GlimmerSubExpression') { + if ( + node.type === 'GlimmerMustacheStatement' || + node.type === 'GlimmerSubExpression' || + node.type === 'GlimmerBlockStatement' + ) { return { text: '', hasDynamic: true }; } if (node.type === 'GlimmerElementNode' && node.children) { From dc7d37d58b1e2cac87f364e90132b0bf2bbf7702 Mon Sep 17 00:00:00 2001 From: Tommy Carter Date: Sat, 4 Apr 2026 09:50:59 -0500 Subject: [PATCH 3/3] Change quotes to pass lint --- tests/lib/rules/template-no-invalid-link-text.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lib/rules/template-no-invalid-link-text.js b/tests/lib/rules/template-no-invalid-link-text.js index 59e75709de..4aa0fdca28 100644 --- a/tests/lib/rules/template-no-invalid-link-text.js +++ b/tests/lib/rules/template-no-invalid-link-text.js @@ -74,7 +74,7 @@ ruleTester.run('template-no-invalid-link-text', rule, { }, { filename: 'test.gjs', - code: ``, + code: '', }, ],