From ec75bdc527c8c9a44fa1b2858d104340d32e4d9b Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Thu, 29 Jan 2026 11:56:23 -0500 Subject: [PATCH 1/7] Allow lint fix to work, add prettier scripts (prettier already present, and thus already running in editors) --- eslint.config.js | 2 +- package.json | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index b5b2f388e5..01f4696f5c 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -230,7 +230,7 @@ module.exports = [ { ignores: [ 'coverage/', - 'node_modules/', + 'node_modules/**', 'lib/recommended-rules.js', 'lib/recommended-rules-gjs.js', 'lib/recommended-rules-gts.js', diff --git a/package.json b/package.json index a1cc9ce32b..ffee54ffa2 100644 --- a/package.json +++ b/package.json @@ -44,11 +44,13 @@ "lint:eslint-docs:fix": "npm-run-all \"update:eslint-docs\"", "lint:fix": "npm-run-all \"lint:*:fix\"", "lint:js": "eslint .", + "lint:prettier": "prettier . --check", "lint:js:fix": "pnpm lint:js --fix", "lint:package-json": "npmPkgJsonLint .", "lint:package-json-sorting": "sort-package-json --check", "lint:package-json-sorting:fix": "sort-package-json package.json", "lint:remote": "eslint-remote-tester", + "format": "prettier . --write", "start": "pnpm test:watch", "test": "vitest run", "test:coverage": "vitest --coverage", @@ -118,7 +120,7 @@ "node": "18.* || 20.* || >= 21" }, "volta": { - "node": "22.10.0", + "node": "22.22.0", "pnpm": "9.12.2" }, "publishConfig": { From c525b9b1b296f97d5c84bfb8e606d0fd2eab3140 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Thu, 29 Jan 2026 12:02:08 -0500 Subject: [PATCH 2/7] Run prettier --- .github/workflows/ci.yml | 52 +- .github/workflows/codeql-analysis.yml | 58 +- .github/workflows/plan-release.yml | 4 +- .github/workflows/publish.yml | 2 +- CHANGELOG.md | 2314 ++++--- README.md | 276 +- docs/rules/_TEMPLATE_.md | 2 + docs/rules/alias-model-in-controller.md | 10 +- .../avoid-leaking-state-in-ember-objects.md | 16 +- .../rules/avoid-using-needs-in-controllers.md | 8 +- docs/rules/closure-actions.md | 12 +- docs/rules/computed-property-getters.md | 36 +- docs/rules/named-functions-in-promises.md | 4 +- docs/rules/no-actions-hash.md | 8 +- .../no-arrow-function-computed-properties.md | 4 +- ...ed-properties-used-in-tracking-contexts.md | 26 +- docs/rules/no-attrs-snapshot.md | 4 +- docs/rules/no-builtin-form-components.md | 32 +- ...-deeply-nested-dependent-keys-with-each.md | 4 +- docs/rules/no-ember-super-in-es-classes.md | 2 +- .../rules/no-ember-testing-in-module-scope.md | 8 +- docs/rules/no-empty-attrs.md | 8 +- .../rules/no-function-prototype-extensions.md | 4 +- docs/rules/no-global-jquery.md | 4 +- docs/rules/no-html-safe.md | 14 +- docs/rules/no-implicit-injections.md | 32 +- ...t-calls-with-inline-anonymous-functions.md | 4 +- docs/rules/no-incorrect-computed-macros.md | 4 +- docs/rules/no-invalid-dependent-keys.md | 20 +- docs/rules/no-jquery.md | 8 +- docs/rules/no-legacy-test-waiters.md | 6 +- docs/rules/no-mixins.md | 4 +- docs/rules/no-new-mixins.md | 6 +- docs/rules/no-observers.md | 8 +- docs/rules/no-on-calls-in-components.md | 4 +- docs/rules/no-private-routing-service.md | 4 +- docs/rules/no-restricted-resolver-tests.md | 36 +- .../rules/no-restricted-service-injections.md | 26 +- docs/rules/no-side-effects.md | 4 +- docs/rules/no-test-module-for.md | 44 +- docs/rules/no-tracked-properties-from-args.md | 8 +- ...-unnecessary-service-injection-argument.md | 8 +- docs/rules/no-volatile-computed-properties.md | 4 +- docs/rules/order-in-components.md | 20 +- docs/rules/order-in-controllers.md | 20 +- docs/rules/order-in-models.md | 26 +- docs/rules/order-in-routes.md | 24 +- docs/rules/require-computed-macros.md | 6 +- .../require-computed-property-dependencies.md | 4 +- docs/rules/require-return-from-computed.md | 8 +- .../rules/require-super-in-lifecycle-hooks.md | 8 +- docs/rules/require-tagless-components.md | 4 +- docs/rules/template-indent.md | 2 +- docs/rules/template-no-let-reference.md | 16 +- docs/rules/use-brace-expansion.md | 4 +- lib/recommended-rules-gjs.js | 4 +- lib/recommended-rules-gts.js | 4 +- package.json | 2 +- pnpm-lock.yaml | 5611 ++++++++++++----- .../rules-preprocessor/tsconfig.eslint.json | 5 +- 60 files changed, 5993 insertions(+), 2917 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f1f99bba26..1fe159450c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,44 +5,44 @@ name: CI on: push: - branches: [ master ] + branches: [master] pull_request: - branches: [ master ] + branches: [master] jobs: self-lint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v6 - - uses: pnpm/action-setup@v4 - with: - run_install: false - - uses: actions/setup-node@v6 - with: - node-version: 22.x - cache: 'pnpm' - - - run: pnpm install - - run: pnpm lint + - uses: actions/checkout@v6 + - uses: pnpm/action-setup@v4 + with: + run_install: false + - uses: actions/setup-node@v6 + with: + node-version: 22.x + cache: 'pnpm' + + - run: pnpm install + - run: pnpm lint build: runs-on: ${{ matrix.os }}-latest strategy: matrix: - os: [ ubuntu, windows ] + os: [ubuntu, windows] node-version: [18.x, 20.x, 22.x] steps: - - uses: actions/checkout@v6 - - uses: pnpm/action-setup@v4 - with: - run_install: false - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v6 - with: - node-version: ${{ matrix.node-version }} - cache: 'pnpm' - - - run: pnpm install - - run: pnpm test:coverage + - uses: actions/checkout@v6 + - uses: pnpm/action-setup@v4 + with: + run_install: false + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v6 + with: + node-version: ${{ matrix.node-version }} + cache: 'pnpm' + + - run: pnpm install + - run: pnpm test:coverage diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index f8afe923d4..cfb6c67ba3 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -9,14 +9,14 @@ # the `language` matrix defined below to confirm you have the correct set of # supported CodeQL languages. # -name: "CodeQL" +name: 'CodeQL' on: push: - branches: [ master ] + branches: [master] pull_request: # The branches below must be a subset of the branches above - branches: [ master ] + branches: [master] schedule: - cron: '18 9 * * 2' @@ -32,40 +32,40 @@ jobs: strategy: fail-fast: false matrix: - language: [ 'javascript' ] + language: ['javascript'] # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ] # Learn more: # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed steps: - - name: Checkout repository - uses: actions/checkout@v6 + - name: Checkout repository + uses: actions/checkout@v6 - # Initializes the CodeQL tools for scanning. - - name: Initialize CodeQL - uses: github/codeql-action/init@v3 - with: - languages: ${{ matrix.language }} - # If you wish to specify custom queries, you can do so here or in a config file. - # By default, queries listed here will override any specified in a config file. - # Prefix the list here with "+" to use these queries and those in the config file. - # queries: ./path/to/local/query, your-org/your-repo/queries@main + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v3 + with: + languages: ${{ matrix.language }} + # If you wish to specify custom queries, you can do so here or in a config file. + # By default, queries listed here will override any specified in a config file. + # Prefix the list here with "+" to use these queries and those in the config file. + # queries: ./path/to/local/query, your-org/your-repo/queries@main - # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). - # If this step fails, then you should remove it and run the build manually (see below) - - name: Autobuild - uses: github/codeql-action/autobuild@v3 + # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). + # If this step fails, then you should remove it and run the build manually (see below) + - name: Autobuild + uses: github/codeql-action/autobuild@v3 - # ℹ️ Command-line programs to run using the OS shell. - # 📚 https://git.io/JvXDl + # ℹ️ Command-line programs to run using the OS shell. + # 📚 https://git.io/JvXDl - # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines - # and modify them (or add more) to build your code if your project - # uses a compiled language + # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines + # and modify them (or add more) to build your code if your project + # uses a compiled language - #- run: | - # make bootstrap - # make release + #- run: | + # make bootstrap + # make release - - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v3 + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v3 diff --git a/.github/workflows/plan-release.yml b/.github/workflows/plan-release.yml index 866939778d..2ef1889327 100644 --- a/.github/workflows/plan-release.yml +++ b/.github/workflows/plan-release.yml @@ -35,7 +35,7 @@ jobs: contents: write issues: read pull-requests: write - if: needs.should-run-release-plan-prepare.outputs.should-prepare == 'true' + if: needs.should-run-release-plan-prepare.outputs.should-prepare == 'true' steps: - uses: release-plan/actions/prepare@v1 name: Run release-plan prepare @@ -49,7 +49,7 @@ jobs: name: Create Prepare Release PR with: commit-message: "Prepare Release ${{ steps.explanation.outputs.new-version}} using 'release-plan'" - labels: "internal" + labels: 'internal' sign-commits: true branch: release-preview title: Prepare Release ${{ steps.explanation.outputs.new-version }} diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 2b225f5549..3617475fcf 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -18,7 +18,7 @@ concurrency: jobs: publish: - name: "NPM Publish" + name: 'NPM Publish' runs-on: ubuntu-latest permissions: contents: write diff --git a/CHANGELOG.md b/CHANGELOG.md index aa47025e63..96ce999313 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,18 +2,21 @@ ## Release (2026-01-22) -* eslint-plugin-ember 12.7.6 (patch) +- eslint-plugin-ember 12.7.6 (patch) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2363](https://github.com/ember-cli/eslint-plugin-ember/pull/2363) fix: classic-decorator-no-classic-methods matching private identifiers ([@c0rydoras](https://github.com/c0rydoras)) - * [#2364](https://github.com/ember-cli/eslint-plugin-ember/pull/2364) Consider .test.{js|ts|gjs|gts} as a test file pattern ([@lego-technix](https://github.com/lego-technix)) + +- `eslint-plugin-ember` + - [#2363](https://github.com/ember-cli/eslint-plugin-ember/pull/2363) fix: classic-decorator-no-classic-methods matching private identifiers ([@c0rydoras](https://github.com/c0rydoras)) + - [#2364](https://github.com/ember-cli/eslint-plugin-ember/pull/2364) Consider .test.{js|ts|gjs|gts} as a test file pattern ([@lego-technix](https://github.com/lego-technix)) #### :house: Internal -* `eslint-plugin-ember` - * [#2334](https://github.com/ember-cli/eslint-plugin-ember/pull/2334) pnpm dlx create-release-plan-setup@latest --update ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- `eslint-plugin-ember` + - [#2334](https://github.com/ember-cli/eslint-plugin-ember/pull/2334) pnpm dlx create-release-plan-setup@latest --update ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### Committers: 3 + - Arthur ([@c0rydoras](https://github.com/c0rydoras)) - LEGO Technix ([@lego-technix](https://github.com/lego-technix)) - [@NullVoxPopuli](https://github.com/NullVoxPopuli) @@ -23,10 +26,12 @@ eslint-plugin-ember 12.7.5 (patch) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2349](https://github.com/ember-cli/eslint-plugin-ember/pull/2349) fix: allow decorated template-tag-only classes ([@CvX](https://github.com/CvX)) + +- `eslint-plugin-ember` + - [#2349](https://github.com/ember-cli/eslint-plugin-ember/pull/2349) fix: allow decorated template-tag-only classes ([@CvX](https://github.com/CvX)) #### Committers: 1 + - Jarek Radosz ([@CvX](https://github.com/CvX)) ## Release (2025-09-14) @@ -34,14 +39,17 @@ eslint-plugin-ember 12.7.5 (patch) eslint-plugin-ember 12.7.4 (patch) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2331](https://github.com/ember-cli/eslint-plugin-ember/pull/2331) fix: Ignore `findBy` calls from `ember-cli-mirage` in `no-array-prototype-extensions` ([@VasylMarchuk](https://github.com/VasylMarchuk)) + +- `eslint-plugin-ember` + - [#2331](https://github.com/ember-cli/eslint-plugin-ember/pull/2331) fix: Ignore `findBy` calls from `ember-cli-mirage` in `no-array-prototype-extensions` ([@VasylMarchuk](https://github.com/VasylMarchuk)) #### :house: Internal -* `eslint-plugin-ember` - * [#2332](https://github.com/ember-cli/eslint-plugin-ember/pull/2332) chore: try actions/setup-node before pnpm/action-setup ([@bmish](https://github.com/bmish)) + +- `eslint-plugin-ember` + - [#2332](https://github.com/ember-cli/eslint-plugin-ember/pull/2332) chore: try actions/setup-node before pnpm/action-setup ([@bmish](https://github.com/bmish)) #### Committers: 2 + - Bryan Mishkin ([@bmish](https://github.com/bmish)) - Vasyl Marchuk ([@VasylMarchuk](https://github.com/VasylMarchuk)) @@ -50,10 +58,12 @@ eslint-plugin-ember 12.7.4 (patch) eslint-plugin-ember 12.7.3 (patch) #### :house: Internal -* `eslint-plugin-ember` - * [#2323](https://github.com/ember-cli/eslint-plugin-ember/pull/2323) chore: add npm provenance to publishing (second attempt) ([@bmish](https://github.com/bmish)) + +- `eslint-plugin-ember` + - [#2323](https://github.com/ember-cli/eslint-plugin-ember/pull/2323) chore: add npm provenance to publishing (second attempt) ([@bmish](https://github.com/bmish)) #### Committers: 1 + - Bryan Mishkin ([@bmish](https://github.com/bmish)) ## Release (2025-08-22) @@ -61,10 +71,12 @@ eslint-plugin-ember 12.7.3 (patch) eslint-plugin-ember 12.7.2 (patch) #### :house: Internal -* `eslint-plugin-ember` - * [#2321](https://github.com/ember-cli/eslint-plugin-ember/pull/2321) chore: add npm provenance to publishing ([@bmish](https://github.com/bmish)) + +- `eslint-plugin-ember` + - [#2321](https://github.com/ember-cli/eslint-plugin-ember/pull/2321) chore: add npm provenance to publishing ([@bmish](https://github.com/bmish)) #### Committers: 1 + - Bryan Mishkin ([@bmish](https://github.com/bmish)) ## Release (2025-08-22) @@ -72,15 +84,18 @@ eslint-plugin-ember 12.7.2 (patch) eslint-plugin-ember 12.7.1 (patch) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2320](https://github.com/ember-cli/eslint-plugin-ember/pull/2320) fix: `no-array-prototype-extensions` rule to lint against `setObjects()` ([@MrChocolatine](https://github.com/MrChocolatine)) - * [#2315](https://github.com/ember-cli/eslint-plugin-ember/pull/2315) fix: no-runloop: catch namespace imports ([@Geodewd549](https://github.com/Geodewd549)) + +- `eslint-plugin-ember` + - [#2320](https://github.com/ember-cli/eslint-plugin-ember/pull/2320) fix: `no-array-prototype-extensions` rule to lint against `setObjects()` ([@MrChocolatine](https://github.com/MrChocolatine)) + - [#2315](https://github.com/ember-cli/eslint-plugin-ember/pull/2315) fix: no-runloop: catch namespace imports ([@Geodewd549](https://github.com/Geodewd549)) #### :memo: Documentation -* `eslint-plugin-ember` - * [#2313](https://github.com/ember-cli/eslint-plugin-ember/pull/2313) Remove name from CHANGELOG ([@rmachielse](https://github.com/rmachielse)) + +- `eslint-plugin-ember` + - [#2313](https://github.com/ember-cli/eslint-plugin-ember/pull/2313) Remove name from CHANGELOG ([@rmachielse](https://github.com/rmachielse)) #### Committers: 3 + - Richard ([@rmachielse](https://github.com/rmachielse)) - [@Geodewd549](https://github.com/Geodewd549) - [@MrChocolatine](https://github.com/MrChocolatine) @@ -90,14 +105,17 @@ eslint-plugin-ember 12.7.1 (patch) eslint-plugin-ember 12.7.0 (minor) #### :rocket: Enhancement -* `eslint-plugin-ember` - * [#2282](https://github.com/ember-cli/eslint-plugin-ember/pull/2282) Add no-builtin-form-components rule ([@wagenet](https://github.com/wagenet)) + +- `eslint-plugin-ember` + - [#2282](https://github.com/ember-cli/eslint-plugin-ember/pull/2282) Add no-builtin-form-components rule ([@wagenet](https://github.com/wagenet)) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2308](https://github.com/ember-cli/eslint-plugin-ember/pull/2308) fix: disallow extra properties in rule options ([@andreww2012](https://github.com/andreww2012)) + +- `eslint-plugin-ember` + - [#2308](https://github.com/ember-cli/eslint-plugin-ember/pull/2308) fix: disallow extra properties in rule options ([@andreww2012](https://github.com/andreww2012)) #### Committers: 2 + - Andrew Kazakov ([@andreww2012](https://github.com/andreww2012)) - Peter Wagenet ([@wagenet](https://github.com/wagenet)) @@ -106,10 +124,12 @@ eslint-plugin-ember 12.7.0 (minor) eslint-plugin-ember 12.6.0 (minor) #### :rocket: Enhancement -* `eslint-plugin-ember` - * [#2306](https://github.com/ember-cli/eslint-plugin-ember/pull/2306) Add names for the eslint-inspector ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- `eslint-plugin-ember` + - [#2306](https://github.com/ember-cli/eslint-plugin-ember/pull/2306) Add names for the eslint-inspector ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### Committers: 1 + - [@NullVoxPopuli](https://github.com/NullVoxPopuli) ## Release (2025-01-30) @@ -117,14 +137,17 @@ eslint-plugin-ember 12.6.0 (minor) eslint-plugin-ember 12.5.0 (minor) #### :rocket: Enhancement -* `eslint-plugin-ember` - * [#2251](https://github.com/ember-cli/eslint-plugin-ember/pull/2251) Force bump the parser to latest, 0.5.9 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- `eslint-plugin-ember` + - [#2251](https://github.com/ember-cli/eslint-plugin-ember/pull/2251) Force bump the parser to latest, 0.5.9 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### :house: Internal -* `eslint-plugin-ember` - * [#2252](https://github.com/ember-cli/eslint-plugin-ember/pull/2252) Prepare Release ([@github-actions[bot]](https://github.com/apps/github-actions)) + +- `eslint-plugin-ember` + - [#2252](https://github.com/ember-cli/eslint-plugin-ember/pull/2252) Prepare Release ([@github-actions[bot]](https://github.com/apps/github-actions)) #### Committers: 2 + - [@NullVoxPopuli](https://github.com/NullVoxPopuli) - [@github-actions[bot]](https://github.com/apps/github-actions) @@ -133,10 +156,12 @@ eslint-plugin-ember 12.5.0 (minor) eslint-plugin-ember 12.4.0 (minor) #### :rocket: Enhancement -* `eslint-plugin-ember` - * [#2251](https://github.com/ember-cli/eslint-plugin-ember/pull/2251) Force bump the parser to latest, 0.5.9 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- `eslint-plugin-ember` + - [#2251](https://github.com/ember-cli/eslint-plugin-ember/pull/2251) Force bump the parser to latest, 0.5.9 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### Committers: 1 + - [@NullVoxPopuli](https://github.com/NullVoxPopuli) ## Release (2024-11-22) @@ -144,10 +169,12 @@ eslint-plugin-ember 12.4.0 (minor) eslint-plugin-ember 12.3.3 (patch) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2220](https://github.com/ember-cli/eslint-plugin-ember/pull/2220) Bump minimum parser version (fixes SVGs, MathML, custom-elements) ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- `eslint-plugin-ember` + - [#2220](https://github.com/ember-cli/eslint-plugin-ember/pull/2220) Bump minimum parser version (fixes SVGs, MathML, custom-elements) ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### Committers: 1 + - [@NullVoxPopuli](https://github.com/NullVoxPopuli) ## Release (2024-11-21) @@ -155,10 +182,12 @@ eslint-plugin-ember 12.3.3 (patch) eslint-plugin-ember 12.3.2 (patch) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2216](https://github.com/ember-cli/eslint-plugin-ember/pull/2216) upgrade parser ([@patricklx](https://github.com/patricklx)) + +- `eslint-plugin-ember` + - [#2216](https://github.com/ember-cli/eslint-plugin-ember/pull/2216) upgrade parser ([@patricklx](https://github.com/patricklx)) #### Committers: 1 + - Patrick Pircher ([@patricklx](https://github.com/patricklx)) ## Release (2024-10-25) @@ -166,10 +195,12 @@ eslint-plugin-ember 12.3.2 (patch) eslint-plugin-ember 12.3.1 (patch) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2200](https://github.com/ember-cli/eslint-plugin-ember/pull/2200) Fix no-component-lifecycle-hook in double extended classic component ([@wagenet](https://github.com/wagenet)) + +- `eslint-plugin-ember` + - [#2200](https://github.com/ember-cli/eslint-plugin-ember/pull/2200) Fix no-component-lifecycle-hook in double extended classic component ([@wagenet](https://github.com/wagenet)) #### Committers: 1 + - Peter Wagenet ([@wagenet](https://github.com/wagenet)) ## Release (2024-10-23) @@ -177,983 +208,1105 @@ eslint-plugin-ember 12.3.1 (patch) eslint-plugin-ember 12.3.0 (minor) #### :rocket: Enhancement -* `eslint-plugin-ember` - * [#2191](https://github.com/ember-cli/eslint-plugin-ember/pull/2191) Provide better gjs/gts config support for eslint 9 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- `eslint-plugin-ember` + - [#2191](https://github.com/ember-cli/eslint-plugin-ember/pull/2191) Provide better gjs/gts config support for eslint 9 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### :bug: Bug Fix -* `eslint-plugin-ember` - * [#2195](https://github.com/ember-cli/eslint-plugin-ember/pull/2195) fix: Typo in error message ([@HeroicEric](https://github.com/HeroicEric)) + +- `eslint-plugin-ember` + - [#2195](https://github.com/ember-cli/eslint-plugin-ember/pull/2195) fix: Typo in error message ([@HeroicEric](https://github.com/HeroicEric)) #### :house: Internal -* `eslint-plugin-ember` - * [#2198](https://github.com/ember-cli/eslint-plugin-ember/pull/2198) Switch away from release-it to release-plan ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) - * [#2196](https://github.com/ember-cli/eslint-plugin-ember/pull/2196) Switch to pnpm + vitest (away from yarn @ 1 and jest) ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- `eslint-plugin-ember` + - [#2198](https://github.com/ember-cli/eslint-plugin-ember/pull/2198) Switch away from release-it to release-plan ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + - [#2196](https://github.com/ember-cli/eslint-plugin-ember/pull/2196) Switch to pnpm + vitest (away from yarn @ 1 and jest) ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### Committers: 2 + - Eric Kelly ([@HeroicEric](https://github.com/HeroicEric)) - [@NullVoxPopuli](https://github.com/NullVoxPopuli) - - - - - - - - - ## v12.2.1 (2024-09-25) #### :bug: Bug Fix -* [#2163](https://github.com/ember-cli/eslint-plugin-ember/pull/2163) Bump the parser ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) -* [#2162](https://github.com/ember-cli/eslint-plugin-ember/pull/2162) Allow imports from `ember-data/store` ([@Windvis](https://github.com/Windvis)) + +- [#2163](https://github.com/ember-cli/eslint-plugin-ember/pull/2163) Bump the parser ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) +- [#2162](https://github.com/ember-cli/eslint-plugin-ember/pull/2162) Allow imports from `ember-data/store` ([@Windvis](https://github.com/Windvis)) #### Committers: 2 + - Sam Van Campenhout ([@Windvis](https://github.com/Windvis)) - [@NullVoxPopuli](https://github.com/NullVoxPopuli) ## v12.2.0 (2024-08-17) #### :rocket: Enhancement -* [#2155](https://github.com/ember-cli/eslint-plugin-ember/pull/2155) Add new ember-data rule: `require-async-inverse-relationship` ([@wozny1989](https://github.com/wozny1989)) -* [#2157](https://github.com/ember-cli/eslint-plugin-ember/pull/2157) Consider `_test.{js|ts|gjs|gts}` as test file. ([@HEYGUL](https://github.com/HEYGUL)) + +- [#2155](https://github.com/ember-cli/eslint-plugin-ember/pull/2155) Add new ember-data rule: `require-async-inverse-relationship` ([@wozny1989](https://github.com/wozny1989)) +- [#2157](https://github.com/ember-cli/eslint-plugin-ember/pull/2157) Consider `_test.{js|ts|gjs|gts}` as test file. ([@HEYGUL](https://github.com/HEYGUL)) #### :bug: Bug Fix -* [#2159](https://github.com/ember-cli/eslint-plugin-ember/pull/2159) Fix deprecation blocking eslint v9 ([@LucasHill](https://github.com/LucasHill)) -* [#2151](https://github.com/ember-cli/eslint-plugin-ember/pull/2151) Fix false positive error for `no-runloop` ([@mkszepp](https://github.com/mkszepp)) + +- [#2159](https://github.com/ember-cli/eslint-plugin-ember/pull/2159) Fix deprecation blocking eslint v9 ([@LucasHill](https://github.com/LucasHill)) +- [#2151](https://github.com/ember-cli/eslint-plugin-ember/pull/2151) Fix false positive error for `no-runloop` ([@mkszepp](https://github.com/mkszepp)) #### :house: Internal -* [#2153](https://github.com/ember-cli/eslint-plugin-ember/pull/2153) Fix API deprecations blocking eslint v9 compatibility ([@LucasHill](https://github.com/LucasHill)) + +- [#2153](https://github.com/ember-cli/eslint-plugin-ember/pull/2153) Fix API deprecations blocking eslint v9 compatibility ([@LucasHill](https://github.com/LucasHill)) #### Committers: 4 + - Adam Woźny ([@wozny1989](https://github.com/wozny1989)) - GUL ([@HEYGUL](https://github.com/HEYGUL)) - Lucas Hill ([@LucasHill](https://github.com/LucasHill)) - Markus Sanin ([@mkszepp](https://github.com/mkszepp)) - ## v12.1.1 (2024-05-21) #### :bug: Bug Fix -* [#2149](https://github.com/ember-cli/eslint-plugin-ember/pull/2149) Bump parser version ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) -* [#2148](https://github.com/ember-cli/eslint-plugin-ember/pull/2148) fix test after parser update, resolves #2118 ([@patricklx](https://github.com/patricklx)) -* [#2147](https://github.com/ember-cli/eslint-plugin-ember/pull/2147) fix isTestFile - test-aware lints were not correctly identifying gjs and gts tests and test files ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- [#2149](https://github.com/ember-cli/eslint-plugin-ember/pull/2149) Bump parser version ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) +- [#2148](https://github.com/ember-cli/eslint-plugin-ember/pull/2148) fix test after parser update, resolves #2118 ([@patricklx](https://github.com/patricklx)) +- [#2147](https://github.com/ember-cli/eslint-plugin-ember/pull/2147) fix isTestFile - test-aware lints were not correctly identifying gjs and gts tests and test files ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### Committers: 1 -- [@NullVoxPopuli](https://github.com/NullVoxPopuli) +- [@NullVoxPopuli](https://github.com/NullVoxPopuli) ## v12.1.0 (2024-05-14) #### :rocket: Enhancement -* [#2117](https://github.com/ember-cli/eslint-plugin-ember/pull/2117) update ember eslint parser ([@patricklx](https://github.com/patricklx)) + +- [#2117](https://github.com/ember-cli/eslint-plugin-ember/pull/2117) update ember eslint parser ([@patricklx](https://github.com/patricklx)) #### :bug: Bug Fix -* [#2107](https://github.com/ember-cli/eslint-plugin-ember/pull/2107) include recommended ts-eslint rules for gts ([@patricklx](https://github.com/patricklx)) + +- [#2107](https://github.com/ember-cli/eslint-plugin-ember/pull/2107) include recommended ts-eslint rules for gts ([@patricklx](https://github.com/patricklx)) #### :memo: Documentation -* [#2142](https://github.com/ember-cli/eslint-plugin-ember/pull/2142) Fix spread operator sample in `no-array-prototype-extensions` rule doc ([@mkszepp](https://github.com/mkszepp)) + +- [#2142](https://github.com/ember-cli/eslint-plugin-ember/pull/2142) Fix spread operator sample in `no-array-prototype-extensions` rule doc ([@mkszepp](https://github.com/mkszepp)) #### Committers: 2 + - Markus Sanin ([@mkszepp](https://github.com/mkszepp)) - Patrick Pircher ([@patricklx](https://github.com/patricklx)) ## v12.0.2 (2024-02-15) #### :bug: Bug Fix -* [#2092](https://github.com/ember-cli/eslint-plugin-ember/pull/2092) Fix flat config for gts/gjs and `noop` parser name ([@bmish](https://github.com/bmish)) -* [#2091](https://github.com/ember-cli/eslint-plugin-ember/pull/2091) Upgrade ember-eslint-parser to 0.3.6 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) + +- [#2092](https://github.com/ember-cli/eslint-plugin-ember/pull/2092) Fix flat config for gts/gjs and `noop` parser name ([@bmish](https://github.com/bmish)) +- [#2091](https://github.com/ember-cli/eslint-plugin-ember/pull/2091) Upgrade ember-eslint-parser to 0.3.6 ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) #### :house: Internal -* [#2093](https://github.com/ember-cli/eslint-plugin-ember/pull/2093) Update linting ([@bmish](https://github.com/bmish)) + +- [#2093](https://github.com/ember-cli/eslint-plugin-ember/pull/2093) Update linting ([@bmish](https://github.com/bmish)) #### Committers: 2 + - Bryan Mishkin ([@bmish](https://github.com/bmish)) - [@NullVoxPopuli](https://github.com/NullVoxPopuli) - ## v12.0.1 (2024-02-13) #### :bug: Bug Fix -* [#2071](https://github.com/ember-cli/eslint-plugin-ember/pull/2071) Fix nested classes case in `no-ember-super-in-es-classes` ([@CvX](https://github.com/CvX)) + +- [#2071](https://github.com/ember-cli/eslint-plugin-ember/pull/2071) Fix nested classes case in `no-ember-super-in-es-classes` ([@CvX](https://github.com/CvX)) #### :memo: Documentation -* [#2088](https://github.com/ember-cli/eslint-plugin-ember/pull/2088) add doc about gts imports in ts files ([@patricklx](https://github.com/patricklx)) -* [#2068](https://github.com/ember-cli/eslint-plugin-ember/pull/2068) add `plugin:@typescript-eslint/recommended` to readme for GTS ([@evoactivity](https://github.com/evoactivity)) + +- [#2088](https://github.com/ember-cli/eslint-plugin-ember/pull/2088) add doc about gts imports in ts files ([@patricklx](https://github.com/patricklx)) +- [#2068](https://github.com/ember-cli/eslint-plugin-ember/pull/2068) add `plugin:@typescript-eslint/recommended` to readme for GTS ([@evoactivity](https://github.com/evoactivity)) #### :house: Internal -* [#2090](https://github.com/ember-cli/eslint-plugin-ember/pull/2090) Refresh lockfile ([@bmish](https://github.com/bmish)) + +- [#2090](https://github.com/ember-cli/eslint-plugin-ember/pull/2090) Refresh lockfile ([@bmish](https://github.com/bmish)) #### Committers: 4 + - Bryan Mishkin ([@bmish](https://github.com/bmish)) - Jarek Radosz ([@CvX](https://github.com/CvX)) - Liam Potter ([@evoactivity](https://github.com/evoactivity)) - Patrick Pircher ([@patricklx](https://github.com/patricklx)) - ## v12.0.0 (2024-01-13) #### :boom: Breaking Change -* [#1962](https://github.com/ember-cli/eslint-plugin-ember/pull/1962) Drop support for Node 14, 16, 19 ([@patricklx](https://github.com/patricklx)) -* [#1963](https://github.com/ember-cli/eslint-plugin-ember/pull/1963) Add new `recommended` rules: `no-at-ember-render-modifiers`, `no-deprecated-router-transition-methods`, `no-implicit-injections`, `no-runloop`, `no-tracked-properties-from-args`, ([@patricklx](https://github.com/patricklx)) -* [#1977](https://github.com/ember-cli/eslint-plugin-ember/pull/1977) Add new `recommended` rule: `template-no-let-reference` ([@bmish](https://github.com/bmish)) -* [#1981](https://github.com/ember-cli/eslint-plugin-ember/pull/1981) Add `template-no-let-reference` rule to `recommended-gjs` and `recommended-gts` configs ([@patricklx](https://github.com/patricklx)) -* [#1967](https://github.com/ember-cli/eslint-plugin-ember/pull/1967) Drop support for ESLint 7 ([@bmish](https://github.com/bmish)) -* [#1978](https://github.com/ember-cli/eslint-plugin-ember/pull/1978) Set config `ecmaVersion` to `2022` ([@bmish](https://github.com/bmish)) -* [#1965](https://github.com/ember-cli/eslint-plugin-ember/pull/1965) Change `useAt` option default to `true` at in `no-get` rule ([@patricklx](https://github.com/patricklx)) -* [#2028](https://github.com/ember-cli/eslint-plugin-ember/pull/2028) Move gjs/gts parser to `ember-eslint-parser` library ([@NullVoxPopuli](https://github.com/NullVoxPopuli)) - -#### :rocket: Enhancement -* [#1939](https://github.com/ember-cli/eslint-plugin-ember/pull/1939) Add new rule `template-no-let-reference` ([@patricklx](https://github.com/patricklx)) -* [#1943](https://github.com/ember-cli/eslint-plugin-ember/pull/1943) Add new rule `template-indent` ([@patricklx](https://github.com/patricklx)) -* [#1971](https://github.com/ember-cli/eslint-plugin-ember/pull/1971) Add template block comment eslint directives ([@patricklx](https://github.com/patricklx)) -* [#1944](https://github.com/ember-cli/eslint-plugin-ember/pull/1944) Add gts/gjs configs ([@patricklx](https://github.com/patricklx)) -* [#1942](https://github.com/ember-cli/eslint-plugin-ember/pull/1942) Use custom parser for gts/gjs ([@patricklx](https://github.com/patricklx)) -* [#1975](https://github.com/ember-cli/eslint-plugin-ember/pull/1975) Update almost all dependencies ([@bmish](https://github.com/bmish)) -* [#1984](https://github.com/ember-cli/eslint-plugin-ember/pull/1984) Update `@typescript-eslint/` dependencies to v6 ([@patricklx](https://github.com/patricklx)) -* [#2020](https://github.com/ember-cli/eslint-plugin-ember/pull/2020) Support ESLint flat config ([@bmish](https://github.com/bmish)) - -#### :bug: Bug Fix -* [#1994](https://github.com/ember-cli/eslint-plugin-ember/pull/1994) [gjs/gts parser] fix locations for ast after templates ([@patricklx](https://github.com/patricklx)) -* [#1992](https://github.com/ember-cli/eslint-plugin-ember/pull/1992) [gjs/gts parser] fix references for tags with a dot & non standard html tags ([@patricklx](https://github.com/patricklx)) -* [#1996](https://github.com/ember-cli/eslint-plugin-ember/pull/1996) [gjs/gts parser] fix type aware linting when using ts+gts files ([@patricklx](https://github.com/patricklx)) -* [#2005](https://github.com/ember-cli/eslint-plugin-ember/pull/2005) [gjs/gts parser] fix parsing when there are multiple default `