Plan v13 Release

[bmish]

Breaking changes:

• Rename recommended config to recommended-legacy, move flat config into exported configs object as recommended, remove string export for flat configs (per Change Request: Standardized export of flat configs to enable programmatic detection eslint/eslint#18095 (comment))
• Update Node support to ^18.18.0 || ^20.9.0 || >=21.1.0" to match ESLint

Previous release:

• v12: https://github.com/ember-cli/eslint-plugin-ember/releases/tag/v12.0.0 (Plan v12 Release #1535)

[Techn1x]

We'll need eslint v9 support too. Currently I get this error

TypeError: context.getAncestors is not a function
from this line

eslint-plugin-ember/lib/rules/require-return-from-computed.js

Lines 69 to 70 in 7e6bca9

	context
	.getAncestors()

context.getAncestors() is replaced in v9
https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context.getancestors()

That's just the one I found, there is potentially other things that need to change for eslint v9

[bmish]

Can you file a separate issue for that? ESLint v9 support can be fixed in a bug fix release.

[Techn1x]

Can do, wasn't sure.

Will jump on that first thing tomorrow

[Techn1x]

#2136

[LucasHill]

Fixed eslint v9 issues here: #2153

[Windvis]

I think we should remove routes-segments-snake-case from the recommended set since the implicit route model hook has now been deprecated and that feature seemed to be the main motivation for this rule.

[NullVoxPopuli]

There are a number of rules, like:

ember/no-implicit-injections                                          |  6224.196 |     5.9%
ember/no-deprecated-router-transition-methods                         |  6217.674 |     5.9%

that we don't need in sufficiently newer version of ember.

We should remove these from the default recommended set.

List of things I've found:

const disableOldEmberLints = {
	// implicit injections are not supported by ember-source 4+
	'ember/no-implicit-injections': 'off',
	// router transition methods are not uspported in ember-source 4+
	'ember/no-deprecated-router-transition-methods': 'off',
	// couldn't find needs in 3.x, so it was probably removed earlier?
	'ember/avoid-using-needs-in-controllers': 'off',

	// ////////////////////
	// Candidates once we deal with tech debt
	// ////////////////////
	// Don't need these when we get rid of '@ember/component'
	// 'ember/no-actions-hash': 'off',
	// 'ember/no-component-lifecycle-hooks': 'off',
	// 'ember/no-attrs-in-components': 'off',
	// 'ember/closure-actions': 'off',
	// 'ember/no-component-lifecycle-hooks': 'off',
	// 'ember/no-observers': 'off',
	// 'ember/require-tagless-components': 'off',
	// 'ember/no-classic-components': 'off',

};

[NullVoxPopuli]

Also: #2282 should be added to the recommended set.